About The Pull Request
AI swarmers are supposed to go after nearly everything in sight, including turfs, but this behavior is broken; I wouldn't be all surprised if other mobs targeting behavior is also broken.
In an attempt to make bees perform better, ListTargets behavior was changed here: #31250
While it does, supposedly, perform better, it also breaks swarmers---andddd I suspect other mobs, as well, as this effectively means anything that's not a mob or an object (primarily turfs).
Either case, this reverts ListTargets back to what it originally was, restoring intended behavior.
That said, since bees are so problematic, they use the current ListTargets behavior to only search for objects and mobs.
fixes: #46938
Changelog
cl Fox McCloud
fix: Fixes AI swarmers just sitting in their base doing nothing
/cl
About The Pull Request
This PR makes it so that silicon PDA verbs like toggle ringer are given only to a silicons that actually have one, like AI or pAI. This is also consistent with other similiar silicon items, like silicon camera.
Why It's Good For The Game
Less bugs.
Changelog
cl Arkatos
fix: Only silicons with a valid PDA will now get PDA-related verbs.
/cl
* Adds caps to plastic bottles
* Non-crafted water bottles now spawned closed
* Added warning message for closed bottles, fixed minor bug
* meme
* Makes the warning only show up when doing valid actions with the bottle
* Clumsy people now have a chance to lose the cap
* Fix small bottle's cap when fallen over, bottles now turn upright when opened on the floor
* Add a minor positive moodlet on bottle flip
* Adds a relic lavaland water bottle that always lands upright
* Moves container fill overlay to reagent_containers, changes glass/beaker/waterbottle to glass/waterbottle
* Make actions with closed cap early return
* Minor code cleanup
* Surgery failure removal
* implement speed scaling (again)
* removed wrong undef
* Removes outdated try_to_fail variable
* Remove outdated comments
* rolls back removals of surgery fails
* restores try_to_fail and failure proc
last important changes are in /initiate()
* meat of the PR
modded time now caps out
fail chance is reworked to be based on modded time
failing is possible again
* cap fail_prob at 100
just-in-case to avoid any byond weirdness with prob being >100
* messages for different fail probs
* fail chance caps at 99%
there is always a 1% chance to succeed
* borgs immune to slow, stasis bed check
* wake up, travis
* undoes mysterious floor surgery nerf
0.25 modifier -> 0.5 modifier, as originally
* mass purrbation affects all species
* mass purrbation code cleanup
* remove mass purrbation gives mutant species their special ears and tails back
* mass purrbation syntax fix
* remove mass purrbation does not remove felinid from original felinids
* fuck you travis
