Files
Bubberstation/code/modules/deathmatch/deathmatch_mapping.dm
Bloop 183c5af2e4 Adds flag for virtual areas, fixes being able to send funds from virtualspace to real accounts (#94071)
## About The Pull Request

Fixes https://github.com/tgstation/tgstation/issues/90641
Fixes https://github.com/tgstation/tgstation/issues/88366

Eliminates worries over virtualspace currency being sent to real
accounts.

When I was looking into why there were no flags for bitrunning areas.
Then I saw this mess:

<img width="929" height="889" alt="Code_2we2QjDyFp"
src="https://github.com/user-attachments/assets/8a807bfe-b566-4057-a8ea-2b306325687d"
/>

Not having enough space / being too lazy to refactor this is a silly
reason to not include flags for something like these virtual areas where
it can be quite helpful. Fortunately I am not too lazy ~~in this
moment~~ so here we go:

It was fairly logical to move over some of these to a separate flag,
which I've called `area_flags_mapping` since they pertain to maploading
things and terrain generation mostly. `area_flags` stays reserved for
general properties and now has more room than it did before for you
people to fill it with.

In doing this it's also neatened up the code quit a bit, as UNIQUE_AREA
was kind of everywhere and now that it's implied by default less areas
need to have it defined (or explicitly un-defined).

<details> <summary> Working as intended </summary>

<img width="787" height="448" alt="dreamseeker_p0Qts36tG1"
src="https://github.com/user-attachments/assets/25056f34-8d43-4be2-a293-e53df7a7d1db"
/>

<img width="383" height="59" alt="dreamseeker_Ek7TXCcpbA"
src="https://github.com/user-attachments/assets/89622974-9467-4cdb-8345-d684f7c9004b"
/>

</details>

## Why It's Good For The Game

Fixes an exploit, improves the area flags situation slightly.

## Changelog

🆑
fix: you can no longer send money from virtualspace to a real account
code: adds a flag for virtual areas so they can easily be checked, as
well as an easy helper proc, 'is_area_virtual(your_area)'
/🆑
2025-11-22 12:24:41 -07:00

35 lines
1020 B
Plaintext

/area/deathmatch
name = "Deathmatch Arena"
requires_power = FALSE
default_gravity = STANDARD_GRAVITY
area_flags = LOCAL_TELEPORT | EVENT_PROTECTED | QUIET_LOGS | NO_DEATH_MESSAGE | BINARY_JAMMING
/area/deathmatch/fullbright
static_lighting = FALSE
base_lighting_alpha = 255
/obj/effect/landmark/deathmatch_player_spawn
name = "Deathmatch Player Spawner"
// for the illusion of a moving train
/turf/open/chasm/true/no_smooth/fake_motion_sand
name = "air"
desc = "Don't jump off, unless you want to fall a really long distance."
icon_state = "sandmoving"
base_icon_state = "sandmoving"
icon = 'icons/turf/floors.dmi'
/turf/open/chasm/true/no_smooth/fake_motion_sand/fast
icon_state = "sandmovingfast"
base_icon_state = "sandmovingfast"
// fakeout
/turf/open/chasm/true/fakeout
name = /turf/open/floor/wood::name
// desc kept the same
icon_state = /turf/open/floor/wood::icon_state
base_icon_state = /turf/open/floor/wood::base_icon_state
icon = /turf/open/floor/wood::icon
smoothing_flags = NONE