mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-09 15:15:34 +01:00
Ghom
0b0c5ea91e
## About The Pull Request Extends the part of the crafting unit test that ensures consistency between the total mats of the components of a recipe (or rather, the result of said recipe) and a generic instance of the same type as its result, previously only implemented on food recipes. ## Why It's Good For The Game This ensures a degree of consistency with the material composition of various objects in the game. I couldn't do it in the original PR as that one was too big already and it took months to get it merged, and have the relative bugs fixed. Currently a WIP as I slowly deal with the unit test reports. ## Changelog 🆑 refactor: Follow-up to the crafting/material refactor from months ago. All objects crafted with stacks now inherit their mat composition (not necessarily the effects and color) by default, while previously only a few things like chair, sinks and toilets did. Report any object looking or behaving weirdly as a result. fix: The material composition of ammo boxes is no longer a 1/10 of what it's supposed to be. It was a shitty hack to make it harder to recycle empty ammo boxes. Instead, they lose materials as they're emptied now. /🆑
12 lines
470 B
Plaintext
12 lines
470 B
Plaintext
/obj/item/ammo_box/magazine/internal
|
|
desc = "Oh god, this shouldn't be here"
|
|
abstract_type = /obj/item/ammo_box/magazine/internal
|
|
spawn_blacklisted = TRUE
|
|
obj_flags = CONDUCTS_ELECTRICITY
|
|
item_flags = ABSTRACT
|
|
custom_materials = null //we are never gonna be recycled anyway
|
|
|
|
//internals magazines are accessible, so replace spent ammo if full when trying to put a live one in
|
|
/obj/item/ammo_box/magazine/internal/give_round(obj/item/ammo_casing/R)
|
|
return ..(R,1)
|