mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-09 15:15:34 +01:00
QuiteLiterallyAnything
b7d5b2e343
## About The Pull Request Fixes #68995 Hello! This is my third-first SS13 PR. Accordingly, I thought I'd go for a simple bugfix. It turned out to be a slight bit more difficult than expected, but as a whole it's relatively short. Essentially, the discounts gained from toxins papers do not show up on research consoles. They still apply in code, but a zero-cost node will sometimes appear at its regular price in UI. After a substantial amount of confusion, I determined that this was due to the discount data simply not being passed to UIs at all. For both ease of handling the discounts and their passing as static data, I have refactored discounts from a singular nested list on techwebs (`boosted_nodes`) to a less complex list per tech node (`discount_boosts`). While coding, I have attempted to preserve the (presumably unused) capacity for discounts to vary by research point type. It does seem that discounts were only ever applied as general research points, but it should be easier if anyone ever intends to implement other point types. ## Why It's Good For The Game Visual bugs cause confusion, and this PR fixes one. It's also a bit odd that toxins discounts weren't passed to UIs in the first place. ## Changelog 🆑 fix: Made discounts from toxins papers show up in research UIs properly. refactor: Refactored research techwebs such that toxins discounts are now stored per techweb node rather than per techweb. /🆑