mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-22 04:30:44 +01:00
mrmanlikesbtandGitHub
b08ec39e1b
## About The Pull Request
### Don't run every single test
I've had this on my mind for several months and it being brought up
recently reminded me so here we are.
Unit tests only run on `runtimestation_minimal.dmm` now with the
exception of map tests. The following unit tests are declared as map
tests but I didn't see any map dependent logic so 🤷
- `/datum/unit_test/maptest_baseturfs_unmodified_scrape`
- `/datum/unit_test/maptest_baseturfs_placed_on_top`
- `/datum/unit_test/maptest_baseturfs_placed_on_bottom`
- `/datum/unit_test/maptest_get_turf_pixel`
- `/datum/unit_test/maptest_load_map_security`
- `/datum/unit_test/maptest_modular_map_loader`
- `/datum/unit_test/maptest_turf_icons`
`/datum/unit_test/subsystem_init` isn't really a mapping unit test but I
figured somehow, someway, maps might fuck with subsystem initializations
so I just decided to include it.
### Splits up the create & destroy test
Idk, pretty simple. Create & destroy is now split up across all
integration tests and ran in parallel.
## Why It's Good For The Game
oranges promised me "500 nzd" yo
## Changelog
No player facing changes
20 lines
686 B
Plaintext
20 lines
686 B
Plaintext
/datum/unit_test/cargo_dep_order_locations
|
|
test_flags = UNIT_TEST_MAP_TEST
|
|
|
|
/datum/unit_test/cargo_dep_order_locations/Run()
|
|
for(var/datum/job_department/department as anything in SSjob.joinable_departments)
|
|
var/delivery_areas = department.department_delivery_areas
|
|
if(!length(delivery_areas))
|
|
continue
|
|
if(check_valid_delivery_location(delivery_areas))
|
|
continue
|
|
TEST_FAIL("[department.type] failed to find a valid delivery location on this map.")
|
|
|
|
|
|
/datum/unit_test/cargo_dep_order_locations/proc/check_valid_delivery_location(list/delivery_areas)
|
|
for(var/delivery_area_type in delivery_areas)
|
|
|
|
if(GLOB.areas_by_type[delivery_area_type])
|
|
return TRUE
|
|
return FALSE
|