mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-09 15:15:34 +01:00
Joshua Kidder
7a3ad79506
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
73 lines
3.3 KiB
Plaintext
73 lines
3.3 KiB
Plaintext
// testing the mob expose procs are working
|
|
|
|
/datum/reagent/method_patch_test
|
|
name = "method patch test"
|
|
|
|
/datum/reagent/method_patch_test/expose_mob(mob/living/target, methods = PATCH, reac_volume, show_message = TRUE)
|
|
. = ..()
|
|
if(methods & PATCH)
|
|
target.set_brute_loss(20)
|
|
if(methods & INJECT)
|
|
target.set_brute_loss(10)
|
|
|
|
/datum/unit_test/reagent_mob_expose/Run()
|
|
// Life() is handled just by tests
|
|
SSmobs.pause()
|
|
|
|
var/mob/living/carbon/human/human = allocate(/mob/living/carbon/human/consistent)
|
|
var/obj/item/reagent_containers/dropper/dropper = allocate(/obj/item/reagent_containers/dropper)
|
|
var/obj/item/reagent_containers/cup/glass/bottle/drink = allocate(/obj/item/reagent_containers/cup/glass/bottle)
|
|
var/obj/item/reagent_containers/applicator/patch/patch = allocate(/obj/item/reagent_containers/applicator/patch)
|
|
var/obj/item/reagent_containers/syringe/syringe = allocate(/obj/item/reagent_containers/syringe)
|
|
|
|
// INGEST
|
|
TEST_ASSERT_EQUAL(human.fire_stacks, 0, "Human has fire stacks before taking phlogiston")
|
|
drink.reagents.add_reagent(/datum/reagent/phlogiston, 10)
|
|
drink.melee_attack_chain(human, human)
|
|
TEST_ASSERT_EQUAL(human.fire_stacks, 1, "Human does not have fire stacks after taking phlogiston")
|
|
human.Life(SSMOBS_DT)
|
|
TEST_ASSERT(human.fire_stacks > 1, "Human fire stacks did not increase after life tick")
|
|
|
|
// TOUCH
|
|
dropper.reagents.add_reagent(/datum/reagent/water, 5)
|
|
dropper.melee_attack_chain(human, human)
|
|
TEST_ASSERT(human.fire_stacks < 0, "Human still has fire stacks after touching water")
|
|
|
|
// VAPOR
|
|
human.fully_heal(ALL)
|
|
TEST_ASSERT_NULL(human.has_status_effect(/datum/status_effect/drowsiness), "Human is drowsy at the start of testing")
|
|
drink.reagents.add_reagent(/datum/reagent/nitrous_oxide, 10)
|
|
drink.reagents.trans_to(human, 10, methods = VAPOR)
|
|
TEST_ASSERT_NOTNULL(human.has_status_effect(/datum/status_effect/drowsiness), "Human is not drowsy after exposure to vapors")
|
|
drink.reagents.clear_reagents()
|
|
drink.reagents.add_reagent(/datum/reagent/water, 10)
|
|
var/old_fire_stacks = human.fire_stacks
|
|
drink.reagents.trans_to(human, 10, methods = VAPOR)
|
|
TEST_ASSERT(human.fire_stacks < old_fire_stacks, "Human does not get wetter after being exposed to water by vapors")
|
|
|
|
// PATCH
|
|
human.fully_heal(ALL)
|
|
TEST_ASSERT_EQUAL(human.get_brute_loss(), 0, "Human health did not set properly")
|
|
patch.reagents.add_reagent(/datum/reagent/method_patch_test, 1)
|
|
patch.self_delay = 0
|
|
patch.interact_with_atom(human, human)
|
|
patch.get_embed().process(SSdcs.wait / 10)
|
|
human.Life(SSMOBS_DT)
|
|
TEST_ASSERT_EQUAL(human.get_brute_loss(), 20, "Human health did not update after patch was applied")
|
|
|
|
// INJECT
|
|
syringe.reagents.add_reagent(/datum/reagent/method_patch_test, 1)
|
|
syringe.melee_attack_chain(human, human)
|
|
TEST_ASSERT_EQUAL(human.get_brute_loss(), 10, "Human health did not update after injection from syringe")
|
|
|
|
// INHALE
|
|
human.fully_heal(ALL)
|
|
TEST_ASSERT_NULL(human.has_status_effect(/datum/status_effect/hallucination), "Human is hallucinating at the start of testing")
|
|
drink.reagents.add_reagent(/datum/reagent/nitrous_oxide, 10)
|
|
drink.reagents.trans_to(human, 10, methods = INHALE)
|
|
TEST_ASSERT_NOTNULL(human.has_status_effect(/datum/status_effect/hallucination), "Human is not hallucinating after exposure to vapors")
|
|
|
|
/datum/unit_test/reagent_mob_expose/Destroy()
|
|
SSmobs.ignite()
|
|
return ..()
|