mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-09 23:27:56 +01:00
Joshua Kidder
7a3ad79506
## About The Pull Request It's just a partial cleanup of anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md) code from /tg/'s ancient history. I compiled & tested with my helpful assistant and damage is still working. <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3" /> I'll upload the .cs script I used to do it shortly. ## Why It's Good For The Game Just minor code cleanup. Script used is located at https://metek.tech/camelTo-Snake.7z EDIT 11/23/25: Updated the script to use multithreading and sequential scan so it works a hell of a lot faster ``` /* // Copyright 2025 Joshua 'Joan Metekillot' Kidder This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>. // */ using System.Text.RegularExpressions; class Program { static async Task Main(string[] args) { var readFile = new FileStreamOptions { Access = FileAccess.Read, Share = FileShare.ReadWrite, Options = FileOptions.Asynchronous | FileOptions.SequentialScan }; FileStreamOptions writeFile = new FileStreamOptions { Share = FileShare.ReadWrite, Access = FileAccess.ReadWrite, Mode = FileMode.Truncate, Options = FileOptions.Asynchronous }; RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled; Dictionary<string, int> changedProcs = new(); string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*"; Regex camelCaseProcRegex = new(regexPattern, regexOptions); string snakeify(Match matchingRegex) { var vals = matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray(); var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower(); string logString = $"{vals[0]} => {newVal}"; if (changedProcs.TryGetValue(logString, out int value)) { changedProcs[logString] = value + 1; } else { changedProcs.Add(logString, 1); } return newVal; } var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>(); // uses default ParallelOptions // https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) => { var reader = new StreamReader(filePath, readFile); string oldContent = await reader.ReadToEndAsync(); string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify)); if (oldContent != newContent) { var writer = new StreamWriter(filePath, writeFile); await writer.WriteAsync(newContent); await writer.DisposeAsync(); } reader.Dispose(); }); var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList(); foreach (var pair in logToList) { Console.WriteLine($"{pair.Key}: {pair.Value} locations"); } } } ``` ## Changelog 🆑 Bisar code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use snake_case, in-line with the STYLE guide. Underscores rule! /🆑
103 lines
3.1 KiB
Plaintext
103 lines
3.1 KiB
Plaintext
/// Tests to make sure tail wagging behaves as expected
|
|
/datum/unit_test/tail_wag
|
|
// used by the stop_after test
|
|
var/timer_finished = FALSE
|
|
|
|
/datum/unit_test/tail_wag/Run()
|
|
var/mob/living/carbon/human/dummy = allocate(/mob/living/carbon/human/consistent)
|
|
var/obj/item/organ/tail/cat/dummy_tail = allocate(/obj/item/organ/tail/cat)
|
|
dummy_tail.Insert(dummy, special = TRUE, movement_flags = DELETE_IF_REPLACED)
|
|
|
|
// SANITY TEST
|
|
|
|
// start wagging
|
|
dummy.wag_tail()
|
|
if(!(dummy_tail.wag_flags & WAG_WAGGING))
|
|
TEST_FAIL("Tail did not start wagging when it should have!")
|
|
|
|
// stop wagging
|
|
dummy.unwag_tail()
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("Tail did not stop wagging when it should have!")
|
|
|
|
// TESTING WAG EMOTE
|
|
|
|
// start wagging
|
|
dummy.emote("wag")
|
|
if(!(dummy_tail.wag_flags & WAG_WAGGING))
|
|
TEST_FAIL("Tail did not start wagging after using the *wag emote!")
|
|
|
|
// stop wagging
|
|
dummy.emote("wag")
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("Tail did not stop wagging after using the *wag emote!")
|
|
|
|
// TESTING WAG_ABLE FLAG
|
|
|
|
// flip the wag flag to unwaggable
|
|
dummy_tail.wag_flags &= ~WAG_ABLE
|
|
|
|
// try to wag it again
|
|
dummy.wag_tail()
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("Tail should not have the ability to wag, yet it did!")
|
|
|
|
// flip the wag flag to waggable again
|
|
dummy_tail.wag_flags |= WAG_ABLE
|
|
|
|
// start wagging again
|
|
dummy.wag_tail()
|
|
if(!(dummy_tail.wag_flags & WAG_WAGGING))
|
|
TEST_FAIL("Tail did not start wagging when it should have!")
|
|
|
|
// TESTING STOP_AFTER
|
|
|
|
// stop wagging
|
|
dummy.unwag_tail()
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("Tail did not stop wagging when it should have!")
|
|
|
|
// start wagging, stop after 0.1 seconds
|
|
dummy.wag_tail(0.1 SECONDS)
|
|
// because timers are a pain
|
|
addtimer(VARSET_CALLBACK(src, timer_finished, TRUE), 0.2 SECONDS)
|
|
if(!(dummy_tail.wag_flags & WAG_WAGGING))
|
|
TEST_FAIL("Tail did not start wagging when it should have!")
|
|
|
|
UNTIL(timer_finished) // wait a little bit
|
|
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("Tail was supposed to stop wagging on its own after 0.1 seconds but it did not!")
|
|
|
|
// TESTING TAIL REMOVAL
|
|
|
|
// remove the tail
|
|
dummy_tail.Remove(dummy, special = TRUE)
|
|
|
|
// check if tail is still wagging after being removed
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("Tail was still wagging after being removed!")
|
|
|
|
// try to wag the removed tail
|
|
dummy.wag_tail()
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("A disembodied tail was able to start wagging!")
|
|
|
|
// TESTING MOB DEATH
|
|
|
|
// put it back and start wagging again
|
|
dummy_tail.Insert(dummy, special = TRUE, movement_flags = DELETE_IF_REPLACED)
|
|
dummy.wag_tail()
|
|
if(!(dummy_tail.wag_flags & WAG_WAGGING))
|
|
TEST_FAIL("Tail did not start wagging when it should have!")
|
|
|
|
// kill the mob, see if it stops wagging
|
|
dummy.adjust_brute_loss(9001)
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("A mob's tail was still wagging after being killed!")
|
|
|
|
// check if we are still able to wag the tail after death
|
|
dummy.wag_tail()
|
|
if(dummy_tail.wag_flags & WAG_WAGGING)
|
|
TEST_FAIL("A dead mob was able to wag their tail!")
|