mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-30 08:37:43 +01:00
Phantastic-SwanandGitHub
32b1ec3a97
## About The Pull Request I was trying to fix the job display order CI for the upcoming upstream sync. I searched for the `/datum/job/prisoner` and found this <img width="395" height="291" alt="image" src="https://github.com/user-attachments/assets/b77518d2-b6cf-4360-a73b-daf9cbe31f65" /> > Holy jesus. What is that? WHAT. THE FUCK. IS THAT?! **WHAT IS THAT?!** As such, I have decided to go and find every override for `/datum/job` in `modular_zubbers` and `modular_skyrat` folders and organised them so that we don't have YES overrides for the same classes. ## Why It's Good For The Game I shall quote myself from my last PR > Do you understand how cancer inducing it is to try and figure out how code is executed when there are 3 separate overrides for a single proc? > I am of the opinion that any codebase should override any proc AT MOST once. Multiple overrides for a proc make for worse stack traces, less clarity in the order of code execution, and more difficulty in finding original declarations of procs. They also make it harder to keep procs up to date with upstreams if say, the arguments change (I know BYOND doesn't enforce proc overrides to have the same arguments as the original proc; however I consider that a load of bullshit and a major flaw in the language) ## Proof Of Testing This mainly moves code around rather than changes any of it. Regardless, it compiled and it seems that all procs that have been running previously are being hit now, so I assume it works. ## Changelog No player facing changes