Files
Leland KembleandGitHub b3c74dca2d Moves a plethora of things from attackby() to item_interaction() (#96726)
## About The Pull Request

50 files. Sorry about that, I was faster today. Just merge without
looking, it'll be fine.

This is the end of `/machinery/` & `/stack/` `attackby()`s(that aren't
actually meant for being attacked) when these are all merged.
Like, 200 left? I think? 

Also, this one will make light replacer reloading slightly more
difficult until whichever one converted the light replacer is merged.
If, for some ungodly reason, this one gets merged first.

Changes beyond conversion:

if a `/porta_turret_construct` somehow became anchored out of sync with
its construction steps, it's no longer softlocked
you can no longer place an infinite amount of blackboxes into the
blackbox recorder
a TTV will no longer keep its ghost on your back when you cut its wires
while wearing it
RCLs will properly update their appearance when initially given their
first coil
The creator of `robot_suit/attackby()` has been cursed to spend a
thousand years in the lake of fire

## Why It's Good For The Game

Now that all of these are remade, you can find bugs in them and then get
GBP for fixing them(not that my code would ever have bugs).

## Changelog
🆑

fix: It's no longer possible to softlock building a turret(if it ever
was)
fix: you can no longer stuff the blackbox recorder full with as many
blackboxes as you've somehow collected
fix: TTVs will no longer remain on your back as a ghost when you cut
their wire straps
fix: RCLs will now properly update their appearance when given their
first coil of cleaners
code: 50 files have been converted from attackby() to item_interaction()
/🆑
2026-07-02 06:10:46 +02:00

304 lines
11 KiB
Plaintext

/obj/item/suspiciousphone
name = "suspicious phone"
desc = "This device raises pink levels to unknown highs."
icon = 'icons/obj/antags/syndicate_tools.dmi'
icon_state = "suspiciousphone"
w_class = WEIGHT_CLASS_SMALL
attack_verb_continuous = list("dumps")
attack_verb_simple = list("dump")
/// Has the phone been used already?
var/dumped = FALSE
/obj/item/suspiciousphone/attack_self(mob/living/user)
if(!ISADVANCEDTOOLUSER(user))
to_chat(user, span_warning("This device is too advanced for you!"))
return
if(dumped)
to_chat(user, span_warning("You already activated Protocol CRAB-17."))
return FALSE
if(tgui_alert(user, "Are you sure you want to crash this market with no survivors?", "Protocol CRAB-17", list("Yes", "No")) == "Yes")
if(dumped || QDELETED(src)) //Prevents fuckers from cheesing alert
return FALSE
var/turf/targetturf = get_safe_random_station_turf_equal_weight()
if (!targetturf)
return FALSE
var/list/accounts_to_rob = assoc_to_values(SSeconomy.bank_accounts_by_id)
var/mob/living/L
if(isliving(user))
L = user
accounts_to_rob -= L.get_bank_account()
var/obj/effect/dumpeet_target/dump_machine = new /obj/effect/dumpeet_target(targetturf, L)
for(var/datum/bank_account/B as anything in accounts_to_rob)
B.dumpeet(dump_machine.dump)
to_chat(user, span_notice("You have activated Protocol CRAB-17."))
user.log_message("activated Protocol CRAB-17.", LOG_GAME)
dumped = TRUE
/obj/structure/checkoutmachine
name = "\improper Nanotrasen Space-Coin Market"
desc = "This is good for spacecoin because"
icon = 'icons/obj/machines/money_machine.dmi'
icon_state = "bogdanoff"
layer = ABOVE_ALL_MOB_LAYER
plane = ABOVE_GAME_PLANE
resistance_flags = INDESTRUCTIBLE | LAVA_PROOF | FIRE_PROOF | UNACIDABLE | ACID_PROOF
density = TRUE
pixel_z = -8
max_integrity = 5000
/// List of bank accounts to take money from, determines in start_dumping()
var/list/accounts_to_rob
/// The original user of the suspicious phone
var/mob/living/bogdanoff
/// Are we able to start moving?
var/canwalk = FALSE
/// Our own internal bank account, serves as a fallback to transfer money to if Bogdanoff doesn't have one
var/datum/bank_account/internal_account
/obj/structure/checkoutmachine/examine(mob/living/user)
. = ..()
. += span_info("It has a flashing <b>ID card reader</b> for convenient cashing out.")
/**
* Check whether any accounts in the accounts_to_rob list are still being drained.
* Returns TRUE if no accounts are being drained, FALSE otherwise
*/
/obj/structure/checkoutmachine/proc/check_if_finished()
for(var/datum/bank_account/B as anything in accounts_to_rob)
if(LAZYFIND(B.being_dumped, src))
return FALSE
return TRUE
/obj/structure/checkoutmachine/item_interaction(mob/living/user, obj/item/tool, list/modifiers)
if(!canwalk)
balloon_alert(user, "not ready to accept transactions!")
return ITEM_INTERACT_BLOCKING
if(check_if_finished())
qdel(src)
return ITEM_INTERACT_BLOCKING
var/obj/item/card/id/card = tool.GetID()
if(!card)
balloon_alert(user, "the reader repels your [tool.name]")
var/throwtarget = get_step(user, get_dir(src, user))
user.safe_throw_at(throwtarget, 1, 1, force = MOVE_FORCE_EXTREMELY_STRONG)
playsound(get_turf(src),'sound/effects/magic/repulse.ogg', 100, TRUE)
return ITEM_INTERACT_BLOCKING
if(!card.registered_account)
balloon_alert(user, "card has no registered account!")
return ITEM_INTERACT_BLOCKING
if(!LAZYFIND(card.registered_account.being_dumped, src))
balloon_alert(user, "funds are already safe!")
return ITEM_INTERACT_BLOCKING
to_chat(user, span_warning("You quickly cash out your funds to a more secure banking location. Funds are safu.")) // This is a reference and not a typo
accounts_to_rob -= card.registered_account
card.registered_account.stop_dump(src)
if(check_if_finished())
qdel(src)
return ITEM_INTERACT_SUCCESS
/obj/structure/checkoutmachine/Initialize(mapload, mob/living/user)
. = ..()
if(QDELETED(src))
return
bogdanoff = user
internal_account = new /datum/bank_account/remote("CRAB-17", 0, player_account = FALSE)
/obj/structure/checkoutmachine/proc/setup_siphoning()
add_overlay("flaps")
add_overlay("hatch")
add_overlay("legs_retracted")
addtimer(CALLBACK(src, PROC_REF(startUp)), 5 SECONDS)
QDEL_IN(src, 8 MINUTES) //Self-destruct after 8 min
ADD_TRAIT(SSeconomy, TRAIT_MARKET_CRASHING, REF(src))
/**
* Starts the dumping process and plays a start-up animation before the checkout starts walking.
*/
/obj/structure/checkoutmachine/proc/startUp() //very VERY snowflake code that adds a neat animation when the pod lands.
start_dumping() //The machine doesnt move during this time, giving people close by a small window to grab their funds before it starts running around
sleep(1 SECONDS)
if(QDELETED(src))
return
playsound(src, 'sound/machines/click.ogg', 15, TRUE, -3)
cut_overlay("flaps")
sleep(1 SECONDS)
if(QDELETED(src))
return
playsound(src, 'sound/machines/click.ogg', 15, TRUE, -3)
cut_overlay("hatch")
sleep(3 SECONDS)
if(QDELETED(src))
return
playsound(src,'sound/machines/beep/twobeep.ogg',50,FALSE)
var/mutable_appearance/hologram = mutable_appearance(icon, "hologram")
hologram.pixel_z = 16
add_overlay(hologram)
var/mutable_appearance/holosign = mutable_appearance(icon, "holosign")
holosign.pixel_z = 16
add_overlay(holosign)
add_overlay("legs_extending")
cut_overlay("legs_retracted")
pixel_z += 4
sleep(0.5 SECONDS)
if(QDELETED(src))
return
add_overlay("legs_extended")
cut_overlay("legs_extending")
pixel_z += 4
sleep(2 SECONDS)
if(QDELETED(src))
return
add_overlay("screen_lines")
sleep(0.5 SECONDS)
if(QDELETED(src))
return
cut_overlay("screen_lines")
sleep(0.5 SECONDS)
if(QDELETED(src))
return
add_overlay("screen_lines")
add_overlay("screen")
sleep(0.5 SECONDS)
if(QDELETED(src))
return
playsound(src,'sound/machines/beep/triple_beep.ogg',50,FALSE)
add_overlay("text")
sleep(1 SECONDS)
if(QDELETED(src))
return
add_overlay("legs")
cut_overlay("legs_extended")
cut_overlay("screen")
add_overlay("screen")
cut_overlay("screen_lines")
add_overlay("screen_lines")
cut_overlay("text")
add_overlay("text")
START_PROCESSING(SSfastprocess, src)
canwalk = TRUE
/obj/structure/checkoutmachine/Destroy()
stop_dumping()
STOP_PROCESSING(SSfastprocess, src)
priority_announce("The credit deposit machine at [get_area(src)] has been destroyed. Station funds have stopped draining!", sender_override = "CRAB-17 Protocol")
if(internal_account.account_balance)
expel_cash()
QDEL_NULL(internal_account)
explosion(src, light_impact_range = 1, flame_range = 2)
REMOVE_TRAIT(SSeconomy, TRAIT_MARKET_CRASHING, REF(src))
return ..()
/**
* Grabs the accounts to be robbed and puts them in accounts_to_rob, tells the accounts they're being drained and calls dump() to start draining.
*/
/obj/structure/checkoutmachine/proc/start_dumping()
accounts_to_rob = assoc_to_values(SSeconomy.bank_accounts_by_id)
accounts_to_rob -= bogdanoff?.get_bank_account()
dump()
/**
* For each account being drained, pulls a random percentage of cash out the account and sends it to Bogdanoff's account.
* If Bogdanoff did not have a bank account, stores the funds in the checkout's internal_account.
* Sets a timer to call itself again after an interval.
*/
/obj/structure/checkoutmachine/proc/dump()
var/percentage_lost = (rand(5, 15) / 100)
for(var/datum/bank_account/B as anything in accounts_to_rob)
if(!(B?.being_dumped))
accounts_to_rob -= B
continue
var/amount = round(B.account_balance * percentage_lost) // We don't want fractions of a credit stolen. That's just agony for everyone.
var/datum/bank_account/account = bogdanoff?.get_bank_account() || internal_account
account.transfer_money(B, amount, "?VIVA¿: !LA CRABBE¡")
B.money_crabbed += amount
B.bank_card_talk("You have lost [percentage_lost * 100]% of your funds! A spacecoin credit deposit machine is located at: [get_area(src)].")
addtimer(CALLBACK(src, PROC_REF(dump)), 15 SECONDS) //Drain every 15 seconds
/obj/structure/checkoutmachine/process()
var/anydir = pick(GLOB.cardinals)
if(Process_Spacemove(anydir))
Move(get_step(src, anydir), anydir)
/**
* Goes through accounts_to_rob and tells every account that the drain has stopped.
*/
/obj/structure/checkoutmachine/proc/stop_dumping()
for(var/datum/bank_account/B as anything in accounts_to_rob)
B.stop_dump(src)
/**
* Splits the balance of the internal_account into several smaller piles of cash and scatters them around the area.
*/
/obj/structure/checkoutmachine/proc/expel_cash()
var/funds_remaining = internal_account.account_balance
var/safety = funds_remaining + 1 // In the absolute worst case scenario the loop will complete in funds_remaining steps, if this is counter reaches 0 something went terribly wrong and we need to leave
while(floor(funds_remaining))
var/amount_to_remove = min(funds_remaining, rand(1, round(internal_account.account_balance)/8))
var/obj/item/holochip/holochip = new (get_turf(src), amount_to_remove)
funds_remaining -= amount_to_remove
holochip.throw_at(pick(oview(7,get_turf(src))),10,1)
safety -= 1
if(safety <= 0)
CRASH("/obj/structure/checkoutmachine/proc/expel_cash() did not complete in the theoretical maximum number of steps. Starting value: [internal_account.account_balance]. Value at crash: [funds_remaining].")
/obj/effect/dumpeet_fall //Falling pod
name = ""
icon = 'icons/obj/machines/money_machine_64.dmi'
pixel_z = 300
desc = "Get out of the way!"
layer = FLY_LAYER//that wasn't flying, that was falling with style!
plane = ABOVE_GAME_PLANE
icon_state = "missile_blur"
/obj/effect/dumpeet_target
name = "Landing Zone Indicator"
desc = "A holographic projection designating the landing zone of something. It's probably best to stand back."
icon = 'icons/mob/telegraphing/telegraph_holographic.dmi'
icon_state = "target_circle"
layer = PROJECTILE_HIT_THRESHHOLD_LAYER
light_range = 2
var/obj/effect/dumpeet_fall/DF
var/obj/structure/checkoutmachine/dump
var/mob/living/bogdanoff
/obj/effect/dumpeet_target/Initialize(mapload, user)
. = ..()
bogdanoff = user
dump = new /obj/structure/checkoutmachine(null, bogdanoff)
addtimer(CALLBACK(src, PROC_REF(startLaunch)), 10 SECONDS)
sound_to_playing_players('sound/items/dump_it.ogg', 20)
deadchat_broadcast("Protocol CRAB-17 has been activated. A space-coin market has been launched at the station!", turf_target = get_turf(src), message_type=DEADCHAT_ANNOUNCEMENT)
/**
* Sets up the falling animation for the checkout machine.
*/
/obj/effect/dumpeet_target/proc/startLaunch()
DF = new /obj/effect/dumpeet_fall(drop_location())
dump.setup_siphoning()
priority_announce("The spacecoin bubble has popped! Get to the credit deposit machine at [get_area(src)] and cash out before you lose all of your funds!", sender_override = "CRAB-17 Protocol")
animate(DF, pixel_z = -8, time = 5, , easing = LINEAR_EASING)
playsound(src, 'sound/items/weapons/mortar_whistle.ogg', 70, TRUE, 6)
addtimer(CALLBACK(src, PROC_REF(end_launch)), 5, TIMER_CLIENT_TIME) //Go onto the last step after a very short falling animation
/**
* Cleans up after the falling animation.
*/
/obj/effect/dumpeet_target/proc/end_launch()
QDEL_NULL(DF) //Delete the falling machine effect, because at this point its animation is over. We dont use temp_visual because we want to manually delete it as soon as the pod appears
playsound(src, SFX_EXPLOSION, 80, TRUE)
dump.forceMove(get_turf(src))
qdel(src) //The target's purpose is complete. It can rest easy now