mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-26 17:11:52 +00:00
2dd346fb92
* Bedsheet bin interaction improvements (#84510) ## About The Pull Request This pr just replaces the bedsheet bin `attackby(...)` with `item_interaction(...)`, adds usage screentips to bedsheet bins, adds more balloon alert feedback to failing to hide items in bedsheet bins, and added `silent = FALSE` to the `user.transferItemToLoc(tool, src)` calls' parameters such that putting items in isn't silent. Main thing to note is that we skip hiding items when in combat mode, such that you do not try to hide the item you are currently trying to beat up the bin with. Tiny second thing to note is that we explicitly `return .` in `add_context(...)` due to adjusting the value of `.`. ## Why It's Good For The Game Better to update `attackby(...)` to `item_interaction(...)`. I think item interactions being internally consistent is more intuitive; left click always being hiding feels nicer than left click being hiding _except_ for tools where it's right click. Then, I think hiding should be left click as "putting something in" is the primary item interaction we're expecting, parallel to tables or storage or racks or somesuch. Nice to have screentips. Nice to have more failure feedback. Nice when things aren't silent. ## Changelog 🆑 code: Moved bedsheet bin interactions to the item interaction code. Please report any issues. qol: Made bedsheet bin tool interactions right click, such that left click is consistently for putting in items. qol: Added usage screentips to bedsheet bins. qol: Added more feedback to failing to hide items in bedsheet bins. sound: Made putting items in bedsheet bins not silent (If the items have associated pickup/drop sounds). /🆑 * Bedsheet bin interaction improvements --------- Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>