SkyratBot 669df15b97 [MIRROR] Refactors mothweek check [MDB IGNORE] (#14846) ...

* Refactors mothweek check (#68280)

* Refactors mothweek check

Mothweek HAS SIDE EFFECTS
Checking it on a day that causes a week offset will currently cause that
week offset to persist
That's dumb.

Also it's not very expansive, only covers a slim set of possibilities.

Instead, lets build something to generate all passing days over a period
of time, maybe 3 months out of 2 years.
Then we'll crosscheck that against some predecided "ok" dates

If either list disagrees with each other, we'll fail. That way we can't
miss an edgecase. or have issues with side effects

I like this pattern.

* Refactors mothweek check

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>

2022-07-11 03:24:14 +01:00

4.6 KiB

Raw Blame History

View Raw