MrMelbert 5a67aa0411 Fixes ore vent descriptions stacking, fixes potential exploits with ore vent scanning (#81174) ...

## About The Pull Request

- Scanning ore vents did a do_after to do the actual scan, but if the
do_after failed, it didn't cancel the scan proc, and rewarded you points
anyways. So you could just keep cancelling the scan for free points?

- Also there was nothing preventing someone from stacking scans on the
same vent

- Also, when generating the ore description, always override existing
descriptions. Given `generate_description` can be called multiple times,
prevents it from stacking on itself.

## Changelog

🆑 Melbert
fix: Fixed ore vent descriptions looking weird sometimes
fix: Fixed being able to scan an ore vent multiple times at once
fix: Fixed gaining scan points from scannning an ore vent without
finishing the scan
/🆑

2024-01-30 11:38:55 -05:00

..

beds_chairs

Replaces /obj:: -> parent_type:: (#81146)

2024-01-29 11:37:04 -05:00

cannons

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

construction_console

The construction console drone becomes visible again while its in use (#81153)

2024-01-29 18:46:10 +01:00

crates_lockers

Disarm refactor, plus shoving people with shields (#80123)

2024-01-16 19:35:56 -06:00

gym

Fitness rebalance and improvements - mood, fireman carry, and longer workouts (#79584)

2023-12-14 02:21:27 +00:00

icemoon

Refactor icemoon wolves into basic mobs and add taming + pack behavior (#79736)

2023-11-19 10:51:21 -08:00

lavaland

Fixes ore vent descriptions stacking, fixes potential exploits with ore vent scanning (#81174)

2024-01-30 11:38:55 -05:00

plaques

Tram v6/Transport Subsystem (#78230)

2023-10-17 10:52:38 -07:00

signs

Adds a new component so that items that are "attached" to walls will now drop/deconstruct on turf destruction. (#77417)

2023-09-16 00:17:38 +00:00

transit_tubes

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

ai_core.dm

Roundstart AIs are positronic (#80355)

2023-12-17 10:47:52 +01:00

aliens.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

bedsheet_bin.dm

Fixes every instance of 'kenetic' in the codebase (#80782)

2024-01-05 17:55:09 +00:00

billboard.dm

Icon folder cleaning wave one (#76703)

2023-07-11 10:50:10 -07:00

bonfire.dm

It is now possible to survive the Mansus (#79131)

2023-10-21 13:34:57 -04:00

broken_flooring.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

cat_house.dm

basic cats and mini kitchen helpers (#79800)

2023-11-28 21:51:37 -07:00

chess.dm

Icons folder cleaning wave two (#76788)

2023-07-14 18:36:41 +00:00

containers.dm

adds crushed can, jelly doughnut, and shipping container random spawners (#78444)

2023-09-23 20:20:49 +02:00

deployable_turret.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

destructible_structures.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

displaycase.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

divine.dm

Refactor gib code to use bitflags and have documentation (#78754)

2023-10-06 13:12:22 +01:00

door_assembly_types.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

door_assembly.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

dresser.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

electricchair.dm

…

extinguisher.dm

Fixes extinguisher cabinet not updating its icon (#80668)

2023-12-31 20:41:22 +01:00

fake_stairs.dm

Adds cliffs to icebox (#77062)

2023-07-28 14:13:43 +00:00

false_walls.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

fans.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

fence.dm

…

fireaxe.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

fireplace.dm

[NO GBP] Fix fireplace smoke particles to work properly with all directions (#79417)

2023-11-02 13:39:08 +00:00

flora.dm

Replaces /obj:: -> parent_type:: (#81146)

2024-01-29 11:37:04 -05:00

fluff.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

girders.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

grille.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

guillotine.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

guncase.dm

New closets (#79774)

2023-11-21 04:51:38 +00:00

headpike.dm

Makes heads on pikes render correctly. (#79863)

2023-11-21 14:50:45 +01:00

hivebot.dm

make the hive bot a basic bot (#77274)

2023-08-08 11:42:37 +01:00

holosign.dm

Atmos Holofan Clearview (#80662)

2023-12-31 13:26:04 -05:00

janitor.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

kitchen_spike.dm

Adds UPSIDE_DOWN movetype for negative gravity / makes Atrocinator affected by less things (#79785)

2023-11-20 21:19:13 +00:00

ladders.dm

Removes the attack_slime proc, and other slime refactors (#80487)

2024-01-02 18:37:20 +00:00

lattice.dm

Makes placing plating on lava-proof rods delete the rods and not break lighting on that tile for the rest of the round (#80876)

2024-01-12 02:45:53 +01:00

life_candle.dm

…

loom.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

maintenance.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

mannequin.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

memorial.dm

Icon folder cleaning wave one (#76703)

2023-07-11 10:50:10 -07:00

mineral_doors.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

mirror.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

morgue.dm

Reworks morgue trays. Freezers and morgue trays now have their own internal air. Organs no longer take damage when below freezing temperatures. (#80219)

2023-12-12 22:17:03 +01:00

mystery_box.dm

Splits ballistic firearms "mag_type" into "accepted_magazine_type" and "spawn_magazine_type", fixing a few funny magazine bugs (#76973)

2023-07-25 14:42:40 -06:00

noticeboard.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

ore_containers.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

petrified_statue.dm

fix a hard delete in basic statues (#80696)

2024-01-01 21:03:26 +01:00

pinatas.dm

…

plasticflaps.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

railings.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

reflector.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

safe.dm

Adds pathmaps, refactors pathfinding a bit (#78684)

2023-10-17 23:52:54 -06:00

secure_safe.dm

TGUI for Safes and Secure briefcases (Safes are now a structure, too) (#79594)

2023-11-16 18:00:43 -08:00

showcase.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

shower.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

spawner.dm

ArcMining Pr Beta: Version 1.2 (#78524)

2024-01-21 11:32:05 -05:00

spirit_board.dm

Converts some notify_ghosts args to bitflags, multilines all notify_ghosts calls (#79320)

2023-11-05 15:26:50 -08:00

stairs.dm

Adds pathmaps, refactors pathfinding a bit (#78684)

2023-10-17 23:52:54 -06:00

syndicate_uplink_beacon.dm

Replaceable Traitor Uplinks (#74315)

2023-04-05 16:54:22 +01:00

table_frames.dm

Minerals have been refactored so costs and minerals in items are now in terms of mineral defines. (#75052)

2023-05-03 14:44:51 +00:00

tables_racks.dm

Disarm refactor, plus shoving people with shields (#80123)

2024-01-16 19:35:56 -06:00

tank_dispenser.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

tank_holder.dm

Dunking handle_atom_del() in the trash bin. (#77339)

2023-08-18 11:02:22 +00:00

toiletbong.dm

Converts vomit() to use bitflags (#78191)

2023-09-11 21:39:16 +00:00

training_machine.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

traps.dm

Basic Constructs: Proteon (#79425)

2023-11-01 17:07:20 -06:00

votingbox.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

watercloset.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

windoor_assembly.dm

Fixes some construction bugs with airlocks & windoors (#78261)

2023-09-16 19:34:43 -07:00

window.dm

Replaces /obj:: -> parent_type:: (#81146)

2024-01-29 11:37:04 -05:00