mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-12 01:43:40 +00:00
c9b3d9ab67
* Fixes some minor problems with grav gen * Fixes gravity generator completely obliterating your ears by having several gravity generator soundloops (now there's only 1) by starting soundloop on creation, during parent's Initialize (so it doubled since things like grav gen part (a generator inside the generator??), starts a soundloop too, now the station's gen just starts the loop if it spawns on) * Fixes offstation gravity generator looking like it's turned on when it isn't, and fixes it having sound when it's off. * Removes /station grav gen subtype, because it was frankly useless. * Adds some early returns to gravity generator's process, and removes the unused set_state proc, which was replaced with enable() and disable() in the radiation rework. * Lastly, removes grav gen parts from QDEL_NULL'ing their soundloop twice, since they called parent's Destroy() that did it for them anyways. * fixes minor typo Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> * more grav gen code improvement This commit is solely focused on code improvement. * gravity_field and sound_loop was moved from gravity generator to main gravity generator, since they're the only place it was used. * Added checks for a main part across generator part procs, rather than using ? randomly. * Autodocs all Gravity generator vars * Adds better var names in for() loops, makes use of as_anything, and renames parts to generator_parts. * Adds some better var names in general. * Adds an UpdatePaths * fixes infinite del loop * fix to harddels * Update gravitygenerator.dm * merge conflict moment * fix maps * fixes merge conflict * Update gravitygenerator.dm * updates the updatepath * Update gravitygenerator.dm * Update gravitygenerator.dm * merge conflict * set_broken() * Update gravitygenerator.dm * unregister signal on destroy * Update gravitygenerator.dm * middle part * Update gravitygenerator.dm * more improvement + moves grav code to grav file * Update gravitygenerator.dm * handles map merge conflicts Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>