* Fixes some minor problems with grav gen * Fixes gravity generator completely obliterating your ears by having several gravity generator soundloops (now there's only 1) by starting soundloop on creation, during parent's Initialize (so it doubled since things like grav gen part (a generator inside the generator??), starts a soundloop too, now the station's gen just starts the loop if it spawns on) * Fixes offstation gravity generator looking like it's turned on when it isn't, and fixes it having sound when it's off. * Removes /station grav gen subtype, because it was frankly useless. * Adds some early returns to gravity generator's process, and removes the unused set_state proc, which was replaced with enable() and disable() in the radiation rework. * Lastly, removes grav gen parts from QDEL_NULL'ing their soundloop twice, since they called parent's Destroy() that did it for them anyways. * fixes minor typo Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> * more grav gen code improvement This commit is solely focused on code improvement. * gravity_field and sound_loop was moved from gravity generator to main gravity generator, since they're the only place it was used. * Added checks for a main part across generator part procs, rather than using ? randomly. * Autodocs all Gravity generator vars * Adds better var names in for() loops, makes use of as_anything, and renames parts to generator_parts. * Adds some better var names in general. * Adds an UpdatePaths * fixes infinite del loop * fix to harddels * Update gravitygenerator.dm * merge conflict moment * fix maps * fixes merge conflict * Update gravitygenerator.dm * updates the updatepath * Update gravitygenerator.dm * Update gravitygenerator.dm * merge conflict * set_broken() * Update gravitygenerator.dm * unregister signal on destroy * Update gravitygenerator.dm * middle part * Update gravitygenerator.dm * more improvement + moves grav code to grav file * Update gravitygenerator.dm * handles map merge conflicts Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
HOW TO USE: Drag one of the scripts in the “Scripts” folder onto the .bat file “Update Paths” to open it with the .bat file. Let the script run.
Use this tool before using mapmerge or opening the map in an editor.
IMPORTANT: Please tie the script you are making to the associated PR on github and put it in the scripts folder when you are done.
For example: 67107_Turf_Updates_2
HOW TO MAKE A SCRIPT: This tool updates paths in the game to new paths. For instance: If you have a path labeled
/obj/structure/door/airlock/science/closed/rd
and wanted it to be
/obj/structure/door/airlock/science/rd/closed
This tool would update it for you! This is extremely helpful if you want to be nice to people who have to resolve merge conflicts from the PRs that you make updating these areas.
How do you do it? Simply open a notepad and type this on a line:
/obj/structure/door/airlock/science/closed/rd : /obj/structure/door/airlock/science/rd/closed
The path on the left is the old, the path on the right is the new. It is seperated by a ":" If you want to make multiple path changes in one script, simply add more changes on new lines.
If you get lost, look at other scripts for examples.