mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-28 02:21:53 +00:00
e7230e8b4a
* Resolves is_banned_from headaches and lag (Speeds up roundstart significantly) (#69376) About The Pull Request Just to be clear, when I refer to time here, I am not talking about cpu time. I'm talking about real time. This doesn't significantly reduce the amount of work we do, it just removes a lot of the waiting around we need to do for db calls to finish. Adds queuing support to sql bans, so if an ongoing ban retrieval query is active any successive ban retrieval attempts will wait for the active query to finish This uses the number/blocking_query_timeout config option, I hope it's still valid This system will allow us to precache ban info, in parallel (or in batches) With this, we can avoid needing to setup all uses of is_banned_from to support parallelization or eat the cost of in-series database requests Clients who join after initialize will now build a ban cache automatically Those who join before init is done will be gathered by a batch query sent by a new subsystem, SSban_cache. This means that any post initalize uses of is_banned_from are worst case by NATURE parallel (since the request is already sent, and we're just waiting for the response) This saves a lot of headache for implementers (users) of the proc, and saves ~0.9 second from roundstart setup for each client (on /tg/station) There's a lot of in series is_banned_from calls in there, and this nukes them. This should bring down roundstart join times significantly. It's hard to say exactly how much, since some cases generate the ban cache at other times. At base tho, we save about 0.9 seconds of real time per client off doing this stuff in parallel. Why It's Good For The Game When I use percentages I'm speaking about cost per player I don't like how slow roundstart feels, this kills about 66% of that. the rest is a lot of misc things. About 11% (it's actually 16%) is general mob placing which is hard to optimize. 22% is manifest generation, most of which is GetFlatIcons which REALLY do not need to be holding up the main thread of execution. An additional 1 second is constant cost from a db query we make to tell the server we exist, which can be made async to avoid holding the proc chain. That's it. I'm bullying someone into working on the manifest issue, so that should just leave 16% of mob placing, which is really not that bad compared to what we have now. Changelog cl code: The time between the round starting and the game like, actually starting has been reduced by 66% refactor: I've slightly changed how ban caches are generated, admins please let me know if anything goes fuckey server: I'm using the blocking_query_timeout config. Make sure it's up to date and all. /cl * Resolves is_banned_from headaches and lag (Speeds up roundstart significantly) Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
50 KiB
50 KiB