Rhials 94f5221af4 Fixes the energy cake slice's on-eat effect triggering before it is eaten (#81382) ...

## About The Pull Request

This makes the energy cake deal its damage/effects AFTER being fed,
instead of before.

It also adds combat logging to force-fed energy cakes, just in case.

Also, this adds a balloon alert to the pacifist check. Cool!
## Why It's Good For The Game

Fixes a wacky combat bug, and adds some minor adjustments made along the
way.

Closes #81351.
## Changelog
🆑 Rhials
fix: The Energy Cake slice now does its on-eat effect AFTER being eaten,
instead of before.
/🆑

2024-02-11 00:03:14 +00:00

..

AI_modules

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

circuitboards

General maintenance for Lathes (#81244)

2024-02-08 13:34:03 +01:00

devices

Health analyzer displays blood alcohol content (#81306)

2024-02-08 22:40:43 -07:00

food

Fixes the energy cake slice's on-eat effect triggering before it is eaten (#81382)

2024-02-11 00:03:14 +00:00

granters

The "Guide to Advanced Mimery" series now make but the faintest noise when turning their pages (#81068)

2024-02-03 01:14:18 +01:00

grenades

[NO GBP] C4 notification jump works again (#80810)

2024-01-07 01:00:13 -06:00

implants

Freedom implant and Biodegrade works on knotted shoes (#81376)

2024-02-11 00:36:53 +01:00

kirby_plants

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

melee

Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) (#81120)

2024-02-05 11:42:03 -08:00

rcd

You can now move and talk through statues and mannequins (#81188)

2024-02-08 14:19:31 +01:00

robot

cyborg inducer respects cell changes (#81002)

2024-01-20 15:07:56 +01:00

stacks

Adds a signal to buying items from the uplink (& fixes TC misinfo) (#81372)

2024-02-10 18:57:19 +01:00

storage

Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) (#81120)

2024-02-05 11:42:03 -08:00

tanks

Kills off /obj/item/onetankbomb, assembly bombs now handled by the tank itself (#81218)

2024-02-03 03:24:39 -05:00

tcg

Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) (#81120)

2024-02-05 11:42:03 -08:00

tools

Fixes open-air mechs (Ripley, Paddy) not pushing projectile damage to the pilot (#80844)

2024-01-09 14:09:22 -05:00

airlock_painter.dm

Make spritesheets cacheable by default, killing a lot of overtime in the round start spike (#80522)

2023-12-24 15:46:00 +01:00

apc_frame.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

bear_armor.dm

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

binoculars.dm

Changes the scope component to be appliable to other items and not just guns. Binocs and the Curator's mothic cap use it. (#80445)

2024-01-02 17:36:49 +00:00

blueprints.dm

split area.contained_turfs up by zlevel, make init 10 seconds faster (#80941)

2024-01-18 12:16:12 -05:00

body_egg.dm

Organ movement refactor *Un-nullspaces your organs* (#79687)

2023-12-09 17:50:46 +00:00

bodybag.dm

…

botpad_remote.dm

Bot launchpads also accept basic/bot (#80627)

2023-12-30 00:44:00 +01:00

boxcutter.dm

Adds a Syndicate Monkey Agent beacon uplink item (#79012)

2023-10-24 15:28:36 +00:00

broom.dm

…

cardboard_cutouts.dm

Scopes NODECONSTRUCT_1 from flags_1 to obj_flags (#80104)

2023-12-08 08:49:14 +00:00

cards_ids.dm

Fixes ID card bank account examine/dialog (#81156)

2024-01-30 18:55:26 +01:00

chainsaw.dm

Replace natural beheading with cranial fissures (splitting your skull) (#80703)

2024-01-06 13:09:53 +01:00

charter.dm

Export scanner no longer shows shipping manifest value + manifest error changes (#78923)

2023-10-21 03:48:54 +02:00

choice_beacon.dm

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

chromosome.dm

…

cigs_lighters.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

climbingrope.dm

[no gbp] fixes being unable to climb up onto unblocked spaces with a climbing hook (#79744)

2023-11-18 04:31:00 +01:00

clown_items.dm

basic cleanbots refactor and new janitor skillchip (#80128)

2023-12-08 16:26:10 -07:00

control_wand.dm

Adds logging to door remote bolting (#80723)

2024-01-05 01:55:42 +01:00

cosmetics.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

courtroom.dm

…

crab17.dm

CRAB-17 will round down the credit amount it steals (#79761)

2023-11-16 14:37:58 -08:00

crayons.dm

Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) (#81120)

2024-02-05 11:42:03 -08:00

credit_holochip.dm

…

debug_items.dm

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

defib.dm

Rename notify_ghost_cloning to notify_revival (#80096)

2023-12-05 02:24:18 -05:00

dehy_carp.dm

…

dice.dm

Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) (#81120)

2024-02-05 11:42:03 -08:00

dna_injector.dm

Makes mutations clean up after themselves (#80107)

2023-12-06 19:59:32 -07:00

dna_probe.dm

Basic Space Dragon (#78979)

2023-10-14 15:53:28 -07:00

door_seal.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

drug_items.dm

…

dualsaber.dm

Some Processing improvements (#80693)

2024-01-01 20:58:34 +01:00

dyespray.dm

…

eightball.dm

More standardization for ghost notifications (READY) (#79596)

2023-11-19 05:13:25 +01:00

emags.dm

Attack chain refactoring: Broadening tool_act into item_interact, moving some item interactions to... atom/item_interact / item/interact_with_atom (#79968)

2023-12-08 23:50:19 -07:00

etherealdiscoball.dm

Fix set_light colour parameters for ethereal disco ball (#81326)

2024-02-08 00:51:50 +01:00

extinguisher.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

fireaxe.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

flamethrower.dm

Some Processing improvements (#80693)

2024-01-01 20:58:34 +01:00

frog_statue.dm

Implements rgb2num, uses it to replace all our manual rgb reading. Redoes HSV management (#81182)

2024-02-01 13:43:50 +01:00

gift.dm

Patches Up Gifts In Anticipation Of The Holidays (#80035)

2023-12-01 23:11:35 -05:00

gun_maintenance.dm

…

hand_items.dm

Removes timeout_mod arg from add_mood_effect (#80964)

2024-01-16 20:57:42 +01:00

handcuffs.dm

Gloves changes featuring nerfed shove cuffing (#81187)

2024-02-01 14:16:31 +01:00

his_grace.dm

More standardization for ghost notifications (READY) (#79596)

2023-11-19 05:13:25 +01:00

holosign_creator.dm

Atmos Holofan Clearview (#80662)

2023-12-31 13:26:04 -05:00

hot_potato.dm

More standardization for ghost notifications (READY) (#79596)

2023-11-19 05:13:25 +01:00

hourglass.dm

…

inducer.dm

cyborg inducer respects cell changes (#81002)

2024-01-20 15:07:56 +01:00

inspector.dm

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

janitor_key.dm

…

kitchen.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

knives.dm

Shivs and bone daggers are no longer electrically conductive (#81145)

2024-01-29 11:38:05 -05:00

latexballoon.dm

…

mail.dm

A "postal workers strike" negative station trait. (can be positive) (#80213)

2023-12-27 16:10:32 -05:00

maintenance_loot.dm

Typo correction in maintenance_loot.dm (#79613)

2023-11-10 23:56:34 -08:00

manuals.dm

Fixes Wiki Book Manuals not working (#79589)

2023-11-09 18:37:15 +13:00

mop.dm

basic cleanbots refactor and new janitor skillchip (#80128)

2023-12-08 16:26:10 -07:00

nitrium_crystals.dm

…

paint.dm

Paint cans actually hold an appreciable amount of paint (#79791)

2023-11-18 13:08:38 +01:00

paiwire.dm

…

pet_carrier.dm

…

pillow.dm

pillow altclick sanity (#81265)

2024-02-05 12:13:32 -05:00

pinpointer.dm

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

pitchfork.dm

…

plushes.dm

Implements rgb2num, uses it to replace all our manual rgb reading. Redoes HSV management (#81182)

2024-02-01 13:43:50 +01:00

pneumaticCannon.dm

…

powerfist.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

puzzle_pieces.dm

new space ruin, the biological research outpost (#79149)

2023-10-31 08:15:42 +13:00

religion.dm

A thorough audit of damage procs and specifically their use in on_mob_life() (with unit tests!) (#78657)

2023-10-03 04:01:32 -04:00

rollertable_dock.dm

…

scrolls.dm

…

secret_documents.dm

…

sharpener.dm

…

shields.dm

Disarm refactor, plus shoving people with shields (#80123)

2024-01-16 19:35:56 -06:00

shooting_range.dm

A comprehensive refactor / cleanup of bullet_hit and on_hit to cut out a single bad species / mob proc (#79024)

2023-10-18 23:08:13 -06:00

shrapnel.dm

…

signs.dm

…

skub.dm

Refactor gib code to use bitflags and have documentation (#78754)

2023-10-06 13:12:22 +01:00

spear.dm

Refactor gib code to use bitflags and have documentation (#78754)

2023-10-06 13:12:22 +01:00

sticker.dm

…

surgery_tray.dm

Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) (#81120)

2024-02-05 11:42:03 -08:00

syndie_spraycan.dm

Add 50% graffiti speed boost to tagger quirk (#80567)

2023-12-28 15:13:15 +01:00

tail_pin.dm

offical to official (#78762)

2023-10-06 16:03:22 -06:00

taster.dm

…

teleportation.dm

Fix bad assumption in syndicate teleporter code (#80900)

2024-01-11 16:17:52 -05:00

theft_tools.dm

Fixes throwing hard del (#80551)

2023-12-25 13:00:50 +01:00

tongs.dm

Fixes some fried food exploits (#79789)

2023-11-17 23:52:22 -07:00

toy_mechs.dm

…

toys.dm

Fixes throwing hard del (#80551)

2023-12-25 13:00:50 +01:00

trash.dm

Mothic Fleet Rations now leave trash (#81280)

2024-02-05 15:44:23 -08:00

v8_engine.dm

…

vending_items.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00

virgin_mary.dm

…

wall_mounted.dm

Explodes device.dmi (#80025)

2023-12-09 13:31:50 +01:00

weaponry.dm

FOV is Dead (Long Live FOV) (#80062)

2023-12-13 15:52:24 +01:00

wiki_manuals.dm

Fixes Wiki Book Manuals not working (#79589)

2023-11-09 18:37:15 +13:00

wizard_weapons.dm

Demotes the "electrical conductivity" flag from flags_1 to obj_flags (#80033)

2023-12-01 21:43:46 -05:00