mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-04 21:39:20 +00:00
## About The Pull Request This improves the code surrounding the Dice Servant, as well as the summoning behavior, to make it WAY more intuitive. "But what IS a Dice Servant?" well... If you roll a 16 on a Die of Fate, you get a unique "Dice Servant" spell that lets you summon a butler from wherever they may be. The issue is that the role itself is polled for a mere 5 seconds, and if nobody signs up for it, the role is never offered again and the caster gets no servant. Now, the spell will attempt to gather candidates, and if it fails, it will continue trying to do so upon your next cast. This also makes it so the spell can be applied to players through VV or other unimplemented means. The code has been cleaned up a bit, and the "dice servant" spell has been converted into a generic "servant" role. The Dice Servant, however, retains the old role name (and now plays a service bell "ding!" when you summon your butler!) There are some other, very minor changes like reducing the smoke from each summon, or adding an apostrophe to the incantation (I think that's all). ## Why It's Good For The Game Rolling a Die of Fate (RARE), and landing a 16 (1/20), and having someone scoop up the ghost role in 5 seconds or less (I hope pop is above 50) has made this role a very uncommon sight. I saw it for the first time about a week ago. It's been in the game for a very very long time. It's a cool, unique role that should be much more accessible and intuitive than it currently is. The code improvements also lay a great groundwork for other mob summon spells to be made off of. ## Changelog 🆑 Rhials code: The Dice Servant role will now re-poll itself until a candidate is found. /🆑