mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-30 11:01:35 +00:00
18aa09b7e4
## About The Pull Request Weather effects were ignoring certain areas like space. This was due to checking the area's `z` position. Some areas like `area/space` are in many different z-levels and the `z` position defaults to Centcomm `z=1`. The solution is to loop through `area.turfs_by_zlevel` and check if it has any turfs in that z-level. CC @LemonInTheDark the mutable overlay for weather effects is not applying to space.7e27663517/code/datums/weather/weather.dm (L253-L271)I'm assuming this is due to plane master shengians. I could just add the effects like the radiation nebula:7e27663517/code/datums/station_traits/negative_traits.dm (L486-L493)But this doesn't appear reversible. I'm open to suggestions. ## Why It's Good For The Game Rad storms now affect space outside the station. Other weather effects should also be consistent and not be ignored by certain misc. areas types. ## Changelog 🆑 fix: Fix weather effects ignoring certain areas like space. /🆑 --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>