mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-29 10:31:34 +00:00
6c017cf1e1
## About The Pull Request
As the title says.
`init_order` is no more, subsystems ordering now depends on their
declared dependencies.
Subsystems can now declare which other subsystems need to init before
them using a list and the subsystem's typepath
I.e.
```dm
dependencies = list(
/datum/controller/subsystem/atoms,
/datum/controller/subsystem/mapping
)
```
The reverse can also be done, if a subsystem must initialize after your
own:
```dm
dependents = list(
/datum/controller/subsystem/atoms
)
```
Cyclical dependencies are not allowed and will throw an error on
initialization if one is found.
There's also a debug tool to visualize the dependency graph, although
it's a bit basic:
Subsystem load ordering can still be controlled using `init_stage`, some
subsystems use this in cases where they must initialize first or last
regardless of dependencies. An error will be thrown if a subsystem has
an `init_stage` before one of their dependencies.
## Why It's Good For The Game
Makes dealing with subsystem dependencies easier, and reduces the chance
of making a dependency error when needing to shift around subsystem
inits.
## Changelog
🆑
refactor: Refactored subsystem initialization
/🆑
92 lines
3.8 KiB
Plaintext
92 lines
3.8 KiB
Plaintext
|
|
SUBSYSTEM_DEF(ore_generation)
|
|
name = "Ore Generation"
|
|
wait = 60 SECONDS
|
|
dependencies = list(
|
|
/datum/controller/subsystem/atoms
|
|
)
|
|
runlevels = RUNLEVEL_GAME
|
|
|
|
/// All ore vents that are currently producing boulders.
|
|
var/list/obj/structure/ore_vent/processed_vents = list()
|
|
/// All the ore vents that are currently in the game, not just the ones that are producing boulders.
|
|
var/list/obj/structure/ore_vent/possible_vents = list()
|
|
/// All the boulders that have been produced by ore vents to be pulled by BRM machines.
|
|
var/list/obj/item/boulder/available_boulders = list()
|
|
/**
|
|
* A list of all the minerals that are being mined by ore vents. We reset this list every time cave generation is done.
|
|
* Generally Should be empty by the time initialize ends on lavaland.
|
|
* Each key value is the number of vents that will have this ore as a unique possible choice.
|
|
* If we call cave_generation more than once, we copy a list from the lists in lists/ores_spawned.dm
|
|
*/
|
|
var/list/ore_vent_minerals = list()
|
|
|
|
/// A tracker of how many of each ore vent size we have in the game. Useful for tracking purposes.
|
|
|
|
/datum/controller/subsystem/ore_generation/Initialize()
|
|
//Basically, we're going to round robin through the list of ore vents and assign a mineral to them until complete.
|
|
while(length(ore_vent_minerals) > 0) //Keep looping if there's more to assign
|
|
var/stallbreaker = 0
|
|
for(var/obj/structure/ore_vent/vent as anything in possible_vents)
|
|
if(length(ore_vent_minerals) <= 0) //But break early if there's none left.
|
|
break
|
|
if(vent.unique_vent)
|
|
continue //Ya'll already got your minerals.
|
|
if(length(difflist(first = ore_vent_minerals, second = vent.mineral_breakdown, skiprep = 1)))
|
|
vent.generate_mineral_breakdown(new_minerals = 1, map_loading = TRUE)
|
|
else
|
|
stallbreaker++
|
|
if(stallbreaker >= length(possible_vents))
|
|
break //We've done all we can here. break inner loop
|
|
continue
|
|
if(stallbreaker >= length(possible_vents))
|
|
break //We've done all we can here. break outer loop
|
|
|
|
/// Handles roundstart logging
|
|
logger.Log(
|
|
LOG_CATEGORY_CAVE_GENERATION,
|
|
"Ore Generation spawned the following ores based on vent proximity",
|
|
list(
|
|
"[ORE_WALL_FAR]" = GLOB.post_ore_random["[ORE_WALL_FAR]"],
|
|
"[ORE_WALL_LOW]" = GLOB.post_ore_random["[ORE_WALL_LOW]"],
|
|
"[ORE_WALL_MEDIUM]" = GLOB.post_ore_random["[ORE_WALL_MEDIUM]"],
|
|
"[ORE_WALL_HIGH]" = GLOB.post_ore_random["[ORE_WALL_HIGH]"],
|
|
"[ORE_WALL_VERY_HIGH]" = GLOB.post_ore_random["[ORE_WALL_VERY_HIGH]"],
|
|
),
|
|
)
|
|
logger.Log(
|
|
LOG_CATEGORY_CAVE_GENERATION,
|
|
"Ore Generation spawned the following ores randomly",
|
|
list(
|
|
"[ORE_WALL_FAR]" = GLOB.post_ore_manual["[ORE_WALL_FAR]"],
|
|
"[ORE_WALL_LOW]" = GLOB.post_ore_manual["[ORE_WALL_LOW]"],
|
|
"[ORE_WALL_MEDIUM]" = GLOB.post_ore_manual["[ORE_WALL_MEDIUM]"],
|
|
"[ORE_WALL_HIGH]" = GLOB.post_ore_manual["[ORE_WALL_HIGH]"],
|
|
"[ORE_WALL_VERY_HIGH]" = GLOB.post_ore_manual["[ORE_WALL_VERY_HIGH]"],
|
|
),
|
|
)
|
|
logger.Log(
|
|
LOG_CATEGORY_CAVE_GENERATION,
|
|
"Ore Generation spawned the following vent sizes",
|
|
list(
|
|
"large" = LAZYACCESS(GLOB.ore_vent_sizes, LARGE_VENT_TYPE),
|
|
"medium" = LAZYACCESS(GLOB.ore_vent_sizes, MEDIUM_VENT_TYPE),
|
|
"small" = LAZYACCESS(GLOB.ore_vent_sizes, SMALL_VENT_TYPE),
|
|
),
|
|
)
|
|
return SS_INIT_SUCCESS
|
|
|
|
/datum/controller/subsystem/ore_generation/fire(resumed)
|
|
available_boulders.Cut() // reset upon new fire.
|
|
for(var/obj/structure/ore_vent/current_vent as anything in processed_vents)
|
|
|
|
var/local_vent_count = 0
|
|
for(var/obj/item/boulder/old_rock in current_vent.loc)
|
|
available_boulders += old_rock
|
|
local_vent_count++
|
|
|
|
if(local_vent_count >= MAX_BOULDERS_PER_VENT)
|
|
continue //We don't want to be accountable for literally hundreds of unprocessed boulders for no reason.
|
|
|
|
available_boulders += current_vent.produce_boulder()
|