Files
Bubberstation/code/datums/cogbar.dm
tonty 3f0b4abb8d Replaces world.icon_size (and some magic numbers) with defines (#86819)
## About The Pull Request

All usages of world.icon_size in code have been replaced with new
`ICONSIZE_X`, `ICONSIZE_Y` and `ICONSIZE_ALL` defines depending on
context

Replaces some "32" magic numbers with the defines

A few bits of code have been modified to split up x/y math as well

## Why It's Good For The Game

Magic number bad, code more readable, code more flexible and I'm told
there's an access cost to doing world.icon_size so minor performance
gains

## Changelog

🆑 tonty
code: made some code relating to the world's icon size more readable
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-09-29 13:28:32 +00:00

88 lines
1.9 KiB
Plaintext

#define COGBAR_ANIMATION_TIME (0.5 SECONDS)
/**
* ### Cogbar
* Represents that the user is busy doing something.
*/
/datum/cogbar
/// Who's doing the thing
var/mob/user
/// The user client
var/client/user_client
/// The visible element to other players
var/obj/effect/overlay/vis/cog
/// The blank image that overlaps the cog - hides it from the source user
var/image/blank
/// The offset of the icon
var/offset_y
/datum/cogbar/New(mob/user)
src.user = user
src.user_client = user.client
var/list/icon_offsets = user.get_oversized_icon_offsets()
offset_y = icon_offsets["y"]
add_cog_to_user()
RegisterSignal(user, COMSIG_QDELETING, PROC_REF(on_user_delete))
/datum/cogbar/Destroy()
if(user)
SSvis_overlays.remove_vis_overlay(user, user.managed_vis_overlays)
user_client?.images -= blank
user = null
user_client = null
cog = null
QDEL_NULL(blank)
return ..()
/// Adds the cog to the user, visible by other players
/datum/cogbar/proc/add_cog_to_user()
cog = SSvis_overlays.add_vis_overlay(user,
icon = 'icons/effects/progressbar.dmi',
iconstate = "cog",
plane = HIGH_GAME_PLANE,
add_appearance_flags = APPEARANCE_UI_IGNORE_ALPHA,
unique = TRUE,
alpha = 0,
)
cog.pixel_y = ICON_SIZE_Y + offset_y
animate(cog, alpha = 255, time = COGBAR_ANIMATION_TIME)
if(isnull(user_client))
return
blank = image('icons/blanks/32x32.dmi', cog, "nothing")
SET_PLANE_EXPLICIT(blank, HIGH_GAME_PLANE, user)
blank.appearance_flags = APPEARANCE_UI_IGNORE_ALPHA
blank.override = TRUE
user_client.images += blank
/// Removes the cog from the user
/datum/cogbar/proc/remove()
if(isnull(cog))
qdel(src)
return
animate(cog, alpha = 0, time = COGBAR_ANIMATION_TIME)
QDEL_IN(src, COGBAR_ANIMATION_TIME)
/// When the user is deleted, remove the cog
/datum/cogbar/proc/on_user_delete(datum/source)
SIGNAL_HANDLER
qdel(src)
#undef COGBAR_ANIMATION_TIME