SkyratBot d833cfa83b [MIRROR] Optimize mirage_border by converting it to an element and a movable [MDB IGNORE] (#22913) ...

* Optimize mirage_border by converting it to an element and a movable (#77137)

## About The Pull Request

Converts /datum/component/mirage_border to an element, saving init time
spent attaching components to thousands of objects. It also repaths it
from /obj/effect/abstract to /atom/movable, since it doesn't need to be
an object, as it's not a physical object within the game.

~~Also adds a case handling when world.view is not an integer.~~ This
never happens

Here it is working:

https://github.com/tgstation/tgstation/assets/10366817/c8cfe2df-275a-4c97-b063-4fd83f7f09c3

Port of https://github.com/BeeStation/BeeStation-Hornet/pull/9490/

## Why It's Good For The Game

Saves init time, approx 0.32sec on Meta on my machine.

![image](https://github.com/tgstation/tgstation/assets/10366817/f423813e-e627-44a4-b6c6-b1d6fe49e8c3)

![image](https://github.com/tgstation/tgstation/assets/10366817/ad6796c6-ff78-4140-9a5a-3572ac34f42c)

## Changelog

🆑
code: Optimized z-level transition mirages, saving ~0.32s init.
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>

* Optimize mirage_border by converting it to an element and a movable

---------

Co-authored-by: itsmeow <itsmeow@itsmeow.dev>
Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>

2023-08-07 09:41:46 -04:00

6.4 KiB

Raw Blame History

View Raw