mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-11 09:22:41 +00:00
## About The Pull Request This PR alters the Play Internet Sound, First off it modifies the Widget To clean up some info on the widget to hide information when that information is not available to be shown. Secondly it makes the URL input prompt for Play Internet Sound to be a TGUI text input box, as well as adds in a warning if a song being played is >10 minutes long, and adds in a proc to play music with a supplied variable. Secondly This PR adds in a new player facing VERB in the OOC tab called `Request Internet Sound` functionally the verb is similar to Pray but it grants admins the ability to play URL's directly from the chat or Request Manager, where it will prompt the admin if they wish to play the song. <details> <summary>Screenshots/Videos</summary>  <details> <summary>Widget</summary>    </details> <details> <summary>New Prompts</summary>   </details> <details> <summary>Videos</summary> https://user-images.githubusercontent.com/2568378/226794939-4ca018b3-bba5-4893-9301-6858b0d433b9.mp4 https://user-images.githubusercontent.com/2568378/226794783-ca750840-3149-489c-9239-00014ac4ca5c.mp4 </details> </details> ## Why It's Good For The Game This cleans up the UI for the Play Internet Sound so that things to hide info when admins choose to hide it, or to not show it if that information exists at all. As well as grants players a ability to request music to be played via Admin Midi and sorts them with prayers and allows admins to directly play URL's simultaneously cleaning up any music requests made through prays as well as a more obvious way for people to request music rather than them Ahelping for music ## Changelog 🆑 add: New VERB, Request Internet Sound, It is in the OOC tab and allows you to request music from admins to play, by default only allows bandcamp, youtube, and soundcloud links fix: Fixes the Admin Midi Widget UI to only present info that is available to players to be seen admin: Play Internet Sound URL input is now TGUI admin: Play Internet Sound warns you if a song length is >10 Minutes admin: Added new mute type to mute internet sound requests from a player config: Added thee new config options, LOG_INTERNET_REQUEST, REQUEST_INTERNET_SOUND, REQUEST_INTERNET_ALLOWED /🆑 --------- Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
273 lines
8.5 KiB
Plaintext
273 lines
8.5 KiB
Plaintext
/// Requests from prayers
|
|
#define REQUEST_PRAYER "request_prayer"
|
|
/// Requests for Centcom
|
|
#define REQUEST_CENTCOM "request_centcom"
|
|
/// Requests for the Syndicate
|
|
#define REQUEST_SYNDICATE "request_syndicate"
|
|
/// Requests for the nuke code
|
|
#define REQUEST_NUKE "request_nuke"
|
|
/// Requests somebody from fax
|
|
#define REQUEST_FAX "request_fax"
|
|
/// Requests from Request Music
|
|
#define REQUEST_INTERNET_SOUND "request_internet_sound"
|
|
|
|
GLOBAL_DATUM_INIT(requests, /datum/request_manager, new)
|
|
|
|
/**
|
|
* # Request Manager
|
|
*
|
|
* Handles all player requests (prayers, centcom requests, syndicate requests)
|
|
* that occur in the duration of a round.
|
|
*/
|
|
/datum/request_manager
|
|
/// Associative list of ckey -> list of requests
|
|
var/list/requests = list()
|
|
/// List where requests can be accessed by ID
|
|
var/list/requests_by_id = list()
|
|
|
|
/datum/request_manager/Destroy(force, ...)
|
|
QDEL_LIST(requests)
|
|
return ..()
|
|
|
|
/**
|
|
* Used in the new client pipeline to catch when clients are reconnecting and need to have their
|
|
* reference re-assigned to the 'owner' variable of any requests
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is logging in
|
|
*/
|
|
/datum/request_manager/proc/client_login(client/C)
|
|
if (!requests[C.ckey])
|
|
return
|
|
for (var/datum/request/request as anything in requests[C.ckey])
|
|
request.owner = C
|
|
|
|
/**
|
|
* Used in the destroy client pipeline to catch when clients are disconnecting and need to have their
|
|
* reference nulled on the 'owner' variable of any requests
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is logging out
|
|
*/
|
|
/datum/request_manager/proc/client_logout(client/C)
|
|
if (!requests[C.ckey])
|
|
return
|
|
for (var/datum/request/request as anything in requests[C.ckey])
|
|
request.owner = null
|
|
|
|
/**
|
|
* Creates a request for a prayer, and notifies admins who have the sound notifications enabled when appropriate
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is praying
|
|
* * message - The prayer
|
|
* * is_chaplain - Boolean operator describing if the prayer is from a chaplain
|
|
*/
|
|
/datum/request_manager/proc/pray(client/C, message, is_chaplain)
|
|
request_for_client(C, REQUEST_PRAYER, message)
|
|
for(var/client/admin in GLOB.admins)
|
|
if(is_chaplain && admin.prefs.chat_toggles & CHAT_PRAYER && admin.prefs.toggles & SOUND_PRAYERS)
|
|
SEND_SOUND(admin, sound('sound/effects/pray.ogg'))
|
|
|
|
/**
|
|
* Creates a request for a Centcom message
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is sending the request
|
|
* * message - The message
|
|
*/
|
|
/datum/request_manager/proc/message_centcom(client/C, message)
|
|
request_for_client(C, REQUEST_CENTCOM, message)
|
|
|
|
/**
|
|
* Creates a request for a Syndicate message
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is sending the request
|
|
* * message - The message
|
|
*/
|
|
/datum/request_manager/proc/message_syndicate(client/C, message)
|
|
request_for_client(C, REQUEST_SYNDICATE, message)
|
|
|
|
/**
|
|
* Creates a request for the nuclear self destruct codes
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is sending the request
|
|
* * message - The message
|
|
*/
|
|
/datum/request_manager/proc/nuke_request(client/C, message)
|
|
request_for_client(C, REQUEST_NUKE, message)
|
|
|
|
/**
|
|
* Creates a request for fax answer
|
|
*
|
|
* Arguments:
|
|
* * requester - The client who is sending the request
|
|
* * message - Paper with text.. some stamps.. and another things.
|
|
*/
|
|
/datum/request_manager/proc/fax_request(client/requester, message, additional_info)
|
|
request_for_client(requester, REQUEST_FAX, message, additional_info)
|
|
|
|
/**
|
|
* Creates a request for a song
|
|
*
|
|
* Arguments:
|
|
* * requester - The client who is sending the request
|
|
* * message - The URL of the song
|
|
*/
|
|
|
|
/datum/request_manager/proc/music_request(client/requester, message)
|
|
request_for_client(requester, REQUEST_INTERNET_SOUND, message)
|
|
|
|
/**
|
|
* Creates a request and registers the request with all necessary internal tracking lists
|
|
*
|
|
* Arguments:
|
|
* * C - The client who is sending the request
|
|
* * type - The type of request, see defines
|
|
* * message - The message
|
|
*/
|
|
/datum/request_manager/proc/request_for_client(client/C, type, message, additional_info)
|
|
var/datum/request/request = new(C, type, message, additional_info)
|
|
if (!requests[C.ckey])
|
|
requests[C.ckey] = list()
|
|
requests[C.ckey] += request
|
|
requests_by_id.len++
|
|
requests_by_id[request.id] = request
|
|
|
|
/datum/request_manager/ui_interact(mob/user, datum/tgui/ui = null)
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if (!ui)
|
|
ui = new(user, src, "RequestManager")
|
|
ui.open()
|
|
|
|
/datum/request_manager/ui_state(mob/user)
|
|
return GLOB.admin_state
|
|
|
|
/datum/request_manager/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
|
|
if (..())
|
|
return
|
|
|
|
// Only admins should be sending actions
|
|
if (!check_rights(R_ADMIN))
|
|
to_chat(usr, "You do not have permission to do this, you require +ADMIN", confidential = TRUE)
|
|
return
|
|
|
|
// Get the request this relates to
|
|
var/id = params["id"] != null ? text2num(params["id"]) : null
|
|
if (!id)
|
|
to_chat(usr, "Failed to find a request ID in your action, please report this", confidential = TRUE)
|
|
CRASH("Received an action without a request ID, this shouldn't happen!")
|
|
var/datum/request/request = !id ? null : requests_by_id[id]
|
|
|
|
switch(action)
|
|
if ("pp")
|
|
var/mob/M = request.owner?.mob
|
|
usr.client.holder.show_player_panel(M)
|
|
return TRUE
|
|
if ("vv")
|
|
var/mob/M = request.owner?.mob
|
|
usr.client.debug_variables(M)
|
|
return TRUE
|
|
if ("sm")
|
|
var/mob/M = request.owner?.mob
|
|
usr.client.cmd_admin_subtle_message(M)
|
|
return TRUE
|
|
if ("flw")
|
|
var/mob/M = request.owner?.mob
|
|
usr.client.admin_follow(M)
|
|
return TRUE
|
|
if ("tp")
|
|
if(!SSticker.HasRoundStarted())
|
|
tgui_alert(usr,"The game hasn't started yet!")
|
|
return TRUE
|
|
var/mob/M = request.owner?.mob
|
|
if(!ismob(M))
|
|
var/datum/mind/D = M
|
|
if(!istype(D))
|
|
to_chat(usr, "This can only be used on instances of type /mob and /mind", confidential = TRUE)
|
|
return TRUE
|
|
else
|
|
D.traitor_panel()
|
|
return TRUE
|
|
else
|
|
usr.client.holder.show_traitor_panel(M)
|
|
return TRUE
|
|
if ("logs")
|
|
var/mob/M = request.owner?.mob
|
|
if(!ismob(M))
|
|
to_chat(usr, "This can only be used on instances of type /mob.", confidential = TRUE)
|
|
return TRUE
|
|
show_individual_logging_panel(M, null, null)
|
|
return TRUE
|
|
if ("smite")
|
|
if(!check_rights(R_FUN))
|
|
to_chat(usr, "Insufficient permissions to smite, you require +FUN", confidential = TRUE)
|
|
return TRUE
|
|
var/mob/living/carbon/human/H = request.owner?.mob
|
|
if (!H || !istype(H))
|
|
to_chat(usr, "This can only be used on instances of type /mob/living/carbon/human", confidential = TRUE)
|
|
return TRUE
|
|
usr.client.smite(H)
|
|
return TRUE
|
|
if ("rply")
|
|
if (request.req_type == REQUEST_PRAYER)
|
|
to_chat(usr, "Cannot reply to a prayer", confidential = TRUE)
|
|
return TRUE
|
|
var/mob/M = request.owner?.mob
|
|
usr.client.admin_headset_message(M, request.req_type == REQUEST_SYNDICATE ? RADIO_CHANNEL_SYNDICATE : RADIO_CHANNEL_CENTCOM)
|
|
return TRUE
|
|
if ("setcode")
|
|
if (request.req_type != REQUEST_NUKE)
|
|
to_chat(usr, "You cannot set the nuke code for a non-nuke-code-request request!", confidential = TRUE)
|
|
return TRUE
|
|
var/code = random_nukecode()
|
|
for(var/obj/machinery/nuclearbomb/selfdestruct/SD in GLOB.nuke_list)
|
|
SD.r_code = code
|
|
message_admins("[key_name_admin(usr)] has set the self-destruct code to \"[code]\".")
|
|
return TRUE
|
|
if ("show")
|
|
if(request.req_type != REQUEST_FAX)
|
|
to_chat(usr, "Request doesn't have a paper to read.", confidential = TRUE)
|
|
return TRUE
|
|
var/obj/item/paper/request_message = request.additional_information
|
|
request_message.ui_interact(usr)
|
|
return TRUE
|
|
if ("play")
|
|
if(request.req_type != REQUEST_INTERNET_SOUND)
|
|
to_chat(usr, "Request doesn't have a sound to play.", confidential = TRUE)
|
|
return TRUE
|
|
if(findtext(request.message, ":") && !findtext(request.message, GLOB.is_http_protocol))
|
|
to_chat(usr, "Request is not a valid URL.", confidential = TRUE)
|
|
return TRUE
|
|
|
|
web_sound(usr, request.message)
|
|
return TRUE
|
|
|
|
/datum/request_manager/ui_data(mob/user)
|
|
. = list(
|
|
"requests" = list()
|
|
)
|
|
for (var/ckey in requests)
|
|
for (var/datum/request/request as anything in requests[ckey])
|
|
var/list/data = list(
|
|
"id" = request.id,
|
|
"req_type" = request.req_type,
|
|
"owner" = request.owner ? "[REF(request.owner)]" : null,
|
|
"owner_ckey" = request.owner_ckey,
|
|
"owner_name" = request.owner_name,
|
|
"message" = request.message,
|
|
"additional_info" = request.additional_information,
|
|
"timestamp" = request.timestamp,
|
|
"timestamp_str" = gameTimestamp(wtime = request.timestamp)
|
|
)
|
|
.["requests"] += list(data)
|
|
|
|
#undef REQUEST_PRAYER
|
|
#undef REQUEST_CENTCOM
|
|
#undef REQUEST_SYNDICATE
|
|
#undef REQUEST_NUKE
|
|
#undef REQUEST_FAX
|
|
#undef REQUEST_INTERNET_SOUND
|