mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-03 21:42:06 +00:00
## About The Pull Request 1. Removed unused vars `our_turf_thermal_conductivity`. It did nothing 2. Removed redundant vars such as - `mapped` : It can be replaced with `maploaded` var inside `Initialize()` proc as it simply checks if the turbine was created during round start or not. This does mean that admin spawned turbine parts won't come pre installed with parts but that's not a big deal since they can spawn the parts anyway - `has_gas_mix` : All turbine parts set's this var to `TRUE` so might as well make that the default case - `gas_theoretical_volume` : This can be passed as an param inside `Initialize()` directly rather than storing it in a var which gets used only once 3. Autodoc for procs, fixed return values of some tool acts & `attackby`(we want to return TRUE to end the attack chain early). Removes balloon alert when opening/closing panel. The visual overlay makes that obvious 4. The turbine now shuts itself off when the room has no power/the turbine is sufficiently damaged. The turbine uses a small amount of power for operation (for that green light, internal electronics & stuff) cause it makes sense 5. Fixes runtime when opening turbine computer and one of the turbine parts is disconnected 6. Adds Screen tips & fixes examines (they weren't using the `span_notice()` proc) and adds even more examines ## Changelog 🆑 fix: turbine now shuts itself off when the room apc loses power or if it gets damaged. Also uses a small amount of power for operation of internal electronics, the green light & other stuff fix: No more runtime in turbine computer when parts are not fully connected qol: adds screentips & examines for turbine code: removed unused vars, auto doc procs and cleans up some code in turbine /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>