SkyratBot e33577856c [MIRROR] Fix: potential bucket corruption in timer reset_buckets [MDB IGNORE] (#10156) ...

* Fix: potential bucket corruption in timer reset_buckets (#63427)

Ports Semoro's fix (ss220-space/Paradise#511) related to potential SStimer bucket corruption which caused infinite loop.

    The essence of the fix is that earlier timers with a built linkedlist could get into the second queue, which could cause an incorrect state. It works super stupidly, resets the state to the original correct one

BUT THERE IS STILL A BUG IN THE CODE RELATED TO THE INFINITE LOOP!

For some reason the SStimer on our server started to break recently at the beginning of the round. Found that code for waterfall drip effect was causing the issue. Found that setting frequensy to 0 (and calling reset_bucket sometimes) can be used to reproduce the bug. Tried to fix it with this PR

there is an oustanding bug with airlocks causing SStimer to brake sometimes.

cl
fix: fixed potential bucket corruption in timer reset_buckets
/cl

* Fix: potential bucket corruption in timer reset_buckets

Co-authored-by: Aziz Chynaliev <azizonkg@gmail.com>

2021-12-22 14:48:24 +00:00

..

processing

[SEMI-MODULAR] Nerve staple bounty (#9970)

2021-12-19 02:19:20 +00:00

achievements.dm

…

addiction.dm

…

adjacent_air.dm

[MIRROR] modules/atmospherics major cleanup [MDB IGNORE] (#8818)

2021-10-14 22:44:30 +01:00

ai_controllers.dm

…

air.dm

[MIRROR] modules/atmospherics major cleanup [MDB IGNORE] (#8818)

2021-10-14 22:44:30 +01:00

ambience.dm

[MIRROR] Adds keyloop to the autoclearing ss, cleans up ssambience a bit (#8330)

2021-09-23 02:37:59 +01:00

assets.dm

…

atoms.dm

[MIRROR] _HELPERS/unsorted.dm has been sorted [MDB IGNORE] (#8627)

2021-10-06 22:07:01 +01:00

augury.dm

…

blackbox.dm

[MIRROR] Allows players to send more visible adminhelps when no admins are on, which'll definitely alert admins [MDB IGNORE] (#9583)

2021-11-20 22:41:53 +01:00

blackmarket.dm

[MIRROR] removes double spaces before symbols [MDB IGNORE] (#9117)

2021-10-29 04:14:00 +01:00

chat.dm

…

circuit_component.dm

[MIRROR] Refactors the list datatype to support composite lists. Adapts a lot of circuits to be able to properly use composite lists. Adds the dispenser shell [MDB IGNORE] (#8650)

2021-10-08 14:19:46 +01:00

communications.dm

…

dbcore.dm

…

dcs.dm

[MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)

2021-10-13 21:07:35 +01:00

discord.dm

[MIRROR] removes double spaces before symbols [MDB IGNORE] (#9117)

2021-10-29 04:14:00 +01:00

disease.dm

…

early_assets.dm

…

economy.dm

[MIRROR] market crashing is now a status strait to avoid concurrence problems. [MDB IGNORE] (#9434)

2021-11-14 23:32:09 +00:00

eigenstate.dm

…

events.dm

Events audit, moving overrides to modular files + TEMP FIX (#9941)

2021-12-15 01:48:44 +00:00

explosions.dm

[MIRROR] _HELPERS/unsorted.dm has been sorted [MDB IGNORE] (#8627)

2021-10-06 22:07:01 +01:00

fire_burning.dm

…

garbage.dm

[MIRROR] Adds an additional queue to the qdel subsystem to quickly filter out things that garbage collect within the first second. [MDB IGNORE] (#9604)

2021-11-22 00:37:09 -05:00

icon_smooth.dm

…

id_access.dm

[MIRROR] Makes all default job titles, defines. [MDB IGNORE] (#10080)

2021-12-18 16:54:03 +00:00

idlenpcpool.dm

…

init_profiler.dm

[MIRROR] Fixed spelling of possession, Separate, and Cemetery [MDB IGNORE] (#9862)

2021-12-03 16:58:40 -05:00

input.dm

…

ipintel.dm

…

job.dm

[MIRROR] Makes all default job titles, defines. [MDB IGNORE] (#10080)

2021-12-18 16:54:03 +00:00

lag_switch.dm

[MIRROR] Add disabling footstep sounds and parallax to the lag switch panel [MDB IGNORE] (#9645)

2021-11-23 08:44:29 -05:00

language.dm

Skyrat Prefs Menu: Fixing everything to work correctly (#8350)

2021-09-29 15:24:30 +01:00

lighting.dm

…

machines.dm

…

mapping.dm

[MIRROR] Map load unit testing and directory whitelisting - Mojave Sun is a really cool downstream, like and subscribe for longer PR names. oranges was here and made this github PR name much longer, thereby proving once and for all that upstreams do add value to the downstream not just endless amounts of refactoring because we can't write any api's in a modular fashion the first time around so have to update them later to be modular. Anyway do you think a taco counts as a sandwich? [MDB IGNORE] (#9290)

2021-11-07 08:09:43 -05:00

materials.dm

[MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)

2021-10-13 21:07:35 +01:00

minor_mapping.dm

[MIRROR] Refactor /turf/var/intact [MDB IGNORE] (#9114)

2021-10-30 00:19:21 +13:00

mobs.dm

…

moods.dm

…

nightshift.dm

…

npcpool.dm

…

overlays.dm

[MIRROR] Undoes "Removes CHECK_TICK from overlays, following the same theory as instant explosions" (#58382) [MDB IGNORE] (#9216)

2021-11-03 07:00:05 -04:00

pai.dm

[MIRROR] TGUI pAI Hotfix 1 [MDB IGNORE] (#9855)

2021-12-03 15:47:45 -05:00

parallax.dm

…

pathfinder.dm

…

persistence.dm

[MIRROR] Makes all default job titles, defines. [MDB IGNORE] (#10080)

2021-12-18 16:54:03 +00:00

persistent_paintings.dm

[MIRROR] Paintings improvements. [MDB IGNORE] (#9977)

2021-12-09 16:47:52 -05:00

points_of_interest.dm

[MIRROR] [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby. (#8339)

2021-09-24 18:16:17 +01:00

profiler.dm

…

radiation.dm

[MIRROR] Modernizing Radiation -- TL;DR: Radiation is now a status effect healed by tox healing, and contamination is removed [MDB IGNORE] (#9176)

2021-11-02 10:36:46 -04:00

radio.dm

…

research.dm

[MIRROR] Replaces downloading research notes with a new antag objective and station sabotage point. (#8401)

2021-09-26 01:49:02 +01:00

restaurant.dm

…

runechat.dm

…

security_level.dm

…

server_maint.dm

[MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)

2021-10-13 21:07:35 +01:00

shuttle.dm

[MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)

2021-10-13 21:07:35 +01:00

skills.dm

…

sound_loops.dm

…

sounds.dm

…

spacedrift.dm

…

statpanel.dm

…

stickyban.dm

…

sun.dm

…

tcgsetup.dm

…

tgui.dm

…

throwing.dm

[MIRROR] multiz movement refactor redux [MDB IGNORE] (#9925)

2021-12-07 08:27:12 -05:00

ticker.dm

[MIRROR] Updates Round End News Message for when Nuclear Operatives succeed to be more gender-neutral [MDB IGNORE] (#10163)

2021-12-21 18:02:00 +00:00

time_track.dm

…

timer.dm

[MIRROR] Fix: potential bucket corruption in timer reset_buckets [MDB IGNORE] (#10156)

2021-12-22 14:48:24 +00:00

title.dm

fixes non-widescreen titles not getting auto-centered on bootup (#8963)

2021-10-23 00:43:14 +01:00

vis_overlays.dm

…

vote.dm

[MIRROR] TGUI input box conversions 1 [MDB IGNORE] (#10020)

2021-12-13 10:41:44 +00:00

wardrobe.dm

[MIRROR] Speeds up the preference menu, significantly. Adds object pooling, other stuff too [MDB IGNORE] (#9962)

2021-12-10 02:22:41 +00:00

weather.dm

[MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)

2021-10-13 21:07:35 +01:00

wiremod_composite.dm

[MIRROR] Refactors the list datatype to support composite lists. Adapts a lot of circuits to be able to properly use composite lists. Adds the dispenser shell [MDB IGNORE] (#8650)

2021-10-08 14:19:46 +01:00