Files
Bubberstation/code/game/objects/effects/effects.dm
SkyratBot bdae2caa82 [MIRROR] Effects no longer runtime on being attacked [MDB IGNORE] (#19242)
* Effects no longer runtime on being attacked (#73300)

## About The Pull Request

Effects didn;t override generic attack, which caused runtimes when
attacked
## Why It's Good For The Game
Closes #73295
## Changelog

Signed-off-by: GitHub <noreply@ github.com>

* Effects no longer runtime on being attacked

---------

Signed-off-by: GitHub <noreply@ github.com>
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
2023-02-09 20:33:25 +00:00

66 lines
1.7 KiB
Plaintext

//objects in /obj/effect should never be things that are attackable, use obj/structure instead.
//Effects are mostly temporary visual effects like sparks, smoke, as well as decals, etc...
/obj/effect
icon = 'icons/effects/effects.dmi'
resistance_flags = INDESTRUCTIBLE | LAVA_PROOF | FIRE_PROOF | UNACIDABLE | ACID_PROOF | FREEZE_PROOF
move_resist = INFINITY
obj_flags = NONE
blocks_emissive = EMISSIVE_BLOCK_GENERIC
uses_integrity = FALSE
/obj/effect/attackby(obj/item/weapon, mob/user, params)
if(SEND_SIGNAL(weapon, COMSIG_ITEM_ATTACK_EFFECT, src, user, params) & COMPONENT_NO_AFTERATTACK)
return TRUE
// I'm not sure why these are snowflaked to early return but they are
if(istype(weapon, /obj/item/mop) || istype(weapon, /obj/item/soap))
return
return ..()
/obj/effect/attack_generic(mob/user, damage_amount, damage_type, damage_flag, sound_effect, armor_penetration)
return
/obj/effect/take_damage(damage_amount, damage_type = BRUTE, damage_flag = 0, sound_effect = 1, attack_dir)
return
/obj/effect/fire_act(exposed_temperature, exposed_volume)
return
/obj/effect/acid_act()
return FALSE
/obj/effect/blob_act(obj/structure/blob/B)
return
/obj/effect/attack_hulk(mob/living/carbon/human/user)
return FALSE
/obj/effect/experience_pressure_difference()
return
/obj/effect/ex_act(severity, target)
return FALSE
/obj/effect/singularity_act()
qdel(src)
///The abstract effect ignores even more effects and is often typechecked for atoms that should truly not be fucked with.
/obj/effect/abstract
/obj/effect/abstract/singularity_pull()
return
/obj/effect/abstract/singularity_act()
return
/obj/effect/abstract/has_gravity(turf/T)
return FALSE
/obj/effect/dummy/singularity_pull()
return
/obj/effect/dummy/singularity_act()
return