mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-04 22:11:27 +00:00
cf87e6b394
* Merge pull request #53377 from ArcaneMusic/plumbingfixesrev2 So, I may have made at least one... maybe 1.5 math errors. Namely, the reaction volume on every reagent was the full 200u. This is bad for bitcoin, as it means that you can instantly bottom out most reactions and drown someone in 1000 units of water in a single second! That's bad. Also! On that note, vapor reaction was also transferring reagents that otherwise helped contribute to the above problem. I've yeeted this in kind, but I'm willing to do some more testing and planning to see if they were specific to the reaction volume fix first, but to be safe vapor is vape-aint. Lastly: Gas chems were producing way, way, WAY too much gas even once the above two points were occuring. So much gas, that it was capable of filling a 8x10 tile airless room in a timed 1 minute 40 seconds. So, we've slowed the roll of the free reagents being produced by synthesizers, and brought it down to 1/5th of the reaction volume to 1/20th. That sounds like a massive leap, but trust me, you could produce millions of KPA very, VERY quickly without it, but at 1/20 it was actually sort of reasonable. Edit: Apparently this also fixes #46413 as a result of removing the obj_react from the above gasses! Fixes #53357. Also, prevents reagent synthesizers and showers to behave EXACTLY like gas miners, but free. Also, prevents 1000s of reagents from being multiplied through the use of showers. Changelog fix: Showers no longer have the vapor reaction, as before the changes. fix: Showers no longer produce ludicrously over-scaled chemical reactions. balance: Gas chems now produce 1/4th less gas when released into the air as before. * Several associated shower bug/QOL fixes. Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>