mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-25 08:34:23 +00:00
6eacdb03da
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Formerly, the reagent scan would provide a header based on whether or not reagents are present in a person's blood/stomach. This works, until you get cases where a user only has invisible reagents in their system, in which case the "Subject contains the following reagents" header would appear, but no chemical readouts would be present. The blood/stomach reagent readouts on the scanner now put their contents into a separate list, before adding it to the master readout list. This alternate list is checked for length, rather than whether or not the user has any reagents in their system at all, to determine what readout header to give. If there are no reagent readouts to provide, the scanner will report as if there is nothing present. In summary: If you have only invisible reagents in your system, the health scanner will provide the same readout as if you had nothing in you at all. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Closes #72311. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 🆑 Rhials fix: The chemical scanner will now properly display that "no" reagents are present in a subject when only invisible reagents are present. /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->