Ghom ea8ca7d56f [NO GBP] Fixing a logic mistake for chasm fishing (#77401) ...

## About The Pull Request
What it should do is spawn a generic item when the list of possible
things to retrieve is empty, not the other way around. Surprised this
weren't caught earlier.

## Why It's Good For The Game
See above.

## Changelog

🆑
fix: Fixed a logic mistake for chasm fishing that resulted in only
generic items being spawned.
/🆑

2023-08-06 13:54:30 -06:00

..

actionspeed

…

admin

Adds a system for logging metadata about hard deletes (#76956)

2023-08-04 14:15:00 -07:00

antagonists

New sprites for bottles (#77365)

2023-08-05 15:13:33 +02:00

art

Sets a saner length limit to ID assignments and paintings' titles. (#76723)

2023-07-27 05:31:53 -04:00

assembly

A small pile of borg combat changes (#75819)

2023-07-26 22:09:19 +01:00

asset_cache

Fix broken icons in RCD UI (Again) (#77217)

2023-07-31 22:38:18 -07:00

atmospherics

Implements usage of the REVERSE_DIR macro throughout the code. (#77122)

2023-07-28 15:16:09 +02:00

autowiki

Autowiki Stock Parts Template (#76765)

2023-08-05 10:57:40 -07:00

awaymissions

…

balloon_alert

…

basketball

…

buildmode

…

capture_the_flag

Improves the RPG loot wizard event. (#77218)

2023-07-31 17:09:53 +00:00

cards

…

cargo

BSA Supplies Cargo Crate now comes with a guide paper (#77371)

2023-08-06 12:11:56 -07:00

chatter

…

client

Screentip images (#76889)

2023-08-06 03:37:03 +00:00

clothing

reorganizes the human sprite folder and replaces the human_basic sprite with an updated one (#77323)

2023-08-05 14:12:05 +00:00

detectivework

…

discord

…

economy

…

emoji

…

error_handler

…

escape_menu

…

events

Portals now have a colorful glow (#77298)

2023-08-05 10:02:00 -07:00

experisci

…

explorer_drone

Fixes a large amount of spelling and grammatical errors in the Exploration Drones section. Also fixes an angry pine tree quip. (#77095)

2023-07-31 12:18:45 +00:00

fishing

[NO GBP] Fixing a logic mistake for chasm fishing (#77401)

2023-08-06 13:54:30 -06:00

flufftext

…

food_and_drinks

reorganizes the human sprite folder and replaces the human_basic sprite with an updated one (#77323)

2023-08-05 14:12:05 +00:00

forensics

…

hallucination

reorganizes the human sprite folder and replaces the human_basic sprite with an updated one (#77323)

2023-08-05 14:12:05 +00:00

holiday

…

holodeck

reorganizes the human sprite folder and replaces the human_basic sprite with an updated one (#77323)

2023-08-05 14:12:05 +00:00

hydroponics

Adds a unit test to stop elements from using identical lists for their arguments. (#76322)

2023-07-27 16:04:16 -07:00

industrial_lift

Refactors vendor tipping and adds 2 new malf modules: Remote vendor tipping, and the ability to roll around and crush anything in your path. (#76635)

2023-07-27 18:41:10 +00:00

instruments

…

interview

…

jobs

Improved PDA Direct Messenger (#75820)

2023-08-03 14:43:31 -07:00

keybindings

…

language

…

library

Refactors chameleon actions, Adds chameleon outfit saving, Adds chameleon scanner (#77140)

2023-07-29 15:39:06 -06:00

lighting

…

logging

…

mafia

Updates all the icons in under/suits.dmi and related sorting/cleanup (#76865)

2023-08-01 09:11:13 +00:00

mapfluff

[READY] Fishing and aquarium expansion. (#76531)

2023-07-27 22:50:36 +02:00

mapping

Add "Hall of Fame" emergency shuttle (#77074)

2023-07-31 18:03:02 -07:00

meteors

…

mining

Portals now have a colorful glow (#77298)

2023-08-05 10:02:00 -07:00

mob

Fixes Cell Message With Mulebots (#77374)

2023-08-06 12:07:52 -07:00

mob_spawn

Areas created with the "land claim" are no longer hazardous to free golems (#77357)

2023-08-04 16:05:16 -06:00

mod

pAIs can be inserted into a MODsuit (#77212)

2023-08-03 11:01:15 +02:00

modular_computers

Improved PDA Direct Messenger (#75820)

2023-08-03 14:43:31 -07:00

movespeed

[no GBP] Goliaths use TRAIT_NO_GLIDE instead of a movement cooldown element (#77370)

2023-08-05 15:11:51 +02:00

NTNet

…

pai

Add pAI movement freedom when emagged (#77325)

2023-08-06 00:44:10 +01:00

paperwork

BSA Supplies Cargo Crate now comes with a guide paper (#77371)

2023-08-06 12:11:56 -07:00

photography

Add "Hall of Fame" emergency shuttle (#77074)

2023-07-31 18:03:02 -07:00

plumbing

Implements usage of the REVERSE_DIR macro throughout the code. (#77122)

2023-07-28 15:16:09 +02:00

point

…

power

Autowiki Stock Parts Template (#76765)

2023-08-05 10:57:40 -07:00

procedural_mapping

…

projectiles

Portals now have a colorful glow (#77298)

2023-08-05 10:02:00 -07:00

reagents

Fixes champagne froth icon missing (#77389)

2023-08-06 12:03:41 -07:00

recycling

Implements usage of the REVERSE_DIR macro throughout the code. (#77122)

2023-07-28 15:16:09 +02:00

religion

Splits ballistic firearms "mag_type" into "accepted_magazine_type" and "spawn_magazine_type", fixing a few funny magazine bugs (#76973)

2023-07-25 14:42:40 -06:00

requests

…

research

Fixes DNA Infuser missing from techfab, tech storage (#77348)

2023-08-05 19:52:42 +00:00

security_levels

…

shuttle

convert the bear to a basic mobster (#77143)

2023-07-28 19:34:39 -06:00

spatial_grid

…

spells

Refactors Slaughter/Laughter Demons into Basic Mobs (#77206)

2023-07-31 19:17:46 +01:00

station_goals

…

surgery

reorganizes the human sprite folder and replaces the human_basic sprite with an updated one (#77323)

2023-08-05 14:12:05 +00:00

tgchat

…

tgs

…

tgui

[NO GBP] Actually fixing the greyscale_modify_menu. (#77208)

2023-08-01 14:39:46 -07:00

tgui_input

…

tgui_panel

…

tooltip

…

tutorials

…

unit_tests

Adds a system for logging metadata about hard deletes (#76956)

2023-08-04 14:15:00 -07:00

uplink

Fixed uplink discount stocks affecting normal uplink item stocks (#77289)

2023-08-06 00:42:55 +01:00

vehicles

Restores some mechs being able to pivot step (move and turn in the same keypress) and diagonal movement (#77345)

2023-08-05 14:41:44 +02:00

vending

Updates all the icons in under/suits.dmi and related sorting/cleanup (#76865)

2023-08-01 09:11:13 +00:00

visuals

…

wiremod

Module duplicator has cheaper costs for circuit duplication (#77180)

2023-07-30 14:22:11 -05:00

zombie

…