mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 17:52:36 +00:00
499e311a95
## About The Pull Request Basic one-person huds now default to having no AA flags set, rather than `AA_TARGET_SEE_APPEARANCE` set I thought it would be fine to let basic huds just use default hud flags without realizing the default flags were very self-defeating for this. Also also kinda dumb. Why does it default to letting the target see the hud? Whatever I guess. This fixes Valentines seeing love hearts on themselves in addition to their companion I'm surprised no one reported this. ## Changelog 🆑 Melbert fix: Valentines no longer see themselves covered in hearts. They only see their Valentine covered in hearts. /🆑
174 lines
4.9 KiB
Plaintext
174 lines
4.9 KiB
Plaintext
GLOBAL_LIST_EMPTY(active_alternate_appearances)
|
|
|
|
/atom
|
|
var/list/alternate_appearances
|
|
|
|
/atom/proc/remove_alt_appearance(key)
|
|
if(alternate_appearances)
|
|
for(var/K in alternate_appearances)
|
|
var/datum/atom_hud/alternate_appearance/AA = alternate_appearances[K]
|
|
if(AA.appearance_key == key)
|
|
AA.remove_atom_from_hud(src)
|
|
break
|
|
|
|
/atom/proc/add_alt_appearance(type, key, ...)
|
|
if(!type || !key)
|
|
return
|
|
if(alternate_appearances && alternate_appearances[key])
|
|
return
|
|
if(!ispath(type, /datum/atom_hud/alternate_appearance))
|
|
CRASH("Invalid type passed in: [type]")
|
|
|
|
var/list/arguments = args.Copy(2)
|
|
return new type(arglist(arguments))
|
|
|
|
/datum/atom_hud/alternate_appearance
|
|
var/appearance_key
|
|
var/transfer_overlays = FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/New(key)
|
|
// We use hud_icons to register our hud, so we need to do this before the parent call
|
|
appearance_key = key
|
|
hud_icons = list(appearance_key)
|
|
..()
|
|
|
|
GLOB.active_alternate_appearances += src
|
|
|
|
for(var/mob in GLOB.player_list)
|
|
if(mobShouldSee(mob))
|
|
show_to(mob)
|
|
|
|
/datum/atom_hud/alternate_appearance/Destroy()
|
|
GLOB.active_alternate_appearances -= src
|
|
return ..()
|
|
|
|
/datum/atom_hud/alternate_appearance/proc/onNewMob(mob/M)
|
|
if(mobShouldSee(M))
|
|
show_to(M)
|
|
|
|
/datum/atom_hud/alternate_appearance/proc/mobShouldSee(mob/M)
|
|
return FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/add_atom_to_hud(atom/A, image/I)
|
|
. = ..()
|
|
if(.)
|
|
LAZYINITLIST(A.alternate_appearances)
|
|
A.alternate_appearances[appearance_key] = src
|
|
|
|
/datum/atom_hud/alternate_appearance/remove_atom_from_hud(atom/A)
|
|
. = ..()
|
|
if(.)
|
|
LAZYREMOVE(A.alternate_appearances, appearance_key)
|
|
|
|
/datum/atom_hud/alternate_appearance/proc/copy_overlays(atom/other, cut_old)
|
|
return
|
|
|
|
//an alternate appearance that attaches a single image to a single atom
|
|
/datum/atom_hud/alternate_appearance/basic
|
|
var/atom/target
|
|
var/image/image
|
|
var/add_ghost_version = FALSE
|
|
var/datum/atom_hud/alternate_appearance/basic/observers/ghost_appearance
|
|
uses_global_hud_category = FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/New(key, image/I, options = AA_TARGET_SEE_APPEARANCE)
|
|
..()
|
|
transfer_overlays = options & AA_MATCH_TARGET_OVERLAYS
|
|
image = I
|
|
target = I.loc
|
|
LAZYADD(target.update_on_z, image)
|
|
if(transfer_overlays)
|
|
I.copy_overlays(target)
|
|
|
|
add_atom_to_hud(target)
|
|
target.set_hud_image_active(appearance_key, exclusive_hud = src)
|
|
|
|
if((options & AA_TARGET_SEE_APPEARANCE) && ismob(target))
|
|
show_to(target)
|
|
if(add_ghost_version)
|
|
var/image/ghost_image = image(icon = I.icon , icon_state = I.icon_state, loc = I.loc)
|
|
ghost_image.override = FALSE
|
|
ghost_image.alpha = 128
|
|
ghost_appearance = new /datum/atom_hud/alternate_appearance/basic/observers(key + "_observer", ghost_image, NONE)
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/Destroy()
|
|
. = ..()
|
|
LAZYREMOVE(target.update_on_z, image)
|
|
QDEL_NULL(image)
|
|
target = null
|
|
if(ghost_appearance)
|
|
QDEL_NULL(ghost_appearance)
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/add_atom_to_hud(atom/A)
|
|
LAZYINITLIST(A.hud_list)
|
|
A.hud_list[appearance_key] = image
|
|
. = ..()
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/remove_atom_from_hud(atom/A)
|
|
. = ..()
|
|
LAZYREMOVE(A.hud_list, appearance_key)
|
|
A.set_hud_image_inactive(appearance_key)
|
|
if(. && !QDELETED(src))
|
|
qdel(src)
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/copy_overlays(atom/other, cut_old)
|
|
image.copy_overlays(other, cut_old)
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/everyone
|
|
add_ghost_version = TRUE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/everyone/mobShouldSee(mob/M)
|
|
return !isdead(M)
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/silicons
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/silicons/mobShouldSee(mob/M)
|
|
if(issilicon(M))
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/observers
|
|
add_ghost_version = FALSE //just in case, to prevent infinite loops
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/observers/mobShouldSee(mob/M)
|
|
return isobserver(M)
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/noncult
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/noncult/mobShouldSee(mob/M)
|
|
if(!IS_CULTIST(M))
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/cult
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/cult/mobShouldSee(mob/M)
|
|
if(IS_CULTIST(M))
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/blessed_aware
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/blessed_aware/mobShouldSee(mob/M)
|
|
if(M.mind?.holy_role)
|
|
return TRUE
|
|
if (istype(M, /mob/living/basic/construct/wraith))
|
|
return TRUE
|
|
if(isrevenant(M) || IS_WIZARD(M))
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/one_person
|
|
var/mob/seer
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/one_person/mobShouldSee(mob/M)
|
|
if(M == seer)
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/one_person/New(key, image/I, options = NONE, mob/living/seer)
|
|
src.seer = seer
|
|
return ..()
|
|
|
|
/datum/atom_hud/alternate_appearance/basic/food_demands
|