Bloop f7eb3956a2 Fixes a footsteps runtime (#79903) ...

## About The Pull Request

Tin. Fixes the following runtime:


![image](https://github.com/tgstation/tgstation/assets/13398309/e4cd087f-3c6e-49f7-aaa4-2a91ca1b9a79)

Which happened because `barefoot_type` can potentially be null if
`turf.barefootstep` is null.


![Code_KnExLVOSD4](https://github.com/tgstation/tgstation/assets/13398309/1b3c97d5-500b-4d3d-a104-8dac7071fae0)

This results in trying to access `GLOB.barefootstep[null]`, which
results in a runtime, which prevents the `play_fov_effect()` from
executing.

## Why It's Good For The Game

Less CI failures, and fixes a bug.

## Changelog

🆑
fix: fixes a runtime in footstep code that would prevent the fov effect
from playing to nearby mobs
/🆑

2023-11-25 04:15:54 +01:00

..

decals

Adds a unit test to stop elements from using identical lists for their arguments. (#76322)

2023-07-27 16:04:16 -07:00

food

Fixes some fried food exploits (#79789)

2023-11-17 23:52:22 -07:00

screentips

Clarifies some silicon interactions via screentips, also converts some stuff to balloon alerts (#76690)

2023-07-12 19:29:39 -06:00

_element.dm

Adds a unit test to stop elements from using identical lists for their arguments. (#76322)

2023-07-27 16:04:16 -07:00

ai_control_examine.dm

Refactors Regenerate Organs, and a few organ helpers (#74219)

2023-03-26 17:54:36 +01:00

ai_flee_while_injured.dm

Goats will randomly attack you (#78930)

2023-10-13 00:27:21 -06:00

ai_held_item.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

ai_retaliate.dm

Unit Tests for AI Planning Subtrees not having required element/component (#77539)

2023-08-12 23:08:43 +01:00

ai_swap_combat_mode.dm

Converts traders to basic mobs (#79187)

2023-10-31 01:49:56 +00:00

ai_target_damagesource.dm

Cosmic Ascension Balance Patch (#74715)

2023-04-27 19:11:13 +01:00

amputating_limbs.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

animal_variety.dm

Convert mouse and rat to basic mobs (#70728)

2022-10-28 08:49:17 -04:00

art.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

atmos_requirements.dm

Simple and basic mobs can breath pluoxium (#76694)

2023-07-10 12:33:31 -06:00

atmos_sensitive.dm

Optimization pass focused on foam code (saves about 30% of cpu usage I think) (#76104)

2023-07-17 08:56:24 -07:00

attack_equip.dm

Completely removes do_mob and do_after_mob (#73117)

2023-02-02 21:17:20 +00:00

backblast.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

bane.dm

Assistants get a liver trait + Officer's sabre banes against them (#75933)

2023-06-10 20:17:30 -04:00

basic_body_temp_sensitive.dm

Renames delta time to be a more obvious name (#74654)

2023-04-11 21:31:07 -07:00

basic_eating.dm

Basic skeletons (#79206)

2023-10-23 23:48:22 -06:00

beauty.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

bed_tucking.dm

Renames COMSIG_ITEM_ATTACK_OBJ to COMSIG_ITEM_ATTACK_ATOM (#76112)

2023-06-18 18:48:01 +08:00

befriend_petting.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

blocks_explosives.dm

block_explosives remove remnants when detached. (#75794)

2023-06-05 04:13:40 -07:00

bombable_turf.dm

Replace wall/indestructible/destructible typepath with mapping helper (#78365)

2023-09-16 19:30:30 +02:00

bonus_damage.dm

Spider Evolution - Young Spiders [Ready] (#76692)

2023-08-09 22:38:57 +02:00

bsa_blocker.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

bugkiller_reagent.dm

Adds Roach Infusion to the DNA infuser (#76393)

2023-07-02 03:44:03 +01:00

bump_click.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

can_barricade.dm

[NO GBP] Fix barricade description element spam (#78351)

2023-09-18 19:38:46 +02:00

caseless.dm

Different pen types have unique behavior when used in foam darts. (#79587)

2023-11-21 20:34:41 -05:00

chemical_transfer.dm

Code compression for reagent holder. Lowers plumbing reaction chamber tick usage (#79686)

2023-11-16 21:44:48 +01:00

chewable.dm

Renames delta time to be a more obvious name (#74654)

2023-04-11 21:31:07 -07:00

cleaning.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

cliff_walker.dm

Adds cliffs to icebox (#77062)

2023-07-28 14:13:43 +00:00

climbable.dm

Hands management element (#78887)

2023-10-10 15:27:12 -06:00

connect_loc.dm

Adds a unit test to stop elements from using identical lists for their arguments. (#76322)

2023-07-27 16:04:16 -07:00

content_barfer.dm

Synchronise AI and Player basic mob melee behaviours (#78337)

2023-09-18 18:10:05 +02:00

crackable.dm

Converts the crackable element to mutable appearances, saves 0.15 seconds of init (#73941)

2023-03-13 16:25:40 -06:00

crusher_loot.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

cuffsnapping.dm

Removes final remnants of 'targetted' (#79626)

2023-11-11 07:46:02 -05:00

cult_eyes.dm

Save 0.6-0.7s of init time by splitting registering lists of signals into its own proc, and optimizing QDELETED (#71056)

2022-11-22 07:40:05 +00:00

cult_halo.dm

Save 0.6-0.7s of init time by splitting registering lists of signals into its own proc, and optimizing QDELETED (#71056)

2022-11-22 07:40:05 +00:00

curse_announcement.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

cursed.dm

Experiment with replacing weakrefs in AI blackboard with deleting signals, ideally making it easier to work with and harder to cause hard deletes (#74791)

2023-04-23 17:07:17 -06:00

damage_threshold.dm

Mob attackedby / check_block refactor, plus some minor cleanup of attack_x procs (#79563)

2023-11-17 19:57:51 -07:00

dangerous_surgical_removal.dm

Bargain bin organ quirks: Prosthetic organ and Tin Man (#76498)

2023-07-08 00:31:43 +01:00

death_drops.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

death_explosion.dm

Cosmic Ascension Balance Patch (#74715)

2023-04-27 19:11:13 +01:00

death_gases.dm

Cosmic Ascension Balance Patch (#74715)

2023-04-27 19:11:13 +01:00

delete_on_drop.dm

Save 0.6-0.7s of init time by splitting registering lists of signals into its own proc, and optimizing QDELETED (#71056)

2022-11-22 07:40:05 +00:00

deliver_first.dm

Pulls apart the vestiges of components still hanging onto signals (#75914)

2023-06-09 06:14:31 +00:00

dextrous.dm

Basic Guardians/Holoparasites (#79473)

2023-11-10 21:04:52 -07:00

diggable.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

digitalcamo.dm

Pulls apart the vestiges of components still hanging onto signals (#75914)

2023-06-09 06:14:31 +00:00

door_pryer.dm

Targeting Datums Renamed (and global) (#79513)

2023-11-09 14:44:24 +00:00

drag_pickup.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

dryable.dm

Removes some food initialize arguments (#78322)

2023-09-15 16:42:50 +02:00

earhealing.dm

Robotic organ and disease improvements (#76766)

2023-07-21 11:55:29 +01:00

easily_fragmented.dm

afterattack now returns a flag if it's reasonable to suspect the user intends to act on an item (#72320)

2023-01-04 21:10:41 -08:00

effect_trail.dm

transform the paper wizard from a simple to a basic (#76688)

2023-07-14 16:33:53 +01:00

ELEMENT_TEMPLATE.md

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

embed.dm

Heretic Knock Path (#78108)

2023-09-19 19:07:51 +00:00

empprotection.dm

Refactors chameleon actions, Adds chameleon outfit saving, Adds chameleon scanner (#77140)

2023-07-29 15:39:06 -06:00

envenomable_casing.dm

[NO GBP] Fixes the venomous element for projectiles, invisible arrows and something off with envenomable casings. (#76565)

2023-07-10 13:00:01 +01:00

eyestab.dm

New Medical job: The Coroner (#75065)

2023-05-05 21:31:28 -04:00

falling_hazard.dm

Refactors memories to be less painful to add and apply, moves memory detail / text to memory subtypes. Adds some new memories to demonstrate. (#72110)

2023-01-03 11:23:31 -08:00

firestacker.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

floorloving.dm

March into Mapness: Meateor (#74070)

2023-03-31 19:40:29 -07:00

footstep_override.dm

[NO GBP] Fixes catwalks over open space not making a sound when walked over. (#79738)

2023-11-15 18:31:01 -07:00

footstep.dm

Fixes a footsteps runtime (#79903)

2023-11-25 04:15:54 +01:00

forced_gravity.dm

Attempts to fix an issue with gravity generators triggering CI failures (#76764)

2023-07-19 10:10:49 +02:00

frozen.dm

March into Mapness: Meateor (#74070)

2023-03-31 19:40:29 -07:00

gags_recolorable.dm

GAGS, recolorable and actually glowing glow shoes. (#78071)

2023-09-07 14:11:32 -04:00

give_turf_traits.dm

Removes two redundant components (#76866)

2023-07-21 14:51:56 +02:00

haunted.dm

Adds hauntium as a reagent with new fun uses. (#77471)

2023-08-12 03:35:19 +02:00

high_fiver.dm

Fix Too Slowing people with high fives (#76277)

2023-06-26 22:13:22 -06:00

honkspam.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

human_biter.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

immerse.dm

Adds UPSIDE_DOWN movetype for negative gravity / makes Atrocinator affected by less things (#79785)

2023-11-20 21:19:13 +00:00

item_fov.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

item_scaling.dm

Changes signals In item_scaling to fix inventory scaling (#72696)

2023-01-21 22:04:34 -08:00

kneecapping.dm

Removes final remnants of 'targetted' (#79626)

2023-11-11 07:46:02 -05:00

kneejerk.dm

Refactors Regenerate Organs, and a few organ helpers (#74219)

2023-03-26 17:54:36 +01:00

knockback.dm

Implements usage of the REVERSE_DIR macro throughout the code. (#77122)

2023-07-28 15:16:09 +02:00

lazy_fishing_spot.dm

Miscellaneous fishing code changes. (#77739)

2023-08-21 13:41:05 +01:00

lifesteal.dm

Cleans up + Improves bows, Sorts files, Adds the Divine Archer clothing, weapon, rite (#74811)

2023-04-29 02:07:44 +00:00

light_blocking.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

light_eaten.dm

Light-Eaten objects can no longer emit light after being turned off and then back on (#79240)

2023-10-28 23:49:13 -04:00

light_eater.dm

Fix light eater affecting lava, space, openspace, and transparent turfs (#79393)

2023-11-06 21:37:44 +00:00

loomable.dm

loopable looms (#79680)

2023-11-14 13:57:52 -07:00

mirage_border.dm

Optimize mirage_border by converting it to an element and a movable (#77137)

2023-08-07 12:19:10 +01:00

mob_grabber.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

mob_killed_tally.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

move_force_on_death.dm

[no gbp] fixes not being able to walk over mook corpses and turns it all to a element (#79054)

2023-10-21 13:39:45 -04:00

movement_turf_changer.dm

Splits placeontop proc (#79702)

2023-11-19 04:58:31 +01:00

movetype_handler.dm

Save 0.6-0.7s of init time by splitting registering lists of signals into its own proc, and optimizing QDELETED (#71056)

2022-11-22 07:40:05 +00:00

nerfed_pulling.dm

More horrible 515 proc compatibility. (#71333)

2022-11-22 07:55:43 +00:00

noisy_movement.dm

Adds an element for noisy movement (wheelchairs, office chairs, trashcarts etc. etc.) (#76378)

2023-07-01 15:30:09 +01:00

noticable_organ.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

obj_regen.dm

Renames delta time to be a more obvious name (#74654)

2023-04-11 21:31:07 -07:00

openspace_item_click_handler.dm

Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse (#77786)

2023-09-19 01:06:08 +00:00

ore_collecting.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

organ_set_bonus.dm

Pulls apart the vestiges of components still hanging onto signals (#75914)

2023-06-09 06:14:31 +00:00

pet_bonus.dm

Refactors Parrots into Basic Mobs (ft. Ben10Omintrix/Kobsamobsa) (#79762)

2023-11-18 19:24:32 -08:00

plant_backfire.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

point_of_interest.dm

Remove ELEMENT_DETACH on everything that doesn't need it, rename to ELEMENT_DETACH_ON_HOST_DESTROY + a PSA (about 0.2s init time savings) (#70972)

2022-11-05 15:00:59 +01:00

prevent_attacking_of_types.dm

Basic Mob Spiders III: Sgt. Araneus is no longer a bat (#73350)

2023-02-13 05:22:26 +00:00

projectile_drop.dm

Fixing embedding for projectiles. (#77674)

2023-08-20 16:40:03 +00:00

projectile_shield.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

radiation_protected_clothing.dm

Pulls apart the vestiges of components still hanging onto signals (#75914)

2023-06-09 06:14:31 +00:00

radioactive.dm

[NO-GBP] Optimizes rad nebula (#77014)

2023-07-25 15:55:10 +02:00

ranged_armour.dm

Elementises mining mob resistance to being attacked from off screen (#76625)

2023-07-11 03:15:02 +00:00

relay_attackers.dm

Fixes Relay Attackers Misfire (#79731)

2023-11-16 14:40:38 +13:00

ridable.dm

Split weapons_and_items.dmi icons into their own categories (#74363)

2023-04-06 08:30:57 +12:00

rust.dm

Standardize Welder Fuel Usage (#76021)

2023-06-19 23:01:10 -07:00

selfknockback.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

series.dm

Pulls apart the vestiges of components still hanging onto signals (#75914)

2023-06-09 06:14:31 +00:00

shatters_when_thrown.dm

Makes shattering on throw impact an ELEMENT, anything made primarily of the glass material datum will shatter when thrown (#75303)

2023-05-13 16:33:17 -05:00

sideway_movement.dm

[NO GBP] fixes crab walking (#78648)

2023-09-28 13:42:23 -06:00

simple_flying.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

skill_reward.dm

Fixes greyscale colors not updating when changing their colors via VV, and fixes some issues with accessories (#77806)

2023-08-26 20:47:59 +02:00

skittish.dm

minor changes to living and mob vars (#77820)

2023-08-26 02:24:15 +01:00

snail_crawl.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

soft_landing.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

spooky.dm

Modifies spectral instruments to make retaliation more viable. (#74599)

2023-04-09 21:49:39 +02:00

squish.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

sticker.dm

Adds Source Count Macro (#77519)

2023-08-11 20:40:15 +02:00

strippable.dm

Fixes some heretic bugs (?) (#77611)

2023-08-28 18:59:23 +00:00

structure_repair.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

swabbable.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

temporary_atom.dm

Various spider fixes (#76528)

2023-07-05 19:26:45 -06:00

tenacious.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

tiny_mob_hunter.dm

Station Trait: Spider Infestation (#73893)

2023-03-12 18:53:38 -06:00

tool_flash.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

turf_transparency.dm

Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse (#77786)

2023-09-19 01:06:08 +00:00

undertile.dm

Invisibility refactor (#78908)

2023-10-17 13:07:31 -06:00

unfriend_attacker.dm

Dogs become tamed when given bones (#72363)

2023-01-06 12:44:39 -08:00

update_icon_blocker.dm

515 Compatibility (#71161)

2022-11-15 03:50:11 +00:00

update_icon_updates_onmob.dm

Makes update_icon_updates_onmob more robust (#75324)

2023-05-10 18:36:01 -06:00

uplink_reimburse.dm

Holo para refund fix (#78431)

2023-09-20 14:27:59 -06:00

venomous.dm

Cleans up + Improves bows, Sorts files, Adds the Divine Archer clothing, weapon, rite (#74811)

2023-04-29 02:07:44 +00:00

volatile_gas_storage.dm

Improve the naming of the element argument hash index selector (#71319)

2022-11-19 17:04:28 -08:00

waddling.dm

Basic Mob Raw Prophet (#78733)

2023-10-03 14:26:50 -06:00

wall_engraver.dm

Pulls apart the vestiges of components still hanging onto signals (#75914)

2023-06-09 06:14:31 +00:00

wall_smasher.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

wall_tearer.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

wall_walker.dm

Basic Constructs: parent type + Harvester (#78807)

2023-10-10 15:55:09 -06:00

weapon_description.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

weather_listener.dm

Shapechange health transfer tweaks (#79009)

2023-10-26 01:30:53 +00:00

web_walker.dm

Basic Mob Spiders II: Elements (#73202)

2023-02-10 12:40:31 -07:00

wheel.dm

Basic Mob Raw Prophet (#78733)

2023-10-03 14:26:50 -06:00