mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-20 22:54:46 +00:00
f8dd53d80c
* Fixes AIs having incorrect laws and being useless on nations (#74843) ## About The Pull Request Fixes #74842 So this issue is multi-part 1. Separatist antag datum used the wrong mob for applying laws to. `mob_override` is not passed usually and should default to the antag datum owner's mob if not passed Fixes this by passing the right mob. AI still doesn't get law datums, the issue is deeper - they don't even become separatists! 2. Separatists only iterates over human mobs, and not silicon mobs Okay, fixes this by iterating over all living players. Still not entirely fixed, new AIs don't have UN laws! 3. Changes the default law datum when nations executes to United Nations so new unlinked silicons gain the lawset Closer, would you believe it if this still doesn't fix everything, but going further is out of scope. Changing the round default lawset as a part of roundstart execution does not update anything that set it from atom initialize. If we wanted we could hook signals into "default lawset changed" and then update it conditionally to circumvent ALL of these issues but whatever, someone can do that later. ## Why It's Good For The Game AIs stop crying on nations ## Changelog 🆑 Melbert fix: AIs now get their proper lawset, and an objective related to said lawset, on Nations /🆑 * Fixes AIs having incorrect laws and being useless on nations --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>