mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-25 17:12:12 +00:00
* Fixes soul-stealer component being broken (#73285) ## About The Pull Request It extracted the first index soulstone from the list and tried to proc-call it. But it's a list of weakrefs, so that doesn't work. I just changed it to hard references. It didn't really need to be weakrefs, since it owned it. ## Why It's Good For The Game Useful items woo ## Changelog 🆑 Melbert fix: The bastard sword can create constructs again. Just hit the shells with it /🆑 * Fixes soul-stealer component being broken --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
69 lines
2.5 KiB
Plaintext
69 lines
2.5 KiB
Plaintext
/**
|
|
* ### Soul Stealer component!
|
|
*
|
|
* Component that attaches to items, making lethal swings with them steal the victims soul, storing it inside the item.
|
|
* Used in the cult bastard sword!
|
|
*/
|
|
/datum/component/soul_stealer
|
|
/// List of soulstones captured by this item.
|
|
var/list/obj/item/soulstone/soulstones = list()
|
|
|
|
/datum/component/soul_stealer/Initialize()
|
|
if(!isitem(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
/datum/component/soul_stealer/Destroy()
|
|
QDEL_LIST(soulstones) // We own these, so we'll also just get rid of them. Any souls inside will die, this is fine.
|
|
return ..()
|
|
|
|
/datum/component/soul_stealer/RegisterWithParent()
|
|
RegisterSignal(parent, COMSIG_PARENT_EXAMINE, PROC_REF(on_examine))
|
|
RegisterSignal(parent, COMSIG_ITEM_AFTERATTACK, PROC_REF(on_afterattack))
|
|
|
|
/datum/component/soul_stealer/UnregisterFromParent()
|
|
UnregisterSignal(parent, list(COMSIG_PARENT_EXAMINE, COMSIG_ITEM_AFTERATTACK))
|
|
|
|
///signal called on parent being examined
|
|
/datum/component/soul_stealer/proc/on_examine(datum/source, mob/user, list/examine_list)
|
|
SIGNAL_HANDLER
|
|
|
|
examine_list += span_notice("It will steal the soul of anyone it defeats in battle.")
|
|
|
|
var/num_souls = length(soulstones)
|
|
switch(num_souls)
|
|
if(0)
|
|
examine_list += span_notice("It has not consumed any souls yet.")
|
|
if(1 to 9)
|
|
examine_list += span_notice("There are <b>[num_souls]</b> souls trapped within it.")
|
|
if(10 to INFINITY)
|
|
examine_list += span_notice("A staggering <b>[num_souls]</b> souls have been claimed by it! And it hungers for more!")
|
|
|
|
/datum/component/soul_stealer/proc/on_afterattack(obj/item/source, atom/target, mob/living/user, proximity_flag, click_parameters)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!proximity_flag)
|
|
return
|
|
|
|
if(ishuman(target))
|
|
INVOKE_ASYNC(src, PROC_REF(try_capture), target, user)
|
|
|
|
if(istype(target, /obj/structure/constructshell) && length(soulstones))
|
|
var/obj/item/soulstone/soulstone = soulstones[1]
|
|
INVOKE_ASYNC(soulstone, TYPE_PROC_REF(/obj/item/soulstone, transfer_to_construct), target, user)
|
|
if(QDELETED(soulstone)) // successful transfer (transfer deletes us)
|
|
soulstones -= soulstone
|
|
else if(!length(soulstone.contents)) // something fucky happened
|
|
qdel(soulstone)
|
|
soulstones -= soulstone
|
|
|
|
|
|
/datum/component/soul_stealer/proc/try_capture(mob/living/carbon/human/victim, mob/living/captor)
|
|
if(victim.stat == CONSCIOUS)
|
|
return
|
|
var/obj/item/soulstone/soulstone = new(parent)
|
|
soulstone.attack(victim, captor)
|
|
if(!length(soulstone.contents)) // failed
|
|
qdel(soulstone)
|
|
return
|
|
soulstones += soulstone
|