mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-24 00:21:52 +00:00
ee5a40cb2b
* Minor Gravity Fixes (#74285) ## About The Pull Request Fixes forced gravity not updating a mob (trait was added too early, before hook signals are registered) Fixes spawning a mob in space not causing floats (default grav was 0, so == null was wrong) Runs shake_everyone() (Our gravity gen reaction hook) AFTER gravity changes, ensuring mobs hook into it ## Why It's Good For The Game Closes #74271 Closes #74272 (Caused by being in nograv but not floating) Closes #74274 ## Changelog 🆑 fix: Fixes a bunch of minor gravity bugs, report em if you see more yeah? /🆑 * Minor Gravity Fixes --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
42 lines
1.3 KiB
Plaintext
42 lines
1.3 KiB
Plaintext
/datum/element/forced_gravity
|
|
element_flags = ELEMENT_BESPOKE
|
|
argument_hash_start_idx = 2
|
|
///the level of gravity we force unto our target
|
|
var/gravity
|
|
///whether we will override the turf if it forces no gravity
|
|
var/ignore_turf_gravity
|
|
|
|
/datum/element/forced_gravity/Attach(datum/target, gravity = 1, ignore_turf_gravity = FALSE)
|
|
. = ..()
|
|
if(!isatom(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
|
|
src.gravity = gravity
|
|
src.ignore_turf_gravity = ignore_turf_gravity
|
|
|
|
RegisterSignal(target, COMSIG_ATOM_HAS_GRAVITY, PROC_REF(gravity_check))
|
|
if(isturf(target))
|
|
RegisterSignal(target, COMSIG_TURF_HAS_GRAVITY, PROC_REF(turf_gravity_check))
|
|
|
|
ADD_TRAIT(target, TRAIT_FORCED_GRAVITY, REF(src))
|
|
|
|
/datum/element/forced_gravity/Detach(datum/source)
|
|
. = ..()
|
|
var/static/list/signals_b_gone = list(COMSIG_ATOM_HAS_GRAVITY, COMSIG_TURF_HAS_GRAVITY)
|
|
UnregisterSignal(source, signals_b_gone)
|
|
REMOVE_TRAIT(source, TRAIT_FORCED_GRAVITY, REF(src))
|
|
|
|
/datum/element/forced_gravity/proc/gravity_check(datum/source, turf/location, list/gravs)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!ignore_turf_gravity && location.force_no_gravity)
|
|
return FALSE
|
|
gravs += gravity
|
|
|
|
return TRUE
|
|
|
|
/datum/element/forced_gravity/proc/turf_gravity_check(datum/source, atom/checker, list/gravs)
|
|
SIGNAL_HANDLER
|
|
|
|
return gravity_check(null, source, gravs)
|