mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-29 02:51:41 +00:00
f141a04600
* Fix pre-round lobby map vote filter (#73820) ## About The Pull Request Fixes https://github.com/tgstation/tgstation/issues/73816 ## Changelog 🆑 LT3 fix: Map filter works properly in the pre-round lobby fix: Map vote doesn't log 'not enough players' if the vote starts in the pre-round lobby /🆑 --------- Co-authored-by: tattle <66640614+dragomagol@ users.noreply.github.com> * Fix pre-round lobby map vote filter --------- Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com> Co-authored-by: tattle <66640614+dragomagol@ users.noreply.github.com>
121 lines
4.4 KiB
Plaintext
121 lines
4.4 KiB
Plaintext
/datum/vote/map_vote
|
|
name = "Map"
|
|
message = "Vote for next round's map!"
|
|
count_method = VOTE_COUNT_METHOD_MULTI
|
|
|
|
/datum/vote/map_vote/New()
|
|
. = ..()
|
|
|
|
default_choices = list()
|
|
|
|
// Fill in our default choices with all of the maps in our map config, if they are votable and not blocked.
|
|
var/list/maps = shuffle(global.config.maplist)
|
|
for(var/map in maps)
|
|
var/datum/map_config/possible_config = config.maplist[map]
|
|
if(!possible_config.votable || (possible_config.map_name in SSpersistence.blocked_maps) || possible_config.map_name == SSmapping.config?.map_name) // SKYRAT EDIT - Can't vote for the current map
|
|
continue
|
|
|
|
default_choices += possible_config.map_name
|
|
|
|
/datum/vote/map_vote/create_vote()
|
|
. = ..()
|
|
check_population(should_key_choices = FALSE)
|
|
if((length(choices) == 1) && EMERGENCY_ESCAPED_OR_ENDGAMED) // Only one choice, no need to vote. Let's just auto-rotate it to the only remaining map because it would just happen anyways.
|
|
var/de_facto_winner = choices[1]
|
|
var/datum/map_config/change_me_out = global.config.maplist[de_facto_winner]
|
|
SSmapping.changemap(change_me_out)
|
|
to_chat(world, span_boldannounce("The map vote has been skipped because there is only one map left to vote for. The map has been changed to [change_me_out.map_name]."))
|
|
SSmapping.map_voted = TRUE // voted by not voting, very sad.
|
|
return FALSE
|
|
|
|
/datum/vote/map_vote/toggle_votable(mob/toggler)
|
|
if(!toggler)
|
|
CRASH("[type] wasn't passed a \"toggler\" mob to toggle_votable.")
|
|
if(!check_rights_for(toggler.client, R_ADMIN))
|
|
return FALSE
|
|
|
|
CONFIG_SET(flag/allow_vote_map, !CONFIG_GET(flag/allow_vote_map))
|
|
return TRUE
|
|
|
|
/datum/vote/map_vote/is_config_enabled()
|
|
return CONFIG_GET(flag/allow_vote_map)
|
|
|
|
/datum/vote/map_vote/can_be_initiated(mob/by_who, forced = FALSE)
|
|
. = ..()
|
|
if(!.)
|
|
return FALSE
|
|
|
|
if(forced)
|
|
return TRUE
|
|
|
|
var/number_of_choices = length(check_population())
|
|
if(number_of_choices < 2)
|
|
message = "There [number_of_choices == 1 ? "is only one map" : "are no maps"] to choose from."
|
|
return FALSE
|
|
|
|
if(SSmapping.map_vote_rocked)
|
|
return TRUE
|
|
|
|
if(!CONFIG_GET(flag/allow_vote_map))
|
|
message = "Map voting is disabled by server configuration settings."
|
|
return FALSE
|
|
|
|
if(SSmapping.map_voted)
|
|
message = "The next map has already been selected."
|
|
return FALSE
|
|
|
|
message = initial(message)
|
|
return TRUE
|
|
|
|
/// Before we create a vote, remove all maps from our choices that are outside of our population range.
|
|
/// Note that this can result in zero remaining choices for our vote, which is not ideal (but ultimately okay).
|
|
/// Argument should_key_choices is TRUE, pass as FALSE in a context where choices are already keyed in a list.
|
|
/datum/vote/map_vote/proc/check_population(should_key_choices = TRUE)
|
|
if(should_key_choices)
|
|
for(var/key in default_choices)
|
|
choices[key] = 0
|
|
|
|
var/filter_threshold = 0
|
|
if(SSticker.HasRoundStarted())
|
|
filter_threshold = get_active_player_count(alive_check = FALSE, afk_check = TRUE, human_check = FALSE)
|
|
else
|
|
filter_threshold = GLOB.clients.len
|
|
|
|
for(var/map in choices)
|
|
var/datum/map_config/possible_config = config.maplist[map]
|
|
if(possible_config.config_min_users > 0 && filter_threshold < possible_config.config_min_users)
|
|
choices -= map
|
|
|
|
else if(possible_config.config_max_users > 0 && filter_threshold > possible_config.config_max_users)
|
|
choices -= map
|
|
|
|
return choices
|
|
|
|
/datum/vote/map_vote/get_vote_result(list/non_voters)
|
|
// Even if we have default no vote off,
|
|
// if our default map is null for some reason, we shouldn't continue
|
|
if(CONFIG_GET(flag/default_no_vote) || isnull(global.config.defaultmap))
|
|
return ..()
|
|
|
|
for(var/non_voter_ckey in non_voters)
|
|
var/client/non_voter_client = non_voters[non_voter_ckey]
|
|
// Non-voters will have their preferred map voted for automatically.
|
|
var/their_preferred_map = non_voter_client?.prefs.read_preference(/datum/preference/choiced/preferred_map)
|
|
// If the non-voter's preferred map is null for some reason, we just use the default map.
|
|
var/voting_for = their_preferred_map || global.config.defaultmap.map_name
|
|
|
|
if(voting_for in choices)
|
|
choices[voting_for] += 1
|
|
|
|
return ..()
|
|
|
|
/datum/vote/map_vote/finalize_vote(winning_option)
|
|
var/datum/map_config/winning_map = global.config.maplist[winning_option]
|
|
if(!istype(winning_map))
|
|
CRASH("[type] wasn't passed a valid winning map choice. (Got: [winning_option || "null"] - [winning_map || "null"])")
|
|
|
|
SSmapping.changemap(winning_map)
|
|
SSmapping.map_voted = TRUE
|
|
if(SSmapping.map_vote_rocked)
|
|
SSmapping.map_vote_rocked = FALSE
|