mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-17 21:24:01 +00:00
* Mafia victory and QOL Update (#74974) ## About The Pull Request HoP is now a killing role as they theoretically can solo-kill through voting. Changelings also have can kill flag, even if it's useless for them, just in-case. Removes check_total_victory and block_team_victory from Neutrals, since it was just snowflake code. I instead reworked all of how victory is calculated. Ghosts can no longer see Mafia chat, because I'd like to integrate dead players into the round in the future, and ghosts knowing who the evils are is lame. It's a deduction minigame, you're supposed to deduct who the bad guys are. ### QoL stuff - Adds maptext for voting periods so people know who you are voting for. https://cdn.discordapp.com/attachments/326831214667235328/1097781395369246740/2023-04-18_03-09-12.mp4 - Adds a popup when someone is voted up, instead of being a big box of text in your chat. This will help clog the chat less and make it easier for players to understand what to do when the time comes. https://cdn.discordapp.com/attachments/326831214667235328/1097770854005350481/2023-04-18_02-28-31.mp4 Lastly, converts Mafia panel to typescript ## Why It's Good For The Game This should be the last of my Mafia reworks, hopefully. This makes the game's victory calculated to ensure there's always a chance anytime possible, while letting kingmaker scenarios exist. Additionally, we shouldn't expect players to know how Mafia works because we don't expect them to already have some background in Mafia games, or have played Mafia before. ## Changelog 🆑 qol: [Mafia] Players get a popup when a player is voted to the stand. qol: [Mafia] Players now have the name of who they voted for displayed over their heads during voting period. balance: [Mafia] Deadchat can no longer see Mafia chat. balance: [Mafia] HoP can now solo-win. /🆑 * Mafia victory and QOL Update --------- Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>