mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-18 05:32:58 +00:00
fcacccc459
* Fixes bypassing integrated circuit cooldowns with module components. (#75581) ## About The Pull Request See title. In order for this change to work, these components will not work if there is no shell, but this will change nothing user-facing because all player-facing circuits require shells to function in the first place anyways. ## Why It's Good For The Game Fixes a cooldown bypass bug. Closes #75580 ## Changelog 🆑 fix: Fixed bypassing component cooldowns with module components. /🆑 --------- Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com> * Fixes bypassing integrated circuit cooldowns with module components. --------- Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
73 lines
2.2 KiB
Plaintext
73 lines
2.2 KiB
Plaintext
/**
|
|
* # View Sensor
|
|
*
|
|
* Returns all movable objects in view.
|
|
*/
|
|
|
|
/obj/item/circuit_component/view_sensor
|
|
display_name = "View Sensor"
|
|
desc = "Outputs a list with all movable objects in it's view. Requires a shell. Max range of 5 tiles."
|
|
category = "Sensor"
|
|
|
|
circuit_flags = CIRCUIT_FLAG_INPUT_SIGNAL|CIRCUIT_FLAG_OUTPUT_SIGNAL
|
|
|
|
power_usage_per_input = 10 //Normal components have 1
|
|
|
|
///Allows setting the range of the view sensor
|
|
var/datum/port/input/range
|
|
|
|
/// The result from the output
|
|
var/datum/port/output/result
|
|
var/datum/port/output/cooldown
|
|
|
|
var/see_invisible = SEE_INVISIBLE_LIVING
|
|
var/view_cooldown = 1 SECONDS
|
|
var/maximum_range = 5 //Variablised incase admins want to increase it.
|
|
|
|
/obj/item/circuit_component/view_sensor/populate_ports()
|
|
range = add_input_port("Range", PORT_TYPE_NUMBER, default = maximum_range)
|
|
result = add_output_port("Result", PORT_TYPE_LIST(PORT_TYPE_ATOM))
|
|
cooldown = add_output_port("Scan On Cooldown", PORT_TYPE_SIGNAL)
|
|
|
|
/obj/item/circuit_component/view_sensor/get_ui_notices()
|
|
. = ..()
|
|
. += create_ui_notice("Scan Cooldown: [DisplayTimeText(view_cooldown)]", "orange", "stopwatch")
|
|
|
|
/obj/item/circuit_component/view_sensor/input_received(datum/port/input/port)
|
|
if(!parent.shell)
|
|
return
|
|
|
|
if(TIMER_COOLDOWN_CHECK(parent.shell, COOLDOWN_CIRCUIT_VIEW_SENSOR))
|
|
result.set_output(null)
|
|
cooldown.set_output(COMPONENT_SIGNAL)
|
|
return
|
|
|
|
if(!parent || !parent.shell)
|
|
result.set_output(null)
|
|
return
|
|
|
|
if(!isturf(parent.shell.loc))
|
|
if(isliving(parent.shell.loc))
|
|
var/mob/living/owner = parent.shell.loc
|
|
if(parent.shell != owner.get_active_held_item() && parent.shell != owner.get_inactive_held_item())
|
|
result.set_output(null)
|
|
return
|
|
else
|
|
result.set_output(null)
|
|
return
|
|
|
|
var/range_value = clamp(range.value, 0, maximum_range)
|
|
var/object_list = list()
|
|
|
|
for(var/atom/movable/target in view(range_value, get_turf(parent.shell)))
|
|
if(target.mouse_opacity == MOUSE_OPACITY_TRANSPARENT)
|
|
continue
|
|
if(target.invisibility > see_invisible)
|
|
continue
|
|
if(target.IsObscured())
|
|
continue
|
|
object_list += target
|
|
|
|
result.set_output(object_list)
|
|
TIMER_COOLDOWN_START(parent.shell, COOLDOWN_CIRCUIT_VIEW_SENSOR, view_cooldown)
|