Ports export reports (#5051)

* Ports export reports

* Absolute pathing, small touchups

code/game/machinery/computer/supply.dm

@@ -40,6 +40,7 @@
 		<BR>\n<A href='?src=\ref[src];order=categories'>Request items</A><BR><BR>
 		<A href='?src=\ref[src];vieworders=1'>View approved orders</A><BR><BR>
 		<A href='?src=\ref[src];viewrequests=1'>View requests</A><BR><BR>
+		\n<A href='?src=\ref[src];viewexport=1'>View export report</A><BR><BR>
 		<A href='?src=\ref[user];mach_close=computer'>Close</A>"}
 
 	user << browse(dat, "window=computer;size=575x450")
@@ -198,6 +199,7 @@
 		\n<A href='?src=\ref[src];order=categories'>Order items</A><BR>\n<BR>
 		\n<A href='?src=\ref[src];viewrequests=1'>View requests</A><BR>\n<BR>
 		\n<A href='?src=\ref[src];vieworders=1'>View orders</A><BR>\n<BR>
+		\n<A href='?src=\ref[src];viewexport=1'>View export report</A><BR>\n<BR>
 		\n<A href='?src=\ref[user];mach_close=computer'>Close</A>"}
 
 
@@ -367,6 +369,18 @@
 		temp += "<BR><A href='?src=\ref[src];clearreq=1'>Clear list</A>"
 		temp += "<BR><A href='?src=\ref[src];mainmenu=1'>OK</A>"
 
+	else if (href_list["viewexport"])
+		temp = "Previous shuttle export report: <BR><BR>"
+		var/cratecount = 0
+		var/totalvalue = 0
+		for(var/S in supply_controller.exported_crates)
+			var/datum/exported_crate/EC = S
+			cratecount += 1
+			totalvalue += EC.value
+			temp += "[EC.name] exported for [EC.value] supply points<BR>"
+		temp += "<BR>Shipment of [cratecount] crates exported for [totalvalue] supply points.<BR>"
+		temp += "<BR><A href='?src=\ref[src];mainmenu=1'>OK</A>"
+
 	else if (href_list["rreq"])
 		var/ordernum = text2num(href_list["rreq"])
 		temp = "Invalid Request.<BR>"

code/game/supplyshuttle.dm

@@ -105,16 +105,15 @@ var/list/mechtoys = list(
 	name = "airtight plastic flaps"
 	desc = "Heavy duty, airtight, plastic flaps."
 
-    New() //set the turf below the flaps to block air
+/obj/structure/plasticflaps/mining/New() //set the turf below the flaps to block air
 	var/turf/T = get_turf(loc)
 	if(T)
 		T.blocks_air = 1
 	..()
 
-    Destroy() //lazy hack to set the turf to allow air to pass if it's a simulated floor
+/obj/structure/plasticflaps/mining/Destroy() //lazy hack to set the turf to allow air to pass if it's a simulated floor
 	var/turf/T = get_turf(loc)
-        if(T)
+	if(T && istype(T, /turf/simulated/floor))
-            if(istype(T, /turf/simulated/floor))
 		T.blocks_air = 0
 	..()
 
@@ -134,6 +133,10 @@ var/list/mechtoys = list(
 	var/orderedby = null
 	var/comment = null
 
+/datum/exported_crate
+	var/name
+	var/value
+
 /datum/controller/supply
 	//supply points
 	var/points = 50
@@ -147,11 +150,12 @@ var/list/mechtoys = list(
 	var/list/shoppinglist = list()
 	var/list/requestlist = list()
 	var/list/supply_packs = list()
+	var/list/exported_crates = list()
 	//shuttle movement
 	var/movetime = 1200
 	var/datum/shuttle/ferry/supply/shuttle
 
-    New()
+/datum/controller/supply/New()
 	ordernum = rand(1,9000)
 
 	for(var/typepath in (typesof(/datum/supply_packs) - /datum/supply_packs))
@@ -160,12 +164,12 @@ var/list/mechtoys = list(
 
 // Supply shuttle ticker - handles supply point regeneration
 // This is called by the process scheduler every thirty seconds
-    proc/process()
+/datum/controller/supply/proc/process()
 	points += points_per_process
 
 //To stop things being sent to CentCom which should not be sent to centcomm. Recursively checks for these types.
-    proc/forbidden_atoms_check(atom/A)
+/datum/controller/supply/proc/forbidden_atoms_check(atom/A)
-        if(istype(A,/mob/living))
+	if(isliving(A))
 		return 1
 	if(istype(A,/obj/item/weapon/disk/nuclear))
 		return 1
@@ -180,7 +184,7 @@ var/list/mechtoys = list(
 			return 1
 
 //Sellin
-    proc/sell()
+/datum/controller/supply/proc/sell()
 	var/area/area_shuttle = shuttle.get_location_area()
 	if(!area_shuttle)   return
 
@@ -190,11 +194,18 @@ var/list/mechtoys = list(
 	var/plat_count = 0
 	var/money_count = 0
 
+	exported_crates = list()
+
 	for(var/atom/movable/MA in area_shuttle)
 		if(MA.anchored) continue
 
 		// Must be in a crate!
 		if(istype(MA,/obj/structure/closet/crate))
+			var/oldpoints = points
+			var/oldphoron = phoron_count
+			var/oldplatinum = plat_count
+			var/oldmoney = money_count
+
 			var/obj/structure/closet/crate/CR = MA
 			callHook("sell_crate", list(CR, area_shuttle))
 
@@ -222,30 +233,37 @@ var/list/mechtoys = list(
 				if(istype(A, /obj/item/weapon/spacecash))
 					var/obj/item/weapon/spacecash/cashmoney = A
 					money_count += cashmoney.worth
+
+			var/datum/exported_crate/EC = new /datum/exported_crate()
+			EC.name = CR.name
+			EC.value = points - oldpoints
+			EC.value += (phoron_count - oldphoron) * points_per_phoron
+			EC.value += (plat_count - oldplatinum) * points_per_platinum
+			EC.value += (money_count - oldmoney) * points_per_money
+			exported_crates += EC
+
 		qdel(MA)
 
-        if(phoron_count)
 	points += phoron_count * points_per_phoron
-
-        if(plat_count)
 	points += plat_count * points_per_platinum
-
-        if(money_count)
 	points += money_count * points_per_money
 
 //Buyin
-    proc/buy()
+/datum/controller/supply/proc/buy()
-        if(!shoppinglist.len) return
+	if(!shoppinglist.len) 
+		return
 
 	var/orderedamount = shoppinglist.len
 
 	var/area/area_shuttle = shuttle.get_location_area()
-        if(!area_shuttle)   return
+	if(!area_shuttle)   
+		return
 
 	var/list/clear_turfs = list()
 
 	for(var/turf/T in area_shuttle)
-            if(T.density)   continue
+		if(T.density)
+			continue
 		var/contcount
 		for(var/atom/A in T.contents)
 			if(!A.simulated)
@@ -269,7 +287,6 @@ var/list/mechtoys = list(
 		A.name = "[SP.containername] [SO.comment ? "([SO.comment])":"" ]"
 
 		//supply manifest generation begin
-
 		var/obj/item/weapon/paper/manifest/slip
 		if(!SP.contraband)
 			slip = new /obj/item/weapon/paper/manifest(A)
@@ -288,7 +305,7 @@ var/list/mechtoys = list(
 				var/list/L = SP.access // access var is a plain var, we need a list
 				A.req_access = L.Copy()
 			else
-                    world << "<span class='danger'>Supply pack with invalid access restriction [SP.access] encountered!</span>"
+				log_debug("<span class='danger'>Supply pack with invalid access restriction [SP.access] encountered!</span>")
 
 		var/list/contains
 		if(istype(SP,/datum/supply_packs/randomised))