protean blobs can now grab/disarm people again
you can now buckle to proteans again (since they can't ventcrawl)
they can now go through plastic flaps and over tables like promethean
blobs
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
A few fixes ran into messing around with the code, every logical unit is
one commit.
## Why It's Good For The Game
People aren't unable to escape some storage, but not other. (Logic wise,
that probably could be handed further to the object, to have people not
escape something like locked secure briefcases or so, but this is just a
quick fix.)
Vore resisting works again, besides slightly less special logic for it.
Augment cooldown actually works, besides splitting the usability check
from the action proc, less duplication
Fancy boxes don't get/spawn invisible.
Runtime fix for the resonate analyzer (available as augment implant),
technically usable.
Plant analyzer doesn't seem to be bigger than the others, so put into
the same size/weightclass
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: Able to escape every storage
fix: vore resist belly interactions
fix: augment cooldowns
fix: Cigar, chocolate, and crayon/marker/chalk boxes don't become
(partly) invisible
fix: resonate analyzer can be used
tweak: plant analyzer is now small
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: MarsMond <no@email>
Co-authored-by: Blubelle <57083662+BlueWildrose@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Gives people the option to be directed by someone buckled to them.
Offset gets handled nicer now, resize affects the riding offset, taurs
actually have their center set to it, and not their tail end if 200%, or
infront of them if 25% size.
The code to saddle up actual horses, shanks, and stormdrifter bulls is
fixed, too, as it didn't switch the riding handler, which didn't get
deleted, and such not switching to the controllable part.
A few typos got fixed, stumbled by typoing my own search for the 3 mobs
for their var.
Small rendering tweak to potentially draw bags ontop of tails (required
for saddlebags.)
Saddlebags now include the saddle option, and such makes it easier for
one to hold onto
## Why It's Good For The Game
People do look more like they are carried by the person they are buckled
to. The new option could allow some RP options, synth having a
controller or being just directed by holding some part of the body, or
maybe way to put the jousting compontent to use? The bucking gives an
option to remove someone riding one, as one otherwise has no control
over it. The saddlebag also even works as a saddle now, although that
can be removed if the freeded up hand is deemed too strong.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: taurs actually get their center calculated correctly, noticeable if
buckled sideways.
tweak: offsets get resized for riding.
fix: horse, shank, stomrdrifter bull saddeling
fix: taur bags actually get drawn over the taur body
add: ability to buck someone off your back
tweak: no riding hand needed if the taur is wearing a saddle.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: MarsMond <no@email>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
as title
## Why It's Good For The Game
"you can't fireman carry someone who's handcuffed" - words of the
utterly deranged
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: You can now fireman carry incapacitated people--you know, the ones
fireman carry was designed for
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
adds variable timing schedulers
adds core AI holder abstraction and services
kicks current AI to /polaris and shims everything; reconcilation will
come later.
DCS now registers based on its registered type, as opposed to at every
subtype.
Dupe mode is no longer considered realistically usable unless
if-and-only-if all var pre-setting behavior is considered - which is not
the case on the majority of citrp-made components outside of
/datum/component/radioactive
## Why?
Components are a generic way to attach datums to things.
The common practices included:
- No getcomponent
- Use signals for all interaction
- Don't subtype, set vars on initialization
This resulted in components, while being quite stable, being also quite
rigid, in my opinion. Given we don't use components for the same things,
and probably never will, I think it's better for us to get the
optimizations from not supporting what's honestly behavior that we
shouldn't rely on in the first place - if something needs to be applied
multiple times (e.g. radiation) it should rely on the old behavior and
this new system still allows it. If it doesn't, the author should either
not be adding the component multiple times, or **making** their
component functional under this system. InheritComponent still has all
the tools necessary to properly do component inheritance, it's just now
we default to all components only being considered the same if it's the
exact subtype - which from what I could see, is also the previous case
(as if you add a subtype, uh, bad shit's going to happen if the base
type is registered but not the subtype anyways!)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
**Mobs:**
1. **Adds the Shank.**
2. **Adds the Stormdrifter.**
3. **Goliaths can now be milked for gunpowder.**
**Structures:**
1. **Adds Ashlander Structures: Magma Forge and Brick Press.**
2. **Adds Ashlander Catwalks.**
3. **Adds Goliath Hide curtains.**
4. **Adds a Tying Post.**
**Map Edits:**
1. **Removes the Harmony colony.**
2. **Removes Ashlander Camp.**
3. **Adds Ashlander Village.**
**Adjustments/Changes:**
1. **Tweaks Bone Axes and Spears.**
2. **Restricts Tribal Recipes.**
3. **Rearranges Ashlander structures and icons into bespoke files.**
4. **Beakers can now scoop ash piles off the ground.**
5. **Shows Reagents in Stone Mortars on Examine.**
6. **Creates Preset Types for Bone Tables/Benches & Sandstone
Tables/Benches.**
7. **Wood Fences are now craftable with planks.**
8. **Boosts Ashlander Darksight.**
9. **Changes the lid colors of Ashlander containers.**
10. **Gives Ashlanders a Dedicated Language.**
**Alchemy:**
1. **Adds a craftable Ashlander Alchemy Station.**
2. **Adds a craftable stone mortar.**
3. **Creates New Reagent: "Alchemical Base"**
4. **Adds a Fertilizer recipe.**
5. **Adds an Alternate Tallow recipe.**
6. **Adds a Soap recipe.**
7. **Adds a Charcoal Stick recipe.**
8. **Adds a craftable Calcinator.**
9. **Adds the Industrial Plant Cersut.**
10. **Creates a craftable Stone Dropper.**
11. **Adds Juhtak Poultice recipe.**
12. **Adds Pyrrhlea Poultice recipe.**
**Craftables/Content:**
1. **Creates Craftable Saddles.**
2. **Adds Sandstone Flooring.**
3. **Adds Wooden Roofing.**
4. **Adds the craftable lava-proof boat and oar.**
5. **Adds elder stones and a harvestable outcrop.**
6. **Adds Charcoal Sticks - a pen subtype.**
7. **Adds craftable Sandstone jars.**
8. **Adds craftable Cooking Spit.**
9. **Adds primitive Soap.**
10. **Adds Goliath hide gloves.**
11. **Adds Goliath hide ore bags.**
12. **Adds bone specific arrow recipes for Ashlanders.**
13. **Provides specialized armor for Ashlanders.**
14. **Adds Bone Talisman (Disenchanted) to Loadout.**
15. **Adds Goliath half-cloak.**
18. **Adds Goliath plant bag.**
**Weaponry:**
1. **Adds the Stun Lance.**
2. **Removes Firing Pins from Muskets.**
3. **Adds the Bone Sword and Elder Bone Sword.**
4. **Adds Shiv Knife.**
5. **Removes Musket safety.**
6. **Removes the safety from bows.**
## Why It's Good For The Game
**Mobs:**
1. _Gutshanks can now be matured into Shanks, which serve as mounts for
Ashlanders. If a Shank has a saddle on it, you can set its name/rename
it with a charcoal stick._
2. _Stormdrifters are floating mobs who wander the Eastern Plains
aimlessly, having been blown off-course by storms. They likely have some
kind of utility._
3. _Goliaths eat lots of sulfur and saltpeter-rich rocks and sand, and
now canonically create gunpowder as a waste byproduct. This can now be
collected by Ashlanders to replenish musket reserves._
**Structures:**
1. _Ashlanders need a way to generate rods to create flooring for their
structures, and also a way to access lead sheets to make musket balls.
The Magma Forge creates rods when fed iron ore, lead ingots when fed
lead ore, copper ingots when fed copper ore, and slag when fed sand. To
encourage more thematic construction, Ashlanders can use a Brick Press
to create sandstone bricks when they feed it sand._
2. _I wanted a bridge/catwalk system for Ashlanders, and this is what I
came up with._
3. _Instead of heavy stone doors and stuff, I thought goliath hide
curtains would be pretty nifty. So we've got those now!_
4. _This craftable bone tying post allows you to anchor your mount in
one spot, just like in the Wild West!_
**Map Edits:**
1. _As much as I love Harmony, it has served its narrative purpose.
Instead of extending Lavaland with another Z-Level, as I planned a while
back, I'm going to instead remap East to be the new Ashlander spawn
zone._
2. _The exile POI for Ashlanders no longer serves purpose._
3. _It is instead replaced by this village!_
**Adjustments/Changes:**
1. _Bone axes and spears now use their bespoke sprites, instead of
material inheritance sprites._
2. _To craft Tribal recipes, you must now be an Ashlander. This should
encourage more commercial trade between Ashlanders and station crew._
3. _I had to create a new file and icon sheet for Ashlander specific
structures. I have moved the primitive seed press and the yurt to this
file, and adjusted the relevant areas in code._
4. _I was surprised to discover this function didn't exist. It seems
obvious that you should be able to sweep ash up. Most people don't even
realize ash is a valid reagent type. Now it can be utilized somewhere,
hopefully! Besides just me, I mean._
5. _There have been complaints about the confusion around stone mortar
contents on Surt. The ability to see reagents in a beaker used to exist,
but appears to have been removed somewhere. It was a pain, but I figured
out how to restore it for stone mortars. Now Ashlanders can safely know
whether they're about to drink water or gunpowder._
6. _I just wanted these so I could map them in to replace most of the
wood in the Ashlander village._
7. _I've seen some pretty weird fencing solutions for when the Ashlander
corral breaks. I'm debating a bone-based fence for it, but in lieu of
that, these should be craftable anyways._
8. _Originally I had this set to 5. It turns out 5 was too low. Even 7
feels a little inadequate. I'm considering other solutions._
9. _To match with more bone and less wood, these should be changed!_
10. _Apparently I was using an Admin event language all along. Now they
have a language of their own!_
**Alchemy:**
1. _I know there isn't like, a super obvious utility for this yet, but
it feels like something that might be useful later. Maybe for advanced
Ashlander medicines like poultices or something. Maybe a Phase 4 thing._
2. _The stone mortar functions as a beaker, and can be used to contain
reagents for Ashlanders, such as gunpowder._
3. _This chemical serves as the core reagent in Ashlander alchemical
recipes. It helps to prevent overlap in recipes considering the limited
number of reagents Ashlanders have access to. It can be crafted by
combining ash and sulphuric acid._
4. _Ashlander players have also requested access to fertilizer. Although
you can grind up plants currently to provide plots with nutrients,
giving the players access to a baseline fertilizer recipe (which I was
surprised to see didn't exist/doesn't exist in a way Ashlanders can
fairly access) works too. It can be crafted by combining equal parts
tallow, ash, and alchemical base._
5. _Tallow is vital for a couple of my early concept alchemical
formulas. It also serves to add additional utility to raw meat which
might otherwise go unused. I designed this alternate recipe to require
little more than grinding meat down into its components. It can be
crafted by combining equal parts triglyceride, protein, and alchemical
base._
6. _Butchering animals is dirty work. There have been multiple requests
for a way to wash dirty items. Unfortunately, providing Ashlanders with
a puddle of water or other water-based vectors would undermine the
purpose of farming Gutshanks. However, primitive cultures knew about
soap and how to create it. It can be crafted by combining equal parts
tallow, water, and ash._
7. _That Charcoal has to be made somewhere! It can be crafted by
combining equal parts tallow, ash, and alchemical base._
8. _In alchemy, Calcinators are used to reduce ingredients to ash and
release their interior potential. This is a fancy way of saying you burn
stuff into ash. This machine was a total headache to me, and took up the
majority of my code work on this particular day. It's essentially a
bastard child of the reagent grinder designed to burn wood or bone (only
bone really matters for Ashlanders), and pump out ash for use in
recipes._
9. _The eagle eyed may have noticed earlier that Alchemical Base
requires sulphuric acid to craft. This is possible due to the addition
of Cersut. This leafy plant leeches Sulphur out of the soil, which is
processed through its body. Consequently, the leaves retain a
significant amount of sulphuric acid. Cersut is not designed for any
form of consumption. It is purely an industrial plant._
10. _I've discovered that due to some uneven production results, you can
get some total nightmare situations with Ashlander beakers. I've
considered adding some kind of chem master to allow for faster
refinement, but I mean. Where's the fun in that?_
11. _This poultice can be used to heal brute damage in a more focused
way. Made by mixing ten parts alchemy base with ten parts bicaridine._
12. _As the above, but used to heal burn damage. Made by mixing ten
parts alchemy base and ten parts kelotane._
**Craftables/Content:**
1. _Saddles allow you to ride Shanks when crafted and applied._
2. _Now Ashlanders can construct interior floors out of sandstone._
3. _Now we can have wood roofs, instead of just steel ones. This is
basically a fluff addition._
4. _The current redesign for Lavaland East has a lot of lava rivers and
stuff going on. It'd be nice if Ashlanders had special boats to sail
over it with._
5. _Older Lavaland recipes for certain tools required Cultist soul
stones. Obviously on Main this makes sense, but less so here. So I've
created Elder Stones, slightly anomalous gems that can be found in
special outcrops. I've come up with some lore for these, but it doesn't
belong here. They're used in recipes for things like lava-proof boats,
Ashlander welders, and Elder Swords, all of which are meant to be rare._
6. _Originally I had this concept of Ashlanders using charcoal sticks to
draw pictures and stuff, but I realized it would just lead to graffiti
and English letters all over my sand. So instead I've made them
primitive pens with no vector for paper, etc. They can be used to label
stone mortars, and feature in at least one crafting recipe._
7. _Since there's no wood on Surt, wood buckets don't make sense. Now
Ashlanders can craft sandstone jars - which function as buckets - in
their stead._
8. _The people have cried out for a way to cook food. I've made this
grill subtype that's just a spit over fire. Originally I was going to
make it require charcoal sticks as fuel to consume, but I think that'd
just add tedium (and I kinda don't wanna code it.)_
9. _It's ugly and it doesn't smell fancy, but it sure cleans stuff up._
10. _Fashion and utility! These gloves will protect you from stinging
nettles when farming._
11. _Picking up ore one at a time is kinda lame at this point._
12. _Since there's no way for Ashlanders to reliably get wood, I've made
it so they can craft arrows just using bone._
13. _Ashlanders have been using borrowed Gladiator uniforms for a while.
Now they have Babylonian style lamellar armor._
14. _Disenchanted bone talismans may now be selected in the accessory
loadout, at the request of players who have received them as gifts from
Ashlanders._
15. _This is purely an aesthetic/style addition._
16. _Adds Plant Bags for Ashlanders._
**Weaponry:**
1. _Designed to work in tandem with jousting, Stun Lances are more of a
tool for flavor._
2. _Muskets are ancient, primitive tech. They wouldn't use firing pins._
3. _As with the above, mechanical safeties didn't exist for
decades/centuries after muskets._
4. _Bone swords are neat! Elder Bone Swords were a recommendation by
someone, but I really loved the concept. Both are craftable, although
the Elder requires advanced (for Ashlanders) materials._
5. _I'm already touching the misc weapons file and someone suggested a
cheap shiv made of duct tape and knife blades. Sounded fun._
6. _Bows shouldn't have safeties._
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Adds the Shank.
add: Adds craftable saddles.
add: Adds craftable stone mortar.
add: Adds gunpowder milking feature to Goliaths.
add: Adds Stun Lance.
add: Adds Ashlander crafting structures (Magma Forge and Brick Press)
add: Adds Ashlander alchemy station.
add: Adds sandstone flooring.
add: Adds wooden roofing.
add: Adds the bone sword and elder bone sword.
add: Adds lava-proof boats.
add: Adds elder stones.
add: Adds Ashlander catwalks.
add: Adds Ashlander Village to Lavaland East.
add: Adds a shiv.
add: Adds Goliath hide curtains.
add: Adds alchemical system.
add: Adds alchemical recipes: alchemical base, fertilizer, tallow, soap,
charcoal sticks.
add: Adds Calcinator.
add: Adds industrial plant 'Cersut'.
add: Adds primitive soap and charcoal stick pens.
add: Adds sandstone jars.
add: Adds cooking spit.
add: Adds stone dropper.
add: Adds preset bone & sandstone tables and benches.
del: Removes Harmony colony.
del: Removes Ashlander Exile POI.
tweak: Removes firing pin requirement for muskets.
tweak: Changes Bone Axe and Spear sprites.
tweak: Restricts Tribal recipes to Ashlanders.
tweak: Rearranges Ashlander structures into specialized files.
tweak: Allows inspection of reagents in stone mortars.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: silicons <no@you.cat>
Co-authored-by: Zandario <zandarioh@gmail.com>
* shit code goes in the comedy bin
* stubs
* move those
* w
* vehicle repath
* maybe that instead
* aouhgoawhuh3ho
* markers
* a
* fixes
* hell
* let the great refactoring begin
* a
* aouhg
* changes
* augh
* signals
* s
* offhand stuff
* wrappers
* stuff
* modifications
* a
* stuff
* base component
* Stuff
* a
* stuff
* ay
* Ay
* ?
* fix
* a
* augh
* aough
* mark those
* sigh
* correction
* that
* let the good times roll
* more
* more
* on god
* aoihgouh
* fixes
* done with that ifle
* sigh
* a
* s
* fuck off voremobs
* stuff
* pain
* some more
* changes
* changes
* f/r
* sigh
* impl
* out with the useless
* fix
* Fixes
* a
* fixes
* move that
* pain
* fix
* m
* pain
* WHY
* regex
* s
* just offsets to go
* reserve those words
* that
* stuff
* stuff
* not sure if list ops were a good ide abut whatever
* fix
* and once more with energy!
* and once more with energy!
* fixes
* offsets
* fix
* lmao!
* ay
* patch
* fixes
* propagate that shit through
* ayo
* bruh?
* e
* PLEASE END MY SUFFERING
* ah.
* that
* fix
* fix
* fixes
* e
* Fix
* fix
* fix
* Fix
* fix
* fix
Co-authored-by: VM_USER <VM_USER>
