<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
update time related procs & glob too (i was originally targeting that
lmao).
also **stop** using byondtime for sql stuff, we have `NOW()`!!
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
- separates the composition of cyborgs into modules, iconsets, chassis,
upgrades
- modules / chassis atm can provide items, so can upgrades; in the
future we will want to probably generalize the item API a bit so
components can work
- chassis now can (unimplemented) easily be made to give different stats
- reorganizes all the cyborg sprites
- adds generalized item mounts with redirection support and tears out
legacy cyborg items
- entirely rebalances modules & writes some new lawsets in for future
use
---------
Co-authored-by: silicons <silicons@silicons.dev>
requires #6644
Entirely replaces how (most) belts perform insertion checks.
This pretty much allows belts to hold most things.
Armor vests are next.
Trashbags will also use the systems we use on main.
Closes#7256 and #7435
---------
Co-authored-by: silicons <silicons@silicons.dev>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Moves a few checks if someone's flying/hovering to use the
is_avoiding_ground check. It also removes the slowdown of a tile if you
aren't actually stepping on it. This check does include more, like if
you are only riding on something that's lifting you up enough, but
unless it flies itself, it'll trigger what you may be avoiding, and in
turn, will be affected by it (i.E falling down the chasm, there is no
delay in my test, so no Yoshiing over a single tile.)
Draft for now to see if there are more places to check for it, and as
the balance change is big enough to warrant additional thoughts.
## Why It's Good For The Game
Flying people no longer leave footprints, nor touch the ground for water
or lava. Logically, they aren't even slowed down by the tiles. This
heavily buffs flying, at least the ignoring the slowdown part, so that
may be removed for the sake of balance. The rest should be more
flavorful, or just making sense.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
tweak: If you aren't touching the ground, don't interact with things
there.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: MarsMond <no@email>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Title. Updates CI & Linting
Reruns tgm on maps to trim duplicate/unused keys and random whitespaces
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
converts global vars to regular defines
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
code: radiocode now uses defines, you cant tweak it from world.variables
anymore (or whatever that is)
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
I did this because some of the old text() uses would cause BYOND Beta
version 515.1607 to no longer compile. (Which is a bug but still an
excuse to finally deal with this)
## Beware
I hastily did this.
## Changelog
🆑
code: Converted all text("[]", foo) to "[foo]"
/🆑
- removes geosample: no one ever used this and it needs a way better
system than this
- atom colours are only applied to obj and mobs by default now, there's
no point tracking for further up stuff, as they probably have their own
systems
- turns a bunch of lists into lazylists
---------
Co-authored-by: silicons <no@you.cat>
## About The Pull Request
Adds Blueshields, a personal bodyguard for the Director, and then other
heads/command when a Director is absent.
## Why It's Good For The Game
Soon we'll be on the shipmap, where exploration is crunched down to only
the pathfinder. With security becoming larger when the explorer mains
(likely) start switching, a personal guard for the high ranking is
requires so that the head of security can still manage the crew, and
remaining security officers while an away mission is taking place.
(Especially during events.)
The Blueshield is there to guard the Director first and foremost, and
they are *not* to play the role of a security officer unless instructed
to do so in the absence of a replacement. Security officers arriving
on-scene should take priority of apprehending suspects, while the
Blueshield's focus stays on moving the Director (or other head) to
safety.
Imo, staff should be lenient with the above guidelines when there are NO
other security members on board, or no command.
Finally, this is only my initial plan for how they are implemented.
Gameplay guidelines are free for editing when implemented into SOP, and
I'm happy to provide my input if pinged about it in the discord forum
post.
## Changelog
🆑
add: Adds blueshields, a personal bodyguard for the Director, and other
heads/command when a Director is absent.
/🆑
---------
Co-authored-by: silicons <no@you.cat>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: fixed pathfinder PDAs spawning with an invalid iconstate
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Silicons asked me too and he knows very well I'll do this dumb shit in
one sitting.
* reworks reworks reworks
* s
* s
* e
* don't need that anymore right aha
* i'm lazy
* optimizations
* fix?
* aough
* fix
* fix
* fix
* better
* aough
* aough
* howmegalul
* epic
* optimizations
* augh
* ough
* sigh
* wow time for a fucking slowdown
* ough
* why
* why
* ough
* .
* sigh
* fix
* wip
* this is quickly going out of control
* why are we here, just to suffer?
* here we go again
* pain
* i'm impressed by how shit this code is
* d
* oh no
* oh no
* stuff
* aaa
* ayy
* groan
* hm
* proggers
* a
* that solves that
* ough
* kick that out
* t
* ough
* example item time
* convert
* WHY
* I HATE CATGIRLS
* a
* genuinely awful
* more
* t
* sigh
* staging
* stuff
* pain
* SIGH
* sigh
* more
* AAAAAA
* more
* please
* fuck it flag time
* autodetect
* a
* mistake time
* why
* coloration2
* prog
* now just for detection and icons
* vestigal
* move those
* fuck byond
* wryyyy
* repath
* a
* aough
* surprisingly well
* let's go..
* fix
* there
* a
* fixes
* fixes
* Fix
* fix
* fixes
* fixes
* that was a bad idea
* later
* tesh fixes
* e
* fix maybe
* fix maybe
* fixes
* how?
* c'mon
* here we go again
* gfi
* fix
* unreal
* Fixes
* epic
* gfi fixes
* gfi fixes
* why
* come the fuck on
* useless files
* finalized GFI
* rly
* fixes
* sorry
* come on.
* eh
Co-authored-by: VM_USER <VM_USER>
* Painus
* Yep
* Moar
* Let the agony begin
* text.dm
* scramble.dm
* time.dm
* fix
* unsorted.dm
* job_controller.dm
* _legacy
* computerfiles.dm
* events.dm
* global_iterator.dm
* topic_input.dm
* underwear.dm
* uplink
* periodic_news.dm again
* areas
* genes
Also renamed midget to dwarfism as it's a slur.
* changeling
* Cult
* gamemodes
* machinery
* mecha
* effects
* objects part 1
* Fine I'll commit the YAML
* objects part 2
* moar
* atmos
* ooga
* ahrde
* You can tell my sanity is going down
* Second-To-Last Step
* Almost
* Poggers
* nvm we're not ready for that <.<
* Test
* minor
* start
* i hate people who pack shit into one file
* sigh
* regex
* inventory rework
* stubs
* regex
* this is insanity
* oh no
* backend moment
* a
* changes
* wild
* regexing
* changes
* put in hands
* more errorS
* attackby
* more helpers
* replacements
* wild
* fixes
* pain
* fxies
* fixes
* unneeded
* ape
* ape
* wild
* wild
* more
* wild
* there
* fixes
* fixes
* l
* wild
* more
* moer
* fixes
* enough for todayd
* regexing
* long time coming
* shaking and crying
* end me
* fixes
* fixes
* e
* fxies
* rig refactor moment
* fixes
* fixes
* fixes
* fixes
* out with the shitcode
* thanks git
* partial rig rewrite here we go
* more
* fixes
* WWWW
* ok
* wild
* bitfield defines
* nobludgeon
* pain
* pain
* fixes
* more
* wild
* wild
* fixes
* pain
* move behaviorsr
* fixes
* next up, finishing core procs
* y
* .
* time to finish this
* time to finish this
* propagate accessories
* hate this accursed engine
* hate this accursed engine
* pain
* more
* cancer
* epic
* genuinely hate
* wild
* that
* why
* circuitry is my bane
* y
* how
* sort
* logging
* logging
* im dying
* fixes
* next
* f
* more
* epic style
* fixes
* on meta
* fix
* wild
* uh
* quirky
* fixes
* agh
* pain
* fixes
* fix
* sigh
* a
* epic1
* fixes
* ugh
* epic
* fixes
* uhh.
* is this even a fix
* fix
* fixes
* fixes
* we love optimization
* wear over system
* correct
* worn over stuff
* just augments
* coggy
* implant magnetic catch
* implant magnetic catch
* fixe
* a
* g
* t
* fix
* fix
* wack!
* fix
* a
* semantics
* fix
* that
* fixes
* handle denesting
* w
* fixes
* e
* bugs
* fixes
* fixes
* unit tests
* absolutely wild
* fixes
* fix
* fix
* fixes
* on god this is bad
* fixes
* fixes
* fix
* fix
* wacky!
* fix
* wack
* manual
* fixes
* closets
* OOPS
* wack
* pain
* pain
* flags
* regex
* fixes
* wakc
* changes
* more
* augh
* more
* replaces
* more
* that
* acc
* acc
* fix
* fix
* fix
* oh woops that was important
* wack
* epic
Co-authored-by: fake_vm_user <fake_vm_user>
Co-authored-by: VM_USER <VM_USER>
* dme and dmb
* Heeeere we gooo
* fasease
* Continued.
* AAAAAAAAAAAAAAAAAAAAAAAA
* Brain going numb
* agh
* The suffering will be worth it... right?
* Going blank...
* Am I done?
* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
* Fixes
* Should be everything I care about right now.
* tragic
* sync
* woo
* find replace
* more
* poggy
* woo
* sigh
* new
* ok
* woo
* comms fix, crew manifest disabled for now
* sigh
* fine i won't go past 120
