requires #6644
Entirely replaces how (most) belts perform insertion checks.
This pretty much allows belts to hold most things.
Armor vests are next.
Trashbags will also use the systems we use on main.
Closes#7256 and #7435
---------
Co-authored-by: silicons <silicons@silicons.dev>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Adds heretic themed objects, structures, mobs and more from TG/other
servers heretic code.
Most of the items will probably remain mechanically featureless. Unless
someone's insane enough to port full heretic functionality.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
MORE madness? MORE magic shit? MORE chaos? What's not to love?!
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Heretical stuff. More to come.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: Sorrowfulwinds <rockboy3970@gmail.com>
Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
Co-authored-by: silicons-bot <121360372+silicons-bot@users.noreply.github.com>
Co-authored-by: LordME <58342752+TheLordME@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Gives people the option to be directed by someone buckled to them.
Offset gets handled nicer now, resize affects the riding offset, taurs
actually have their center set to it, and not their tail end if 200%, or
infront of them if 25% size.
The code to saddle up actual horses, shanks, and stormdrifter bulls is
fixed, too, as it didn't switch the riding handler, which didn't get
deleted, and such not switching to the controllable part.
A few typos got fixed, stumbled by typoing my own search for the 3 mobs
for their var.
Small rendering tweak to potentially draw bags ontop of tails (required
for saddlebags.)
Saddlebags now include the saddle option, and such makes it easier for
one to hold onto
## Why It's Good For The Game
People do look more like they are carried by the person they are buckled
to. The new option could allow some RP options, synth having a
controller or being just directed by holding some part of the body, or
maybe way to put the jousting compontent to use? The bucking gives an
option to remove someone riding one, as one otherwise has no control
over it. The saddlebag also even works as a saddle now, although that
can be removed if the freeded up hand is deemed too strong.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: taurs actually get their center calculated correctly, noticeable if
buckled sideways.
tweak: offsets get resized for riding.
fix: horse, shank, stomrdrifter bull saddeling
fix: taur bags actually get drawn over the taur body
add: ability to buck someone off your back
tweak: no riding hand needed if the taur is wearing a saddle.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: MarsMond <no@email>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
1. **Adds an 'Invsible' Satchel Type to Seasonal Halloween Loadout.**
## Why It's Good For The Game
1. _Backpacks are really useful, but sometimes you don't want them
covering up your whole outfit and stuff. This adds a new invisible
satchel type that lets you show off your costumes without sacrificing
storage. Only available via the Masquerade slot during Halloween._
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Adds an Invisible Satchel type to seasonal Halloween loadout.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
Fixes the issues with saddlebags where it would not compile earlier and
where non taurs could wear them. Tested locally before the PR was made,
compiled without complaining, taurs were able to wear them and the
visibly appeared while non-taurs couldn't put them on.
Removes the generic horse-only saddlebag since it's already the
saddlebag_common one, uses the same icon and was just unnecessary
duplicate old code. Also removes duplicate saddlebag icons in the taur
back file.
Also fixes 4 pixels I forgot about on the drake taur wing icon.
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
Lets taurs wear the funny back bags again and makes my eyes stop
bleeding by seeing the 4 missing pixels on the wings I ported earlier.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: fixes saddlebags not working and uncomments them
fix: fixes 4 pixels on drake taur wings
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
I realized it's literally impossible to translate all of this code at
once. RIG suit code is just all over the place.
This lets me develop rigs from the ground up without conflicting with
existing code. Old rigs will therefore not be the same item or ecosystem
as new rigs.
---------
Co-authored-by: silicons <no@you.cat>
## About The Pull Request
Adds Blueshields, a personal bodyguard for the Director, and then other
heads/command when a Director is absent.
## Why It's Good For The Game
Soon we'll be on the shipmap, where exploration is crunched down to only
the pathfinder. With security becoming larger when the explorer mains
(likely) start switching, a personal guard for the high ranking is
requires so that the head of security can still manage the crew, and
remaining security officers while an away mission is taking place.
(Especially during events.)
The Blueshield is there to guard the Director first and foremost, and
they are *not* to play the role of a security officer unless instructed
to do so in the absence of a replacement. Security officers arriving
on-scene should take priority of apprehending suspects, while the
Blueshield's focus stays on moving the Director (or other head) to
safety.
Imo, staff should be lenient with the above guidelines when there are NO
other security members on board, or no command.
Finally, this is only my initial plan for how they are implemented.
Gameplay guidelines are free for editing when implemented into SOP, and
I'm happy to provide my input if pinged about it in the discord forum
post.
## Changelog
🆑
add: Adds blueshields, a personal bodyguard for the Director, and other
heads/command when a Director is absent.
/🆑
---------
Co-authored-by: silicons <no@you.cat>
* reworks reworks reworks
* s
* s
* e
* don't need that anymore right aha
* i'm lazy
* optimizations
* fix?
* aough
* fix
* fix
* fix
* better
* aough
* aough
* howmegalul
* epic
* optimizations
* augh
* ough
* sigh
* wow time for a fucking slowdown
* ough
* why
* why
* ough
* .
* sigh
* fix
* wip
* this is quickly going out of control
* why are we here, just to suffer?
* here we go again
* pain
* i'm impressed by how shit this code is
* d
* oh no
* oh no
* stuff
* aaa
* ayy
* groan
* hm
* proggers
* a
* that solves that
* ough
* kick that out
* t
* ough
* example item time
* convert
* WHY
* I HATE CATGIRLS
* a
* genuinely awful
* more
* t
* sigh
* staging
* stuff
* pain
* SIGH
* sigh
* more
* AAAAAA
* more
* please
* fuck it flag time
* autodetect
* a
* mistake time
* why
* coloration2
* prog
* now just for detection and icons
* vestigal
* move those
* fuck byond
* wryyyy
* repath
* a
* aough
* surprisingly well
* let's go..
* fix
* there
* a
* fixes
* fixes
* Fix
* fix
* fixes
* fixes
* that was a bad idea
* later
* tesh fixes
* e
* fix maybe
* fix maybe
* fixes
* how?
* c'mon
* here we go again
* gfi
* fix
* unreal
* Fixes
* epic
* gfi fixes
* gfi fixes
* why
* come the fuck on
* useless files
* finalized GFI
* rly
* fixes
* sorry
* come on.
* eh
Co-authored-by: VM_USER <VM_USER>
* Ashlanders
* Adjustments to Scori breathing parameters.
* Update to multiple bugs.
* WIP Clothing not working yet.
* Update for input.
* Kinetic Crusher Still WIP
* Adds Confirmation Box, Adjusts Spawn Wording QOL
* Bo staff replaces Crusher. Minor text adjustments.
* Patches busted Centcom paths.
* Corrects updated paths on broken outfit.
* Updates Ashlander clothing and material overlays.
* Adjusts resistances for Ashlanders and adds fruit.
* Fixes? icon hanging. Adds Guardian backstory.
* Updating re: Kevin's input.
* Second battery of updates.
* Adds Ashlander POI to try and fix the thing.
* like that
* Testing
* Second push.
* Third push I guess?
* Corrects customization call.
* Bandaid patch.
* Removes Patch due to Atomization
* Silly me. I re-conflicted the conflicts I fixed.
* Updates patch.
* QOL for Landies
* Adds indoor lavaland turfs and fixes box bug.
* Parity?
* Allows for duplicate Ashlander camps.
* Fixes material icon fix that broke stuff.
* Preps the Sentry role for muskets.
* Attempts to repair a runtime.
* Updates w/ Ruskit's musket PR.
Co-authored-by: VM_USER <VM_USER>
* start
* i hate people who pack shit into one file
* sigh
* regex
* inventory rework
* stubs
* regex
* this is insanity
* oh no
* backend moment
* a
* changes
* wild
* regexing
* changes
* put in hands
* more errorS
* attackby
* more helpers
* replacements
* wild
* fixes
* pain
* fxies
* fixes
* unneeded
* ape
* ape
* wild
* wild
* more
* wild
* there
* fixes
* fixes
* l
* wild
* more
* moer
* fixes
* enough for todayd
* regexing
* long time coming
* shaking and crying
* end me
* fixes
* fixes
* e
* fxies
* rig refactor moment
* fixes
* fixes
* fixes
* fixes
* out with the shitcode
* thanks git
* partial rig rewrite here we go
* more
* fixes
* WWWW
* ok
* wild
* bitfield defines
* nobludgeon
* pain
* pain
* fixes
* more
* wild
* wild
* fixes
* pain
* move behaviorsr
* fixes
* next up, finishing core procs
* y
* .
* time to finish this
* time to finish this
* propagate accessories
* hate this accursed engine
* hate this accursed engine
* pain
* more
* cancer
* epic
* genuinely hate
* wild
* that
* why
* circuitry is my bane
* y
* how
* sort
* logging
* logging
* im dying
* fixes
* next
* f
* more
* epic style
* fixes
* on meta
* fix
* wild
* uh
* quirky
* fixes
* agh
* pain
* fixes
* fix
* sigh
* a
* epic1
* fixes
* ugh
* epic
* fixes
* uhh.
* is this even a fix
* fix
* fixes
* fixes
* we love optimization
* wear over system
* correct
* worn over stuff
* just augments
* coggy
* implant magnetic catch
* implant magnetic catch
* fixe
* a
* g
* t
* fix
* fix
* wack!
* fix
* a
* semantics
* fix
* that
* fixes
* handle denesting
* w
* fixes
* e
* bugs
* fixes
* fixes
* unit tests
* absolutely wild
* fixes
* fix
* fix
* fixes
* on god this is bad
* fixes
* fixes
* fix
* fix
* wacky!
* fix
* wack
* manual
* fixes
* closets
* OOPS
* wack
* pain
* pain
* flags
* regex
* fixes
* wakc
* changes
* more
* augh
* more
* replaces
* more
* that
* acc
* acc
* fix
* fix
* fix
* oh woops that was important
* wack
* epic
Co-authored-by: fake_vm_user <fake_vm_user>
Co-authored-by: VM_USER <VM_USER>
