## About The Pull Request
add support for holiday locked vending machine products
also removes the old holiday system, moving all holidays in it to the
newer system
and lets you set if a holiday should be announced or not
## Why It's Good For The Game
someone asked for it
## Changelog
🆑
add: add support for holiday locked vending machine products
🆑
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Refactors clothing/under to use the new rendering system for both icons
and flags and does some general rearranging and cleanup of the code
files.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
One single consistent system is good. This also fixes a lot of missing
rolldown, rolled sleeves, and maybe some species specific sprites.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
- Moves clothing/under/accessories to clothing/legacy_accessories
- Reformats under into under/casual, /costumes, /formal, /workwear
folders.
- Changes all /obj/item/clothing/under to use the new clothing render
system
- Annihilates uniform.dmi into a thousand pieces
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑 _Shadowcat_
refactor: refactors under clothing to new render system
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---------
Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Added Belly dancer outfit as halloween costume
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
1. **Adds an 'Invsible' Satchel Type to Seasonal Halloween Loadout.**
## Why It's Good For The Game
1. _Backpacks are really useful, but sometimes you don't want them
covering up your whole outfit and stuff. This adds a new invisible
satchel type that lets you show off your costumes without sacrificing
storage. Only available via the Masquerade slot during Halloween._
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Adds an Invisible Satchel type to seasonal Halloween loadout.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Added bellydancer outfit in halloween loadout
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
1. **Creates Cultist Clothing Sheet.**
2. **Creates Heretic Clothing Sheet.**
3. **Removes Extraneous Sprites.**
4. **Maps In Updated Memorial.**
5. **Fixes Foam Spears.**
6. **Fixes Worm Recipe Path.**
## Why It's Good For The Game
1. _Shifts cult armor icon mapping to the new standard._
2. _Shifts heretic robe icon mapping to the new standard._
3. _Removes duplicates of cult and heretic sprites from old icon
sheets._
4. _The memorial was updated to be one object or something and whoever
made it forgot to map it in for Atlas CentCom._
5. _Foam spears weren't using the correct icons._
6. _Worms were slightly repathed, breaking a few goblin recipes.
Corrects this._
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
tweak: Shifts cult armor to new sheet.
tweak: Shifts heretic robes to new sheet.
del: Removes duplicate icons of the above from old sheets.
fix: Remaps new memorial on Atlas.
fix: Fixes spear icon state issue.
fix: Fixes worm pathing in recipes.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
1. **Adds Fake Changeling Claw Gloves.**
## Why It's Good For The Game
1. _Player request to help put a costume together._
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Adds Costume Changeling Claw Gloves
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
1. *Adds a costume set and a matching hair style.*
## Why It's Good For The Game
1. _Nothing fancy. Just a costume._
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Adds a costume.
add: Adds a hairstyle.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
## About The Pull Request
tin
## Why It's Good For The Game
memory improvements & code efficiency
## Changelog
nah
Co-authored-by: silicons <no@you.cat>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
1. **Populates Christmas Holiday Loadout List.**
## Why It's Good For The Game
1. _I noticed today that our Christmas loadout list was entirely blank,
unlike our Halloween one. With some help from Kevin we were able to
locate the issue, and I have since been able to populate this list with
delightful Christmas themed clothes for everyone to enjoy. Please be
sure to thank Kevin! Even though this PR is a bit late, now we can
expand and celebrate extra well for next year!_
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
add: Adds Christmas loadout item list.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
* reworks reworks reworks
* s
* s
* e
* don't need that anymore right aha
* i'm lazy
* optimizations
* fix?
* aough
* fix
* fix
* fix
* better
* aough
* aough
* howmegalul
* epic
* optimizations
* augh
* ough
* sigh
* wow time for a fucking slowdown
* ough
* why
* why
* ough
* .
* sigh
* fix
* wip
* this is quickly going out of control
* why are we here, just to suffer?
* here we go again
* pain
* i'm impressed by how shit this code is
* d
* oh no
* oh no
* stuff
* aaa
* ayy
* groan
* hm
* proggers
* a
* that solves that
* ough
* kick that out
* t
* ough
* example item time
* convert
* WHY
* I HATE CATGIRLS
* a
* genuinely awful
* more
* t
* sigh
* staging
* stuff
* pain
* SIGH
* sigh
* more
* AAAAAA
* more
* please
* fuck it flag time
* autodetect
* a
* mistake time
* why
* coloration2
* prog
* now just for detection and icons
* vestigal
* move those
* fuck byond
* wryyyy
* repath
* a
* aough
* surprisingly well
* let's go..
* fix
* there
* a
* fixes
* fixes
* Fix
* fix
* fixes
* fixes
* that was a bad idea
* later
* tesh fixes
* e
* fix maybe
* fix maybe
* fixes
* how?
* c'mon
* here we go again
* gfi
* fix
* unreal
* Fixes
* epic
* gfi fixes
* gfi fixes
* why
* come the fuck on
* useless files
* finalized GFI
* rly
* fixes
* sorry
* come on.
* eh
Co-authored-by: VM_USER <VM_USER>
* start
* i hate people who pack shit into one file
* sigh
* regex
* inventory rework
* stubs
* regex
* this is insanity
* oh no
* backend moment
* a
* changes
* wild
* regexing
* changes
* put in hands
* more errorS
* attackby
* more helpers
* replacements
* wild
* fixes
* pain
* fxies
* fixes
* unneeded
* ape
* ape
* wild
* wild
* more
* wild
* there
* fixes
* fixes
* l
* wild
* more
* moer
* fixes
* enough for todayd
* regexing
* long time coming
* shaking and crying
* end me
* fixes
* fixes
* e
* fxies
* rig refactor moment
* fixes
* fixes
* fixes
* fixes
* out with the shitcode
* thanks git
* partial rig rewrite here we go
* more
* fixes
* WWWW
* ok
* wild
* bitfield defines
* nobludgeon
* pain
* pain
* fixes
* more
* wild
* wild
* fixes
* pain
* move behaviorsr
* fixes
* next up, finishing core procs
* y
* .
* time to finish this
* time to finish this
* propagate accessories
* hate this accursed engine
* hate this accursed engine
* pain
* more
* cancer
* epic
* genuinely hate
* wild
* that
* why
* circuitry is my bane
* y
* how
* sort
* logging
* logging
* im dying
* fixes
* next
* f
* more
* epic style
* fixes
* on meta
* fix
* wild
* uh
* quirky
* fixes
* agh
* pain
* fixes
* fix
* sigh
* a
* epic1
* fixes
* ugh
* epic
* fixes
* uhh.
* is this even a fix
* fix
* fixes
* fixes
* we love optimization
* wear over system
* correct
* worn over stuff
* just augments
* coggy
* implant magnetic catch
* implant magnetic catch
* fixe
* a
* g
* t
* fix
* fix
* wack!
* fix
* a
* semantics
* fix
* that
* fixes
* handle denesting
* w
* fixes
* e
* bugs
* fixes
* fixes
* unit tests
* absolutely wild
* fixes
* fix
* fix
* fixes
* on god this is bad
* fixes
* fixes
* fix
* fix
* wacky!
* fix
* wack
* manual
* fixes
* closets
* OOPS
* wack
* pain
* pain
* flags
* regex
* fixes
* wakc
* changes
* more
* augh
* more
* replaces
* more
* that
* acc
* acc
* fix
* fix
* fix
* oh woops that was important
* wack
* epic
Co-authored-by: fake_vm_user <fake_vm_user>
Co-authored-by: VM_USER <VM_USER>