## About The Pull Request
Fixes a few bugs, notably with ID card readers not properly filling info
out from an ID. Also it untypes the data from /datum/weakref. This
wasn't always a /datum/weakref, but was typed as it for ??? reasons,
primarily relevant for Zandario who was having issues while trying to do
some stuff.
## Why It's Good For The Game
fixes bugs. also doesnt have something randomly typed as something it's
not.
## Changelog
🆑
tweak: Circuit data isn't typed as /datum/weakref anymore.
tweak: ID card readers now have a data output of rank, which is the
non-alternative job title.
fix: ID card readers now properly read a job and assignment from an ID.
fix: Removing a circuit component by its own 'remove' ui button now
properly removes it from the assembly UI.
tweak: Removing a component from the UI doesn't brick a UI component in
place in circuit tgui.
/🆑
## About The Pull Request
This fixes a few problems that still remained (or got implemented by
bugged behavior being fixed) with circuits.
Particularly, it makes sure pins display their output text properly; a
bug I accidentally introduced earlier.
Circuit components loading will also load their data before being put in
a assembly proper. (that way, names display correctly.)
It also makes sure that where applicable, circuits will actually use the
helpers for data screwyness.
As a side effect, the above (with a few tweaks) also fixes an issue
where raw references were getting stored in lists.
Finally, list cooldowns were reduced to the standard (otherwise this
makes them *very* awkward to work with.)
Theoretically I could atomize this PR further, but, uh, a lot of it was
just bug fixes.
## Why It's Good For The Game
fixes a variety of bugs.
For the list cooldown tweaks, some of them would have 0.1 CD, some would
have 1, and there was no real correlation to which had what. I don't
really think the cooldown feature should limit circuits realistically
(which this would do.) if they are wholly internal.
## Changelog
🆑
tweak: Circuit list component cooldowns are now universally 0.1.
fix: Circuit lists won't sneak full references in when transferred.
fix: Circuit components will now properly use helpers for IO
input/output.
fix: Circuit names will load properly if from a custom import.
fix: Circuit input/outputs will display their text once again.
/🆑
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
This PR aims to bring integrated circuits not only to a more up to date
version but also fix some features that weren't working.
For this I have used Baystations current circuits as a working
reference. I have compiled, tested and checked for runtimes.
Fixes include
- Tile analyzer and examiner being able to handle tiles
- Reference encoder and decoders doing their job
- Advanced pathfinder being able to path through access restricted doors
- The EPv2 circuit using an incompatible name for cloning
As a consequence for the advanced pathfinder I had to readjust how
access is given to circuits which now allows them to read the passkey of
ID's, store them, send them and so on. A minor tweak also adjusts the
TTS circuit to 1 second. Additionally, I have added an advanced signaler
that while it behaves identical to EPv2 it is able to work the moment
you print it without having to set an address (Not to mention that EPv2
often fails to create an address upon print)
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
* move phoronlock define
* t
* force rename
* nuke unneeded things
* don't do that
* tgui sync?
* changes
* unit testing module
* backend
* tools update
* aaah
* go and stay go
* path replace
* move everything
* toss out more stuff
* remove
* fine those can stay
* dependencies.sh
* ruin datum move + rename
* level assets why did you guys put the turfs in my atmosphers folder grr
* more moving
* basemap, force stuff
* fix that desync meme
* move more stuff
* move those too
* repath
* get rid of useless initializers
* hacky patchy
* reservations
* alright
* tgui
* changelog example
* checksum
* md5
* errors
* more
* turf empty
* stop
* fix
* bad kwarg
* let's get those in again
* alright
* rid of that
* huh
* newlines
* newlines
* folder
* mood
* woops
* readme
* might as well trim now
* let's go
* fuck it tether isn't being used anyways lol
* ok
* empty files go
* tether is demoted
* sorry but this goes too
* okay
* make that work too
* ok
* wow.
* whew
* Fix
* fixes
* ok
* sigh
* fix
* fix
* aah.
* rust_g logging
* update rust g file
* fix
* funny
* Fix
* map issues
* fix
* initialize hints
* solves some problems
* those too
* ok
* pills
* let's do that.
* hit that too
* runtime
* add that too
* alright
* fix
* fix
* fix
* Fix
* add
* fix
* wildwest, what have they done to you...
* do that too'
git push
* fixes
* fixes
* fixes
* pack this tightly
* let's not have empty files
* sigh
* fix
* FUCK OFF
* fix icon
* rip old mapmerge
* zz
* woo yeah woo yeah
* logging
* fix
* better logs
* GRRRRRR
* last commit??
* awful
