changes:
- Glass turfs now actually work properly.
- `hard_reset()` now resets harder.
- ZM now avoids some redundant lighting copies.
- `update_above()` will now force a discovery if the movable is
undiscovered.
- `NO_SHADOW` is more reliable.
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
Fixes map errors on Gaia, Triumph, Tether, and Sky Planet.
Changes the warnings for Stairs, Catwalks, and SMES's to call CRASH()
with audit_loc() to match the standard used by paint helpers and window
spawners.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
Maps being able to load is good.
Vague warnings are now changed to verbose hard crashes to make it much
easier to fix as a mapper (and ideally prevent these issues from
embedding themselves into the codebase without notice).
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
-Fixes Gaia map errors
-Fixes Tether map errors
-Fixes Sky Planet map errors
-Fixes Triumph map errors
-Changes map Warning()s to CRASH()s
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
fix: fixed gaia, triumph, tether, skyplanet map errors.
code: changed stairs, catwalks, SMES warnings to verbose CRASHs.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
There's still some update ordering issues that seem connected to
lighting, but I'm not sure if this is actually an issue with ZM/O7L
itself or seeker having a moment.
Also fixes some issues with new atom notifications in ZM not working
with recursive mimic properly.
## About The Pull Request
Previously:
- A lot of unnecessary code to thread and repeatedly add
orientation-related variables to the preloader.
- dmm_parsed previously modified its own args, then used arglist(args)
This is bad energy -- as far as I can tell, this was was relying on the
fact that _load_impl didn't use the modified values.
- Fire alarms were hardcoded to deal with east/west incorrectly
Now:
- These variables now live in the dmm_context.
- _load_impl takes fewer unnecessary args, and all its args are explicit
- A few variables have been removed or had their scope limited.
- Fire alarms aren't hardcoded to do that anymore.
Bugs I didn't fix:
- When a map is rotated EAST or WEST, signs spawn in an overlapping
fashion that's really ugly.
## Why It's Good For The Game
### Correctness
Fire alarms were spawning sideways when rotated EAST or WEST and
probably shouldn't be. I've fixed this behavior now.
### Style
Threading a lot of variables in DM is pretty rough -- DM doesn't
actually warn if you do this wrong. Silicons specifically flagged this
as a rough spot for code quality, which is why I attacked it.
These variables never change during the load process, so threading them
as arguments creates the false implication that they can be different
per map object.
### Performance
My goal wasn't to make performance better, just to make the code more
readable without making it worse. Brief profiling implies it might be
faster, but the difference is marginal and possibly explained by bad
test conditions:
- map loading took 24.0, 24.3, 24.6 seconds before the change
- map loading took 23.0, 23.6, 23.8 seconds after this change
All tests were done with rotated Triumph. (I haven't profiled
non-rotated yet.)
Back of the envelope calculation implies the number of
variable-on-object lookups in the hot loop phase of the map load should
be pretty close to the original number -- maybe a little lower, since
I've turned some into locals.
The one lookup that looks new (where we get the context from the
preloader in preloader_load) was actually one that happened
unconditionally at the end of the procedure in the previous code.
## Images
Sign bug: I didn't fix this or introduce this.
Fire alarm bug living its best life. I fixed this:
Fire alarm is Tethered. (Post-fix):
## Changelog
🆑 Pyrex
refactor: DMM rotation code is a little tidier
fix: fire alarms have a 0% chance of hovering
/🆑
---------
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
i decided to atomize my prs a little
- map obfuscation module upgraded
- obfuscation now happens via mangling id, inspired by nebula. atoms loaded with the same mangling id will generate the same obfuscated ids from a given and matching input id
- /datum/map_injection added; it's a composition-based system for modifying maps during spawn
- /datum/map_injection/starting_gear; inspired by barotrauma, pretty much just injects starting gear as necessary with a given configuration. multiple of these can be stacked in a given maploading.
- /obj/map_helper/gear_marker; markers for where starting_gear should populate things.
This is largely just synchronizing ZM with the latest upstream version,
though I also renamed SSzmimic to make updates like this easier.
Changes:
- It is no longer possible to outrun Z-Mimic, except now without the
cost of doubling ZM init time.
- `ZMM_LOOKBESIDE` is now supported to handle wide mobs as well as long
mobs. Use `ZMM_WIDE_LOAD` for both wide and long, such as scaled up
atoms.
- It is now possible for a turf to override its Z-Mimic appearance.
- `MZ_TERMINATOR` can now be specified to cause a turf to act as the
bottom of a ZM stack.
- `MZ_NO_SHADOW` can be specified to opt out of Z-M's darkening effect,
though lighting copy and AO are still active.
- Some bugs in layering caused by atoms moving up or down z-levels have
been fixed.
- Z-Mimic now has a basic performance profiler.
- ZM appearance fixup no longer breaks underlays.
3/3 is world structs and the fun that comes with that
this pr has:
- transitions
- new multiz system
- lookup optimizations
- misc updates
---------
Co-authored-by: silicons <no@you.cat>
## About The Pull Request
adds generic system for atom health / integrity / damage
everything that isn't flagged with not-bludgeonable can, well, now be
bludgeoned.
## Why It's Good For The Game
more interactive game world through the means of making people able to
break Everything.
## Changelog
🆑
add: atom damage - (almost) everything is now breakable.
refactor: new /atom level materials system
refactor: a lot of the combat system / click code
refactor: melee attack styles
/🆑
---------
Co-authored-by: silicons <no@you.cat>
- adds astar with visualizer
- adds jps with visualizer
- transitions everything to subsystem calls
- subsystem now limits the number of calls that can go on at once for
performance reasons
"uh oh, silicons is fucking with integral game code while half asleep
again"
---------
Co-authored-by: silicons <no@you.cat>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
makes turf/simulated/open blue. resets on init.
## Why It's Good For The Game
holy FUCKING SHIT my eyes HATE WHOEVER DECIDED IT SHOULD BE MISSING
TEXTURE PINK.
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
- Adds Auril castes (Praesidus and Incanus)
- They have their own statchanges, but nothing too special
- Makes flight an ability icon for non-custom species. Adds item-based
slowdown to flight (stuff Hardy reduces)
- Adds an Auril 'advanced' flight. It ignores slowdown.
- Adds a species flight mod that speeds up how fast you ascend z-levels.
Aurils get it reduced, Praesidus even more.
- Adds Toggle Agility ability, gives it to everyone that had it
- It works as a timed toggle, similar to Chimera thermal sight.
**- Teshari no longer have innate agility** - not really stuck with the
change, they just had the agility flag turned on by default, while also
having the toggle. I chose to just give them the toggle and turn it off
by default like everyone else with the ability.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
god I love the icons bro
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
🆑
code: some tg movement stuff
add: holocalls
add: holocalls are rather advanced; enjoy. cross ship communication will
finally be a thing.
add: AI/pAI custom holoforms; enjoy, you can finally fuck around as your
own character
/🆑
---------
Co-authored-by: silicons <no@you.cat>
Rips out SSoverlays in favor of the O7 one, which supports priority
overlays. This should fix issues with AO vanishing, as well as being
generally faster.
Also audited all SSoverlay calls, some were strange, invalid, or
pointlessly inefficient.
Co-authored-by: Zandario <zandarioh@gmail.com>
