<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
- Functionalizes hallucination adjustment to firmly establish rules on
hallucinations. Any code that changes hallucinations uses this function
now.
- Caps hallucination at 400. It's annoying until it gets a rework.
- Synthetics will no longer experience hallucinations. (Horror aura
causes EMPs, so synthetics already have a shitty end of the stick when
dealing with horror mobs. Also this is intentional Sili recommendation.)
- Species that aren't meant to receive hallucinations will no longer
experience hallucinations effects at all.
- There was some comment somewhere saying that hallucinations should be
reduced faster when you're sleeping/unconscious, so I made it do that.
- Prometheans can no longer "recall" items using promethean blobform.
They were able to just teleport items from a distance previously.
## Why It's Good For The Game
Hallucinations are shit. Let's cap them.
Otherwise, fixes good.
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
balance: Hallucinations are capped at 400.
fix: Synthetics will no longer experience hallucinations.
fix: Species that aren't meant to receive hallucinations will no longer
experience hallucinations effects at all.
fix: Prometheans can no longer magically recall items using blobform.
code: Hallucination adjustment code has been established.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
changes how blindness is handled in game
temporary sources of blindness add a status effect to the affected mob
while permanent sources (such as missing eyes/vision organs) add the
traits
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
## Why It's Good For The Game
blinding code was a mess (and still isnt perfect) this makes it slightly
more reasonable
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
refactor: refactored blinding code
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
## Why It's Good For The Game
should have no impact on the game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑
code: changed a bunch of species checks to use ID rather than name
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
* Painus
* Yep
* Moar
* Let the agony begin
* text.dm
* scramble.dm
* time.dm
* fix
* unsorted.dm
* job_controller.dm
* _legacy
* computerfiles.dm
* events.dm
* global_iterator.dm
* topic_input.dm
* underwear.dm
* uplink
* periodic_news.dm again
* areas
* genes
Also renamed midget to dwarfism as it's a slur.
* changeling
* Cult
* gamemodes
* machinery
* mecha
* effects
* objects part 1
* Fine I'll commit the YAML
* objects part 2
* moar
* atmos
* ooga
* ahrde
* You can tell my sanity is going down
* Second-To-Last Step
* Almost
* Poggers
* nvm we're not ready for that <.<
* Test
* minor
* shit code goes in the comedy bin
* stubs
* move those
* w
* vehicle repath
* maybe that instead
* aouhgoawhuh3ho
* markers
* a
* fixes
* hell
* let the great refactoring begin
* a
* aouhg
* changes
* augh
* signals
* s
* offhand stuff
* wrappers
* stuff
* modifications
* a
* stuff
* base component
* Stuff
* a
* stuff
* ay
* Ay
* ?
* fix
* a
* augh
* aough
* mark those
* sigh
* correction
* that
* let the good times roll
* more
* more
* on god
* aoihgouh
* fixes
* done with that ifle
* sigh
* a
* s
* fuck off voremobs
* stuff
* pain
* some more
* changes
* changes
* f/r
* sigh
* impl
* out with the useless
* fix
* Fixes
* a
* fixes
* move that
* pain
* fix
* m
* pain
* WHY
* regex
* s
* just offsets to go
* reserve those words
* that
* stuff
* stuff
* not sure if list ops were a good ide abut whatever
* fix
* and once more with energy!
* and once more with energy!
* fixes
* offsets
* fix
* lmao!
* ay
* patch
* fixes
* propagate that shit through
* ayo
* bruh?
* e
* PLEASE END MY SUFFERING
* ah.
* that
* fix
* fix
* fixes
* e
* Fix
* fix
* fix
* Fix
* fix
* fix
Co-authored-by: VM_USER <VM_USER>