fixes computers eating cards

this commit :
https://github.com/Baystation12/Baystation12/commit/ea1060ac339c4b4ef1692f446865926cf262dd68

added in machinery's attack_hand() proc, line 238
```
if(!allowed(user))
		user << "\red Access Denied."
		return 1
```

to almost all machinery including computers, since they call this proc via their attack_hand() procs.

allowed(user), see access.dm line 94, in turn only checks the user's hand and wear_id,
NOT the card inside the machine,
as different machines have different vars and systems handling how they can be accessed.

instead of fixing the underlying problem, eject card verbs were added like this one :
https://github.com/Baystation12/Baystation12/commit/30385c22371a4e47ac43eac2fc953f7f8854fad4

this PR reverts that nonsense machinery addition and adds the shuttle_control access check where it belongs.
Conflicts:
	code/game/machinery/machinery.dm
This commit is contained in:
Walter0o
2014-07-13 07:09:01 -04:00
committed by ZomgPonies
parent 2bb72d378b
commit 172821f86d
+14 -5
View File
@@ -255,10 +255,6 @@ Class Procs:
src.add_fingerprint(user)
if(!allowed(user))
user << "\red Access Denied."
return 1
var/area/A = get_area(src)
A.powerupdate = 1
@@ -334,4 +330,17 @@ Class Procs:
for(var/var/obj/item/C in component_parts)
user << "<span class='notice'> [C.name]</span>"
return 1
return 0
else
return 0
/obj/machinery/proc/dismantle()
playsound(loc, 'sound/items/Crowbar.ogg', 50, 1)
var/obj/machinery/constructable_frame/machine_frame/M = new /obj/machinery/constructable_frame/machine_frame(loc)
M.state = 2
M.icon_state = "box_1"
for(var/obj/I in component_parts)
if(I.reliability != 100 && crit_fail)
I.crit_fail = 1
I.loc = loc
del(src)
return 1