migrates /obj/effect to the new attack chain (#28066)

* the great migration

* pleasing the linter

* whoops

* smol fixes

* review

* hallucination attack proc

---------

Co-authored-by: Toastical <toast@toaster.com>
Co-authored-by: Toastical <toastical@toaster.com>

code/game/objects/items/weapons/gift_wrappaper.dm

@@ -39,19 +39,16 @@
 		return
 	to_chat(user, "<span class='notice'>You can't move.</span>")
 
-/obj/effect/spresent/attackby__legacy__attackchain(obj/item/W as obj, mob/user as mob, params)
-	..()
-
-	if(!istype(W, /obj/item/wirecutters))
+/obj/effect/spresent/item_interaction(mob/living/user, obj/item/used, list/modifiers)
+	if(!istype(used, /obj/item/wirecutters))
 		to_chat(user, "<span class='notice'>I need wirecutters for that.</span>")
-		return
+		return ITEM_INTERACT_COMPLETE
 
 	to_chat(user, "<span class='notice'>You cut open the present.</span>")
-
 	for(var/mob/M in src) //Should only be one but whatever.
 		M.forceMove(loc)
-
 	qdel(src)
+	return ITEM_INTERACT_COMPLETE
 
 /obj/item/a_gift/attack_self__legacy__attackchain(mob/M as mob)
 	var/gift_type = pick(

code/game/objects/items/weapons/mop.dm

@@ -43,7 +43,7 @@
 			return
 
 		if(istype(O, /obj/structure/janitorialcart))
-			var/obj/structure/janitorialcart/janicart = O	
+			var/obj/structure/janitorialcart/janicart = O
 			if(!janicart.my_mop)
 				janicart.my_mop = src
 				janicart.put_in_cart(user, src)
@@ -104,7 +104,7 @@
 	/// Self-refill toggle for when a janitor decides to mop with something other than water.
 	var/refill_enabled = TRUE
 	/// Rate per process() tick mop refills itself
-	var/refill_rate = 1 
+	var/refill_rate = 1
 	/// Determins what reagent to use for refilling, just in case someone wanted to make a HOLY MOP OF PURGING
 	var/refill_reagent = "water"
 
@@ -115,7 +115,7 @@
 /obj/item/mop/advanced/activate_self(mob/user)
 	if(..())
 		return
-	
+
 	refill_enabled = !refill_enabled
 	if(refill_enabled)
 		START_PROCESSING(SSobj, src)