Remove remaining arbitrary restrictions on has_fine_manip

This commit removes all (most) of the remaining code limiting xenomorphs
that have has_fine_manipulation on an entirely arbitrary basis. Xenomorphs
with has_fine_manipulation may now interact with NanoUI, and will only
break computers on non-help intent. The can also tear down walls, since
walls used an ishuman check in place of an isAdvancedToolUser check as
they should have.

Minor refactor to machinery.dm as well; Instead of the slightly
(completely) insane attack_hand restriction to humans and silicons (it was
a multi-line IF, why), it now checks user.IsAdvancedToolUser(); This means
restrictions on monkies will actually function properly now.
This commit is contained in:
Tigercat2000
2015-09-30 10:50:10 -07:00
parent 700baff0ff
commit c4fa813331
11 changed files with 37 additions and 30 deletions
+8 -3
View File
@@ -18,8 +18,8 @@
/obj/machinery/computer/New()
overlay_layer = layer
..()
..()
/obj/machinery/computer/initialize()
power_change()
update_icon()
@@ -79,7 +79,7 @@
overlays += image(icon,"[icon_state]_broken",overlay_layer)
else
overlays += image(icon,icon_screen,overlay_layer)
if(icon_keyboard)
overlays += image(icon, icon_keyboard ,overlay_layer)
@@ -134,6 +134,11 @@
return
/obj/machinery/computer/attack_alien(mob/living/user)
if(isalien(user) && user.a_intent == I_HELP)
var/mob/living/carbon/alien/humanoid/xeno = user
if(xeno.has_fine_manipulation)
return attack_hand(user)
user.changeNext_move(CLICK_CD_MELEE)
user.do_attack_animation(src)
if(circuit)
+4 -3
View File
@@ -341,10 +341,11 @@ Class Procs:
return 1
if(user.lying || user.stat)
return 1
if ( ! (istype(usr, /mob/living/carbon/human) || \
istype(usr, /mob/living/silicon)))
usr << "\red You don't have the dexterity to do this!"
if(!user.IsAdvancedToolUser())
user << "\red You don't have the dexterity to do this!"
return 1
/*
//distance checks are made by atom/proc/DblClick
if ((get_dist(src, user) > 1 || !istype(src.loc, /turf)) && !istype(user, /mob/living/silicon))
@@ -183,7 +183,7 @@ obj/item/device/flashlight/lamp/bananalamp
update_brightness(U)
else
update_brightness(null)
/obj/item/device/flashlight/flare/update_brightness(var/mob/user = null)
..()
if(on)
@@ -207,7 +207,7 @@ obj/item/device/flashlight/lamp/bananalamp
src.force = on_damage
src.damtype = "fire"
processing_objects += src
/obj/item/device/flashlight/flare/torch
name = "torch"
desc = "A torch fashioned from some leaves and a log."
+2 -2
View File
@@ -384,7 +384,7 @@ REAGENT SCANNER
if (crit_fail)
user << "\red This device has critically failed and is no longer functional!"
return
if (!(istype(user, /mob/living/carbon/human) || ticker) && ticker.mode.name != "monkey")
if (!user.IsAdvancedToolUser())
user << "\red You don't have the dexterity to do this!"
return
if(reagents.total_volume)
@@ -441,7 +441,7 @@ REAGENT SCANNER
/obj/item/device/reagent_scanner/afterattack(obj/O, mob/user as mob)
if (user.stat)
return
if (!(istype(user, /mob/living/carbon/human) || ticker) && ticker.mode.name != "monkey")
if (!user.IsAdvancedToolUser())
user << "\red You don't have the dexterity to do this!"
return
if(!istype(O))
+1 -1
View File
@@ -15,7 +15,7 @@
user << "<span class='danger'>\The [src] cannot be applied to [M]!</span>"
return 1
if (!(istype(user, /mob/living/carbon/human) || istype(user, /mob/living/silicon)))
if (!user.IsAdvancedToolUser())
user << "<span class='danger'>You don't have the dexterity to do this!</span>"
return 1
+2 -2
View File
@@ -169,8 +169,8 @@
afterattack(atom/target as mob|obj|turf|area, mob/user as mob, flag)
if (flag)
return
if (!(istype(usr, /mob/living/carbon/human) || ticker) && ticker.mode.name != "monkey")
usr << "\red You don't have the dexterity to do this!"
if (!user.IsAdvancedToolUser())
user << "\red You don't have the dexterity to do this!"
return
src.add_fingerprint(user)
if (src.bullets < 1)
+1 -1
View File
@@ -287,7 +287,7 @@
/turf/simulated/wall/attackby(obj/item/weapon/W as obj, mob/user as mob, params)
user.changeNext_move(CLICK_CD_MELEE)
if (!(istype(user, /mob/living/carbon/human) || ticker) && ticker.mode.name != "monkey")
if (!user.IsAdvancedToolUser())
user << "<span class='warning'>You don't have the dexterity to do this!</span>"
return
@@ -36,7 +36,7 @@
/turf/simulated/wall/r_wall/attackby(obj/item/W as obj, mob/user as mob, params)
user.changeNext_move(CLICK_CD_MELEE)
if (!(istype(user, /mob/living/carbon/human) || ticker) && ticker.mode.name != "monkey")
if (!user.IsAdvancedToolUser())
user << "<span class='warning'>You don't have the dexterity to do this!</span>"
return
@@ -1758,11 +1758,9 @@
return (health <= config.health_threshold_crit && stat == UNCONSCIOUS)
/mob/living/carbon/human/IsAdvancedToolUser(var/silent)
/mob/living/carbon/human/IsAdvancedToolUser()
if(species.has_fine_manipulation)
return 1
if(!silent)
src << "<span class='warning'>You don't have the dexterity to use that!<span>"
return 0
/mob/living/carbon/human/get_permeability_protection()
+8 -12
View File
@@ -18,23 +18,23 @@
var/speak_exclamation = "declares"
var/speak_query = "queries"
var/pose //Yes, now AIs can pose too.
var/sensor_mode = 0 //Determines the current HUD.
var/next_alarm_notice
var/list/datum/alarm/queued_alarms = new()
#define SEC_HUD 1 //Security HUD mode
#define MED_HUD 2 //Medical HUD mode
var/local_transmit //If set, can only speak to others of the same type within a short range.
var/obj/item/device/radio/common_radio
/mob/living/silicon/New()
silicon_mob_list |= src
..()
add_language("Galactic Common")
init_subsystems()
/mob/living/silicon/Destroy()
silicon_mob_list -= src
for(var/datum/alarm_handler/AH in alarm_handlers)
@@ -43,8 +43,8 @@
/mob/living/silicon/proc/SetName(pickedName as text)
real_name = pickedName
name = real_name
name = real_name
/mob/living/silicon/proc/show_laws()
return
@@ -267,9 +267,6 @@
sensor_mode = 0
src << "Sensor augmentations disabled."
/mob/living/silicon/IsAdvancedToolUser()
return 1
/mob/living/silicon/proc/receive_alarm(var/datum/alarm_handler/alarm_handler, var/datum/alarm/alarm, was_raised)
if(!next_alarm_notice)
next_alarm_notice = world.time + SecondsToTicks(10)
@@ -310,7 +307,7 @@
reported = 1
src << "<span class='notice'>--- [AH.category] Cleared ---</span>"
src << "\The [A.alarm_name()]."
if(alarm_raised)
src << "<A HREF=?src=\ref[src];showalerts=1>\[Show Alerts\]</A>"
@@ -326,4 +323,3 @@
for(var/obj/machinery/camera/C in A.cameras())
cameratext += "[(cameratext == "")? "" : "|"]<A HREF=?src=\ref[src];switchcamera=\ref[C]>[C.c_tag]</A>"
src << "[A.alarm_name()]! ([(cameratext)? cameratext : "No Camera"])"
+7
View File
@@ -102,3 +102,10 @@
. = min(., shared_living_nano_distance(src_object))
if(. == STATUS_UPDATE && (TK in mutations)) // If we have telekinesis and remain close enough, allow interaction.
return STATUS_INTERACTIVE
/mob/living/carbon/alien/default_can_use_topic(var/src_object)
. = shared_nano_interaction(src_object)
if(. != STATUS_CLOSE)
. = min(., shared_living_nano_distance(src_object))
if(!IsAdvancedToolUser())
. = STATUS_UPDATE