cyberpresidentvanellope/Paradise
1
0
Fork 0
mirror of https://github.com/ParadiseSS13/Paradise.git synced 2026-07-17 01:53:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Restricts the visibility of some more variables in the VV menu (#22788)

Browse Source 
* more admin-only vv restrictions

* even more

* hopefully the last of them
This commit is contained in:
SteelSlayer
2023-10-09 01:29:14 -05:00
committed by GitHub
parent 0512f8a674
commit dded4e54a6
3 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/controllers/globals.dm
+5
View File
@@ -37,6 +37,11 @@ GLOBAL_REAL(GLOB, /datum/controller/global_vars)
stat("Globals:", statclick.update("Edit"))
/datum/controller/global_vars/can_vv_get(var_name)
var/static/list/protected_vars = list(
"asays", "admin_log", "logging", "open_logging_views"
)
if(!check_rights(R_ADMIN, FALSE, src) && (var_name in protected_vars))
return FALSE
if(gvars_datum_protected_varlist[var_name])
return FALSE
return ..()
code/controllers/subsystem/tickets/tickets.dm
+7
View File
@@ -719,6 +719,13 @@ UI STUFF
SSdbcore.MassExecute(all_queries, TRUE, TRUE, FALSE, TRUE)
/datum/controller/subsystem/tickets/can_vv_get(var_name)
var/static/list/protected_vars = list(
"allTickets"
)
if(!check_rights(R_ADMIN, FALSE, src) && (var_name in protected_vars))
return FALSE
return TRUE
#undef TICKET_STAFF_MESSAGE_ADMIN_CHANNEL
#undef TICKET_STAFF_MESSAGE_PREFIX
code/datums/datumvars.dm
+2 -2
View File
@@ -14,7 +14,7 @@
/mob/can_vv_get(var_name)
var/static/list/protected_vars = list(
"lastKnownIP", "computer_id"
"lastKnownIP", "computer_id", "attack_log_old"
)
if(!check_rights(R_ADMIN, FALSE, src) && (var_name in protected_vars))
return FALSE
@@ -22,7 +22,7 @@
/client/can_vv_get(var_name)
var/static/list/protected_vars = list(
"address", "computer_id"
"address", "chatOutput", "computer_id", "connection", "jbh", "pm_tracker", "related_accounts_cid", "related_accounts_ip", "watchlisted"
)
if(!check_rights(R_ADMIN, FALSE, mob) && (var_name in protected_vars))
return FALSE