* Refactor/deduplicate camera eye code
Camera Eyes previously had duplicated logic across several files. This
change uncooks the spaghetti. Additionally, half-baked support for TG's
multicam feature has been removed, as it was not functional or in use.
* lets ff now
* Camera Eye refactor fixes and finishing touches
This change completes a refactor of AI eyes, which were previously used
by xenobio consoles, syndicate and abductor camera consoles, shuttle
docking computers, holograms, and, of course, the AI. Duplicated logic
has been extracted to an abstract base mob, /mob/camera/eye, from which
new types for each of the above now derive.
Functionality is largely the same, with only a few minor cosmetic
differences (i.e. camera eyes are now appropriately named given their
type and user), as well as a quality-of-life enhancement for holograms,
slowing their movement speed to base run speed to prevent users from
accidentally zooming out of calls.
* Camera eye refactor: Fix AI acceleration toggle
The acceleration toggle was broken in the camera eye refactor, as
previously the boolean was stored on the AI rather than its eye. This
change fixes that.
* Camera eye refactor: Fix syndicate cam visibility
With the camera eye refactor, the syndicate advanced camera consoles
lost the ability to view maintenance tunnels and other areas without
active cameras, seeing static in their place instead (as all other
cameras do). This change reinstates the original behavior.
* Camera eye refactor: Convert spaces to tabs
* Camera eye refactor: Fix CRLF
* Apply suggestions from code review
General minor code quality improvements suggested by GDNgit
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
* Apply suggestions from code review
Rename parameter names to avoid src accesses, remove an ambiguous and
unused mob_define and holopad range variable from a previous WIP, change
the for loop in /mob/camera/eye/relaymove to a for-to loop, and change
the chat message warning, sent when an AI Eye is created on an AI that
already has one, to a stack trace
* Adds toggle to AI commands for fast holograms
* Refactor ripped Hologram Eye relaymove
Previously, the relaymove proc for hologram eyes was redundant and
nearly impossible to read. It has been separated out into a few
different named procs, and has had its use of `spawn` removed.
* Remove unnecessary src access
* Fix bug involving shuttle placement outlines
The camera eye refactor that this commit is a part of introduced a bug
that prevented shuttle placement outlines from showing up on first use
of the shuttle console. This change fixes that bug.
* Unrevert some changes from #26306 lost in merge
* Remove erroneous free xray vision on advanced cams
* Autodoc camera acceleration vars
* Remove redundant null var initialization per code review
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
* Changed variables to camel_case, autodocs, cleanup
Changed a number of camera eye-related variables to camel_case style,
added appropriate autodoc comments, as per code review. Also removed an
unused cameranet function, modified the call signature of a cameranet
function to be more semantic, and changed a qdel-on-initialize in camera
eyes to return INITIALIZE_HINT_QDEL instead.
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Remove stray qdel(src) per code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
---------
Signed-off-by: asciodev <81930475+asciodev@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Didn't work
* It works
* Emojipedia
* Some emoji sorting
* lol
* Remove a lot of shit emoji
* Update emojipedia.dm
* Observer and ghost-bar emoji
* Msay emoji
* Emoji sorting and updates
* Make emoji centered
* Clueless and trollface
* Mowzers
* +taa
* Another rebuild
* TRUE and Rebuild
* CI
* undef
* hooooly crap
* yeah
* false by default
* fixes
* alright, there we go
* oops lmao
* lol, lmao even
* proper programming
* fix
* losin my mind
* oops
* yeah coloring
* WE LOVE MULTIPLE DEFINES (ive lost my sanity)
* initial commit (broken)
* load the html
* fix this
* Fix various issues with browser statpanel
* Fix Alt Clicking opening up a window and Add back some object verbs to the browser stat panel
* Optimize stat panel and fix guardian verbs
* Restyles Stat Panel, Adds Subpanel Sub-Categories
* Use better layout for verbs in stat panel
* Updates statpanel verb widths to be more dynamic at higher screen resolutions.
* Adjust stat panel grid item widths and breakpoints
* refactors statpanel to use tgui API
* CI moment
* more CI
* this stupid thing
* Apply suggestions from code review
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* Update code/modules/client/client_procs.dm
* ci fix
* emergency mc debug view
* temp revert some code change suggestions due to massive runtiming
* proper atom click topic implementation
* optimise
* mob clicking in stat panels work
* yeet spell tab thingy
* yeet simple stat panel pref
* allow insertion of html into MC tab content
* tidy up status tab
* Apply suggestions from code review
* fix this
* fix CI
* oops
* fix index runtime
* fixes MC tab showing up for mentors, fixes runtime
* safeties!
* Return of theme support
* more fixes
* fix view range pref, tidy prefs tab
* Remove old stat panel from themes
* fixes
* make sure verbs don't go missing
* fix ooc/looc breaking
* Revert "make sure verbs don't go missing"
This reverts commit 7d07ad45ed.
* fix this properly
* fix stat panel hitting rate limiters
* fix borg status tab
* Object Window Niceties
* Adds file cycling for icon2base64
* optimizes icon2html() for icon files known to be in the rsc at compile time
* CI moment
* remove dupe emergency shuttle timers
* more robust verb updates
* statpanel tweaks
* zip archived changelog to avoid search results
* optimise
* fix mentor chat wonkyness when disabled
* debug log moment
* i am very smart
* reintroduce this because it was needed
* better time listings
* less jank
* stops telling admins they arent mentors
* returns MC tab pref for admins
* Update code/controllers/subsystem/SSstatpanel.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* lewcc
* OD typemaker prep
---------
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Aylong <alexanderkitsa@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* TGUI upgrade project: Port initial TGUI 4.0 changes from TG (#23440)
* tgui4.0
* bugfix for un-interaction
* fix for input not resetting on close
* NTOS restore
* fix all interfaces having scrollbars, fix colours
* bundle update
* dep bumps
* bumps the deps as much as possible
* button regression fix
* TGUI test map rev 1
* fix theme and some component regression
* fix login screen regression
* fixes regression with uplink cart
* bundle
* fix regressions
* fix the input issue, again
* regression fixes, stylesheet edition, hash restore
* fixes GPS BSOD
* draggable control regression
* dev server dep regression
* byondUI regression fix
* section regression fix
* fix secure storage weirdness
* Fixed mining vendor scrolling
* Arthri review pass 1
* mining vendor double-scroll
* fix for RPD, AirAlarm, and Radio
* arthri review pass 2
* arthri review pass 3
* sanitize var setting, fix colours, delete unused file
* adds CI to branch
* god damn AI making random changes
* I should remember to compile when changes are made
* fixes scrollbar issues
* fix camera console, fix flexGrow for sections
* CI fix
* nanomap fix
* Update code/modules/atmospherics/machinery/airalarm.dm
* restore margin
* style semicolon
* TGUIv4 - Moves TGUI Window Sizing from DM to JS (#23524)
* Initial commit
* Transferring the remaining windows to JS
* Resizing part 1
* Resizing part 2
* Some reverts and polish
* Forgot that
* undeployed nuke window size
---------
Co-authored-by: Aylong <alexanderkitsa@gmail.com>
* TGUIv4: Remove force_open (#23537)
* First state fixes
* Removes "force_open"
* TGUIv4 - TGUI Version 4.1 (#23547)
* Reduced Logging Changes
* setSharedState early return for non-interactive UI
* TGUI version bump to 4.1
* Fix sending updates for non-interactive UIs
* Scalablue UI Stylesheet Changes
* CSS Tgui Bundle
* JavaScript TGUI Style Changes
* Update tgui/packages/tgui/styles/base.scss
Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com>
* Additional changes to Input and Button scalability
* TGUI logging proc update
* Indentation fix for logging proc
* Update code/__HELPERS/_logging.dm
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* Additional log_tgui changes
---------
Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com>
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* dev server hotfix (#23584)
* ui_interact object constructor argument check (#23594)
* feat: add smart asset cache, add CDN support for assets, properly group assets (#23585)
* feat: add smart asset cache, add CDN support for assets, properly group assets
* fix: make tgui actually work
* fix: keeping local name for `tgui.bundle.js` and `tgui.bundle.css` for debug and dev server functioning
* fix: make `fontawesome` assets finally work
* fix: make proper identation for `if`
* fix: add `resolveAsset` to `NanoMap.js`
* refactor: update `claw_game` and `chess` to new asset framework
* refactor/tweak: don't use string concatenation for browser `content` and `head_content`, use list instead. Don't use `common.css` for paper UI, keep local name for stamp image assets, replace hard ref of browser to `atom` (rare case) to `UID`
* refactor: remove redundant debug logs
* refactor: remove space betwee `if` and `(`
* refactor: remove one more redundant log, properly reload UI resources
* rafactor: change names of asset files
* fix: adjust existing UIs to properly use assets
* fix: properly pass args to to `onclose` proc
* Update code/modules/asset_cache/transports/asset_transport.dm
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* Update code/modules/asset_cache/transports/asset_transport.dm
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* TGUI 4.2: TGchat + Refactor Asset Delivery + Yarn Berry (#23643)
* tgchat
* Little cleanup
* Refactor Asset Delivery (Part 2)
* Little tweaks
* fix code styling issues
* fix file name duplications
* Browser window options fix @gaxeer
* transfer valve fixes
* yarn berry initial
* vsc tasks
* yarn berry working
* node 20
* fix dev server (lol wrong yarn)
* bloody regressions
* fixes that damn scrolltracking bug
* Some tweaks and flexGrow deletions
It still doesn't work as it should, which makes me nervous
* remove unneeded deps
* 514 regression fix
* change stuff to not conflict with other servers
* name it as requested
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* revert test_TGUI map addition
* TGUI 4.3: Stack, Webpack 5 & UI Tweaks, Yarn 3.6.4, TS support, Jest (#23677)
* Stack & UI's Refactor
Almost final, polish required
Stack & UI's Refactor (Part 1)
Stack & UI's Refactor (Part 2)
Stack & UI's Refactor (Part 3)
* Prettier
Maybe bad
* ClearChat & some tweaks
* Adds a Chat Reliability Layer https://github.com/tgstation/tgstation/pull/79479
* Fix chat BSOD
https://github.com/tgstation/tgstation/pull/79821
* WebPack 5 (Didn't work)
I hate this shit
* Yarn 3.6.4
* make it all work
* revert snowflake fix
* Stories
* adds TS support
* re-enable test and prettier
* update yarn sdk's
* Fix some box regression
* ping/reply
* Fixes regressions and some things
* Zebra and Fix chat button transfer
+rebuild
* make VSC use the proper local typescript lib
* Popper Tooltips https://github.com/tgstation/tgstation/pull/58980
* Popper Tooltips performancy fixes
* Dropdown v2 https://github.com/tgstation/tgstation/pull/75164
Without Icon.tsx
* BB test map
* run build
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* we moved these
* change test values
* ignore scss files
* change hash function
* TGUIv4: TGchat fix traitor codeword highlighting (#23720)
* Codeword highlighting for TGUIv4
* null safeties
* Apply suggestions from code review
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
---------
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* TGUIv4 - updates standalone build tooling (#23721)
* swap `xxhash64` for `md4`
* remove hash function
* remove old file
* TGUI 4.3+4.4: Newscaster fix, `inline-block` replacements and other fixes (#23722)
* TGUI 4.3 fixes
Newscaster fix + inline-blocks
* Be gone Box
* Mod Chat -> Mentor Chat
* Some warning filters
* Rebuild
* Delete tgui-common.bundle.js
* please work
* try it like this
* 4.3.1
* 4.3.2
* fix
* i forgot to build
* 4.4.0
* give me more diff details please so I can fix you
* its not binary pls git
* test without svgs
* removes an un-needed SVG file
* inlined SVGs test
* fix code styling
* comment these
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* TGUIv4 - Removes resizable and improves drag code (#23719)
* Initial commit
* bundle rebuild
* Fixes Radio Sizing
* Updates Radio sizing to fix wrapping issues
* fix dev server
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* fix hotkeys not being passed to BYOND
* Apply suggestions from code review
* bump deps
* forgot these deps
* ci fix
* ChemDispenser fixes and HoloControl cooldown
* Station Traits TGUI
+Rebuild
* CI
* fix CI for real this time
* I have no idea
* fix station trait panel
* Update code/controllers/subsystem/SSping.dm
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Update code/controllers/subsystem/SSticker.dm
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* Update code/controllers/subsystem/SSping.dm
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
* deterministic module IDs
* TGUI fixes. Again... (#23762)
* TGUI Fixes: Part 1
ORM icon for reinforced glass now showing correctly
Mining vendor moved to Stack
Exofab UI buttons descended from the heavens to the earth
* TGUI Fixes: Part 2
DestTagger now works, forgot import LabeledList
PowerMonitor graph displays correct
Request Console updated to 2.0, BUT, problem with message priority, it was there before the changes, maybe even before the project, I'll have to check it out
* TGUI Fixes: Part 2
Fixed `onEnter` input
Fixed Cloning Console storage (Im dumbass)
Some windows resizing
Fixed bad picture in security and medical records console
Fixed scrollable dropdown
Added translucent color for buttons
* Fucking uplink DONE, and Button.Input fix
* NT Recruiter and Uplink polish
* Del LabeledList from dest. tagger
* ChemMaster and OreRedemption log deletion
* Update test_tiny.dmm
* Translucent button story
* Filter for SQL error
* del: `log_debug` in `hear_say.dm`
* Some little fixes and SpecMenu Stack
* Panel.js: mx -> mr
* fix ghost spawners
* null check
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* fix material name in protolathe
* fix various UI interacts
* card machine runtime fix
* remove legacy folders
* TGUIv4 - TGchat Theme Adjustments (#23772)
* Initial commit
* Changes rule grouping
* Robot class style changes and webpack config
* Reverts webpack/font changes and subs robot font
* revert a state changed in error
* fix uninteractable UIs due to chunky fingers
* TGUIv4: More fixes, tweaks and fixes for tweaks (#23781)
* I fuckin hate PDA
* Vending
* Add `|` to highlight splitters and some light mode tweaks
* Teleporter rewrite
* APC and AiAirlock (God forgive me)
* clarify highlight syntax
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* TGUIv4 - Abductor Experiment Machine TGUI (#23776)
* Experiment Console TGUI
* Update for TGUIv4
* UI Size adjustment
* ui state and ghost attack update
* remove this
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
* fix
* TGUIv4 - Adjustments, Fixes, and Tweaks (#23785)
* Photocopier layout adjustments
* Autolathe Text and Button spacing adjustment
* Hotkey fix for moving bug
* Removes rule sets for visited links
* Fixes ordering multiples on cargo console
* fix possible wonky json payloads
* fix admin log input list stuff
* TGUIv4: Reconnect fix and some other fixes + tweaks (#23790)
* Fix reconnecting and transfer it to TSX
* RPD polish
* RCD, AccessList, GuestPass
* Focus reset fix when camera switched. God forgive me again...
* Purple box and identation fixes
For votes and health scanner
* ChemMaster and ChemDispenser
ChemMaster - translucent pills buttons and no grow produce section
ChemDuspenser - dynamic height
* ShuttleManipulator Tabs
* RCD buttons
* make input bar mode more prominent
* fix chem master icons
* tab fix
* Properly sanitizes loaded messages in tgui chat
* TGUIv4 - Adjustments, Fixes, and Tweaks v2 (#23795)
* Fixes icon spacing for nanobank tabs
* Tweaks Dropdown styling
* Fixes sending stuff to old chat
* OpenDream TGUI fix
* Resizes Station Traits window
* Adjusts health analyzer messages for chat tabs
* Revert "Properly sanitizes loaded messages in tgui chat"
This reverts commit 4c32a7094a.
* Revert "Revert "Properly sanitizes loaded messages in tgui chat""
This reverts commit 24afa55922.
* Changes how tgui handles static data
* Reenable no-undef rule. Enable Format On Save for VSCode (#23803)
* Enable Format On Save for VSCode
* Re-enable and fix no-undef
---------
Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
* pda scanner message improvements
* fix mentor/admin PMs being sent to the "unsorted" category
* fix garbled custom vote messages
* moves cyborg analyser to use chatboxes
* fixes regression
* Prevent F5 reload
* TGUIv4: Themes polish and some new ones + misc fixes (#23814)
* Little themes tweaks
* NTOS chat theme
* Update tgui-panel.bundle.js
* Capitalize themes
* Paradise theme v1.0
* Little StationTraitsPanel cleanup
* Update member_content.dmi
* NoCapitalize
* Rebuild
* Delete Paradise.scss
* Create paradise.scss
* Forgot
* Rewritten Security Records Console
For Jesus fucking christ...
* Vending and Wires sizes tweaks
* ThermoMachine
* Syndicate Theme
* Little darker
* Rewritten Medical Records Console
* PDA Nanobank fix
* Syndicate Theme Darker
* Rebuild TGUI
* Wires section grow fix
* fixes the enshittified paradise icon
* Sirryan+Warrior reviews
* bloody define comments
* comment correction
* unprivate these
* errant . begone (how did this not cause a compiler error)
* TGUIv4 - Adjustments, Fixes, and Tweaks v3 (#23807)
* Fixes ERT Manager silenced message function
* Adjusts progress bar on ExosuitFabricator
* Sets Dropdown selected to align left
* Removes the use of self_state select interfaces
* Exosuit Fabricator style adjustments
* fix sextractor UI
* remove empty tochat string
* fix human air alarm interactions
* fix modals
* add F12/IEChooser
---------
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
---------
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Co-authored-by: Aylong <alexanderkitsa@gmail.com>
Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com>
Co-authored-by: Gaxeer <44334376+Gaxeer@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
Co-authored-by: Arthri <41360489+Arthri@users.noreply.github.com>
Co-authored-by: Arthri <41360489+a@users.noreply.github.com>
* adds the stealth implant
* changes
- rename "implant" to "bio-chip"
- removes the stealth implant box in favor of spawning implant directly for the traitor
- makes the fake box not show up on right click. Makes the real box not show up on right click when invis
* sirryan pt1
* lewcc review 1
* fix conflict
* fix conflict
* signal handler
* crawling?
* knockdown. CONTAINS CHANGES THAT NEED REVERTING
* plotting can_moves death
* CANMOVE IS DEAD
* mappers are insane
* removes todos as the are todone
* decreases crawling speed
* silly-con fixes
* surgery fixes
* fixes death
* pAI fixes
* removes var/lying
* runtime fix
* decreases default crawling speed
* correct crawling dir
* some more fixes
* stunbaton tweak, revert later
* rejuv fix
* restraint and incapacitated refactor
* crawling dir in line with TG
* fixes vehicle movement and grabs
* alien rest fixes
* antistun fixes
* fixed fall sounds
* forgor to stage this
* first review
* canmove zombie dispersal
* fix
* lots of fixes
* defines
* fixes the trait helper
* if you got no legs you can still crawl
* sillyconfix
* no reverty keepy
* jaunt fix
* hopefully fixes perma sleepy zzz
* admin rejuv temp fix
* rest canceling
* antistun chems now remove knockdown
* buckle offset fix
* fixes some stuff
* crawling delay = 4
* descuffs bed
* sleeping hotfix
* fixes simple mob resting
* V is the macro for resting
* projectiles no dodgy
* refines the projectile check
* god I hate strings
* MORE FIXES
* I hate buckling
* fixes capulettium plus
* winding down
* farie review
* bugs did stop showing up
* SEAN
* todo
* sean review
* ed209
* i HATE cyborgs
* steel review
* laaaaaast things
* reverts stun baton changes
* and done
* Fit Viewport V1
* Scoreboard
* Moderate scoreboard refactor
Mostly just removing the global variables, since Mochi has plans for a proper big scoreboard refactor in the future.
