* refactor: Movement cross/uncross implementation.
* wrong var name
* fix unit tests dropping PDAs into nowhere
* Add documentation.
* remove unused constants
* say which procs are off limits
* fix simpleanimal z change runtime
* helps not to leave merge conflicts
* kill me
* fix typecast
* fix projectile/table collision
* treadmills don't cause MC to crash anymore
* connect_loc is appropriate here
* fix windoors and teleporters
* fix bonfires and clarify docs
* fix proximity sensors
Tested with sensors in crates, sensors in modsuits
Tested new proximity component with firing projectiles at singularity
Tested new proximity component with portable flashes
Tested new proximity component with facehuggers
* lint
* fix: polarized access helper false positives
* Revert "fix: polarized access helper false positives"
This reverts commit 9814f98cf6.
* hopefully the right change for mindflayer steam
* Changes following cameras
* fix glass table collision
* appears to fix doorspam
* fix ore bags not picking up ore
* fix signatures of /Exited
* remove debug log
* remove duplicate signal registrar
* fix emptying bags into locations
* I don't trust these nested Move calls
* use connect_loc for upgraded resonator fields
* use moveToNullspace
* fix spiderweb crossing
* fix pass checking for windows from a tile off
* fix bluespace closet/transparency issues
* fix mechs not interacting with doors and probably other things
* fix debug
* fix telepete
* add some docs
* stop trying to shoehorn prox monitor into cards
* I should make sure things build
* kill override signal warning
* undef signal
* not many prox monitors survive going off like this
* small fixes to storage
* make moving wormholes respect signals
* use correct signals for pulse demon
* fix pulse heart too
* fix smoke signals
* may have fucked singulo projectile swerve
* fix singulo projectile arcing
* remove duplicate define
* just look at it
* hopefully last cleanups of incorrect signal usage
* fix squeaking
* may god have mercy on my soul
* Apply suggestions from code review
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* lewc review
* Apply suggestions from code review
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
* burza review
* fix bad args for grenade assemblies
* Update code/__DEFINES/is_helpers.dm
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
---------
Signed-off-by: warriorstar-orion <orion@snowfrost.garden>
Co-authored-by: DGamerL <daan.lyklema@gmail.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
* refactor: Attack chain, initial setup.
* migrate curtain to make dreamchecker happy
* update thurible
* don't call attacked_by separately for legacy attack chain
* remove duplicate proc
* condense similar code, put allowances for legacy code in new procs
* update docs, include diagram source
* add comment on how to update diagram
* fix admonition
* mindflayer updates
* remove commented out code
* clarify all steps
* after_attack should be overridable
* whoops
* retrofit recent changes
* duh, can't restrict this yet because of tool_acts
* i hate ore bags with the fire of a thousand suns
* return correct value for object attack logic
* Various cleanups.
We don't want to attempt to pull stuff out of `/obj/item/attackby`,
because those pieces are part of the related objects' migrations, not
`/obj/item` itself. Attempting to do this causes knockon effects where
things expected to call e.g. `/obj/item/storage/attackby` in the call
chain were not ferried over to the new item interaction code, because
the related objects hadn't actually been migrated over yet.
I've used refactoring /obj/vehicle as the example for migrating
`attackby` methods instead.
* simplify some argument names
* fuck it
* make it do the thing
* Rename CI module call
* Prove that CI works
* improve test output
* aaand fix it again
* fix curtain tool interactions
* fix compile error
* fix compile error
* Better docs, introduce migration plan tool.
* Globals work
* Double access works
* All other things
* Revert "All other things"
This reverts commit 6574442eb6.
* More changes that compile and work
* IT WORKS AAAAAA
* Changes even more .len to length()
* Apply suggestions from code review
* Update code/datums/mind.dm
* Update code/__HELPERS/sorts/InsertSort.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Update code/__HELPERS/sanitize_values.dm
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
---------
Co-authored-by: FunnyMan3595 (Charlie Nolan) <funnyman@google.com>
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com>
* Puts some of the stack crafting code onto the stack recipe datum to allow for more and easier customization of what happens when a recipe is crafted.
* Very important spacing.
* Better returns.
* Removed \the macro, fixed bug in message that occurs when lacking resources for a construction.
* The do_after() should probably be on do_build()
* robot_module refactor
* some fixes
1. adds medical stacks of 25 for the syndi medical borg
2. fixes various construction steps that weren't using `use()` or `get_amount()`
* review tweaks + other stuff
1. Makes a bunch of for loops into istypeless loops
2. Adds a readout of the current out of stacks a borg has, in the status panel
3. Slightly reorganizes the medical, syndi medical, engineering and syndi engineering cyborgs items
* fixes after upstream merge
* blank line for travis
* fixes and improvements
1. Fixed welder icon's not updating periodically if you were charging in a borg recharger
2. Fixes solar panels dropping /cyborg type glass when they were deconstructed.
3. Band-aid fix (incase #2 doesn't fix this) for cyborg stack's `source` var being null which resulted in tons of "cannot read null.energy" runtimes
* more fixes + constructable frame runtime fix
* removes toy sword placeholder
remove comment
* remove these as well
* .amount to .get_amount(), really should have done this before
* refactors robot_upgrades to work with the new system
- more cleanup
- adds documentation
- fixed a bug I made where you could delete your robot stack via crafting
* moves some unemag logic to the module file, makes more loops typless
* farie review
* fox review
* affected review and more TM bugfixes
* fixes comment
Co-authored-by: SteelSlayer <SteelSlayer@users.noreply.github.com>
* DMI files
* Progress
* we compiling
* innate cult action, various progress
* Reorganise runes, fix cult dagger action and admin cultist
* Cult tooltips, dagger icons
* Add mirror shield, return runes back to OG circles
* Cult structure lights, pylon update
* bola update, progress..
* cleaning rune fix, girder/structures anchor
* speed up cult walls
* Convert rune update, tweaks
* Add teleport portals
* fix runtimes
* cult objs start
* move current cult objs to backup
* Rework cult objectives, add narsie/singulo interactions
* spacing, admin log and message
* reviewstuff
* refactor cult conceal/reveal
* add a bit of range to reveal
* blood magic tweaks, hallway not in summon areas
* implement structure concealment, offer uncuff
* add parry sound, fix cult airlock reveal appearance
* Update remaining runes
* fix pylon blood restaure, up blood magic cost
* review tweaks and progress
* fix compilation
* fix offering rune bug
* Draw blood rune action refactor
* moar tweaks
* fixes, holy water blood magic clean, icons
* Add cultist hardsuit, tweaks
* reduce needed pylons for cult ghost, cult shield
* spirit realm fixes
* fix dark spirit
* Add blood rites
* exotic blood handling
* spacing, add adminbus dagger, bal. rune health cost
* woops
missed a var
* fix blood rite healing
* emp spell cult immunity
* fix exploit and narsie references
* new rune sprites
* color defines
* SEND_SOUNDS, cult summon areas
* fix soap, barrier, and add CC location on narsie
* cult structure fix
* functional ascendance, undo cult spacesuit changes
* woops
* whetstone qdel, tweaks
* fix empty area selection bug
* cult ascendance numbers
* add cult blade sprite, add sacrificing head/brains
* review stuff
* fix runtime and twisted cons target
* review stuff
* code clarity
* remove unnecessary cultist checks
* Add support for wizard cultists
* cleanip
* fix concealed glass airlocks
* update objs
* remove talisman ref
* fix status procs
* clarifications, remove unnecessary var
* deconflicting
* deconflicting LF
* oops
* readd new icons
* more conflcit stuff
* readd drill and jaws icons
* review stuff
* silence on conversion
* Readd compact sniper icons
* Remove ambiguity
* 2 sacrifices required
* check antag panel improvements, bug fixes
* limits narsie cult ghost cheese
* CC message
* trailing newlines
* Shade/construct update
* bug fixes
* balance bloodboil, update CC message
* add a newline to something i didnt touch
idk ask travis bout it
* remove metastation extra null rod and shard
* fix teleport runes list, update icon
* remove tg cultist icon
* update cult actions with new tome
* Remove mirror shield throw, spell constructs
Add in sacrificing any brain with a mind.
* Fix more conflicts
* Fix double return
* Add descriptions to cult recipes, fix icons
* fix shuttle curse exploit
* Update wall rune, cult shields, runed recipe width
* implement flagellant sprites, misc changes
* Fix conversion rune
* Add cult blood barrage healing
* Trailing line
* fix whitespace
* Remove can_speak check on invoke
* Deconflict pt. 2
* Bugfixes the 1st
Fixes bugs 2 and 4 in the 'Known Issues' section
* cult.dm tweaks
Oh boy, even more commits!
* Fixes blood halberds swapping directions on wield
* Tweaks and stylin'
Changed a few span classes around and added a 'Remaining Charges' display to the Blood Rite spell
* Ritual tweaks (And some other stuff)
Fixes:
Altar stray pixel,
Using 'Twisted Construction' on a cult door,
Rune drawing checks,
probably more idk
* Rune tweaks & fixes
Fixes:
Wraith glowing not turning off while jaunted,
A MASSIVE oversight by me with playsound(),
probably also some other stuff but I've been staring at this file for a week and I've forgot most of what I did.
* Testmerge fixes the 1st
Fixes:
Ascendent is now Ascendant,
The Cultist greeting is now in the correct order,
IPCs now draw oil coloured runes,
No longer able to sacrifice a body multiple times,
Sacrificing a brain or head now gives a soul shard,
Converting an IPC or someone with robotic limbs now heals them correctly,
Probably more.
* Mirror Shield balancing
Being hit by a projectile above a damage threshold (10) now increases the chances of the mirror shield shattering, by 3% per damage point.
This may seem pretty low, but an Energy Gun would have a 30% chance of breaking the shield per hit. (Assuming I did this right, anyway.)
* Insect repairs and more
Changes:
Makes the shuttle curse lines a define,
Comments out the changing construct names,
Made flagellant robes block hair,
Added documentation to the mirror shield (See said documentation for details),
Made the cooldown examine text for cult structures display minutes and seconds,
Removed the ability to sacrifice the same body multiple times,
Cleaned up the soulstone code (and hopefully didn't break anything),
Probably still missed something, oh well!
* Rune opacity and Stun timing
Changes:
Halved all the values of the 'Stun' spell, since it was presumably an oversight. (20 second stun to 10)
The 'mouse_opacity' for runes has been set to 'opaque', this means that clicking on any spot on the tile will select it. (Less fiddly)
The '(REMOVE SPELL)' choice when choosing spells now only shows if there's any spells to remove.
Dunking someones head in the lava forge now only works if they have a head.
Also fixed a whole bunch of typos/gramatical errors.
* Blood Boil, Blood Barrage and EMP Sprites!
Changes:
Overhauled the 'Blood Boil' rune (See documentation)
Added in-hand sprites and red sparks for 'Blood bolt barrage'.
The nar'sie rune now removes all runes around it to prevent clipping.
Fixed runtime when examining the 'Arcane Barrage' spell.
Added new sprites for the EMP spell, courtesy of @kugamo!
Co-Authored-By: Kugamo <thekugamo@gmail.com>
* A few more tweaks
Changes:
Halved the percentages of 'Rise' (Glowing eyes) and 'Ascend' (Halos) to 10% and 20% respectively.
Hopefully fixed shield walls being passable while active.
Changed "Nar-sie" to "Nar'sie" in a few places.
* TM 2 fixes
Changes:
Teleport runes now only show the user when the animation has finished.
Cult shields are now invisible to ghosts when disabled.
Crayon runes now use the new rune sprites.
Construct night vision now actually works.
You can no longer soulstone yourself.
The death message for cult structures is now bigger.
Cult objectives are now displayed at roundstart.
Tweaked the icons for artificer spells.
Tweaked some cult related 'Tip of the round's.
Summoned cult ghosts no longer show in the 'Check Antagonists' panel when dead. (Hopefully)
* Cult members and Deconversion
Changes:
Using the 'Study the Veil' ability now shows how many members the cult has.
Holy water now unequips all cult clothing on deconversion. (Flagellant robe, blindfold, etc.)
Nar'Sie no longer warns admins that it doesn't have a containment field.
Fixed Zealot's Blindfolds not temporarily blinding any non-cultists who touch them.
The 'Summon Cultist' rune description now explains that restrained cultists cannot be summoned.
Fixed Travis (Probably)
* Cult Rise/Ascend balancing V1
The values here will almost certainly need some tweaking, but I feel like it's better than it was before; and certainly more customisable.
* Possibly maybe hopefully (one of) the last commits
Changes:
The cult halo no longer vanishes on relogging.
It's now possible to drag things on to runes again.
* A few minor fixes, and a major one
Changes:
Resetting your action button positions no longer completely breaks blood spells.
The downside to this fix is that Blood spells can no longer be moved around, so sorry sorry about that.
Fixes: #14393Fixes: #13855
* New weapon sprites!
Adds fancy new sprites for all cult daggers and swords, courtesy of @McRamon!
They will need adjustments for Vox and Kidan at some point, and the Skrell inhand can look a bit odd at times, but those are also problems for every other weapon in the game so that can be fixed later.
Co-Authored-By: McRamon <31545294+McRamon@users.noreply.github.com>
* TM 3 fixes
Changes:
Fixed action button related bugs, including making them movable again! (probably caused a bunch more but eh),
Slightly tweaked threshold for ascendance,
Blood Rites now cleans up slime blood,
The Deconversion message is now bigger,
Flagellant robes now take 5% more damage (Lasers do 30 damage rather than 29),
Teleport runes can no longer be erased while a portal effect is open,
Teleport rune portals now always show the Z-Level if they're not in station space,
Teleporting another player no longer makes you temporarily invisible,
Attempting to summon a restrained cultist now gives said cultist a warning message,
Fixed a runtime when placing a soulstone in a construct,
Cultists now show on the Orbit menu if you have AntagHUD enabled,
Fixed a few typos
Co-authored-by: datlo <quentinkoyote@gmail.com>
Co-authored-by: Kugamo <thekugamo@gmail.com>
Co-authored-by: McRamon <31545294+McRamon@users.noreply.github.com>
* Fix stacks being consumed by redspace.
Fixes#12606
* Add comment on why (I think) the stack fix happens to work.
* Fix a potential minor logic error.
If the stack has no items left, we drop it, it gets merged
with another stack on the ground, then we should still report
the stack as having zero items.
Otherwise there's a potential to accidentally use items on the ground
once you run out of items in hand, which is slightly surprising.
* Adds support for self-filling reagent containers
* Sets tool_behaviour on the default set of tools
* Fixing merge conflicts
* Refactors welder to use tool behaviour
* The refactor: part I
* The refactor: part II
* Tool Refactor Part III: Revenge of the Maint
* Tool Refactor Part IV: A New Hope
* Tool Refactor Part V: The Oldcoder Strikes Back
* Tool Refactor Part VI: Return of the Coder
* VII
* Holy shit, it compiles?!
* Nannek I completed your TODO, you owe me ice cream
* Tool helpers; telepad is compliant
* Bugtest, Round 1: Fight
Fuck refactoring disposals
* Buggfixing, Round 2: Electric Boogaloo
* Personal crafting uses tool behaviours now
* Construction datums use new tool behaviours; better way of handling fueltank refuelling; more bugfixing
* multitool_check_buffer change; removes some useless things in tool_helpers
* proc name change
* TRUE/FALSE changes
* Bugfixing, Round 3: A Good Day To Bugfix Hard
Fixes multiple issues raised by the testmerge
* Minor style changes
If the stack has no items left, we drop it, it gets merged
with another stack on the ground, then we should still report
the stack as having zero items.
Otherwise there's a potential to accidentally use items on the ground
once you run out of items in hand, which is slightly surprising.
